From: Petri Latvala <petri.latvala@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/3] lib/igt_core: Disallow nesting of igt_dynamic inside igt_dynamic
Date: Tue, 5 May 2020 09:36:42 +0300 [thread overview]
Message-ID: <20200505063642.GI9497@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200504112623.285610-2-arkadiusz.hiler@intel.com>
On Mon, May 04, 2020 at 02:26:22PM +0300, Arkadiusz Hiler wrote:
> igt_dynamic is allowed only inside igt_subtest_with_dynamic
>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> lib/igt_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 43f0ba8b..662a0986 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -1280,6 +1280,8 @@ bool __igt_run_dynamic_subtest(const char *dynamic_subtest_name)
> {
> internal_assert(in_subtest && _igt_dynamic_tests_executed >= 0,
> "igt_dynamic is allowed only inside igt_subtest_with_dynamic\n");
> + internal_assert(!in_dynamic_subtest,
> + "igt_dynamic is not allowed to be nested in another igt_dynamic\n");
>
> if (!valid_name_for_subtest(dynamic_subtest_name)) {
> igt_critical("Invalid dynamic subtest name \"%s\".\n",
> --
> 2.25.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-05-05 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 11:26 [igt-dev] [PATCH i-g-t 1/3] lib/igt_core: Make assert on invalid magic blocks nesting more verbose Arkadiusz Hiler
2020-05-04 11:26 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_core: Disallow nesting of igt_dynamic inside igt_dynamic Arkadiusz Hiler
2020-05-05 6:36 ` Petri Latvala [this message]
2020-05-04 11:26 ` [igt-dev] [PATCH i-g-t 3/3] lib/tests: Add tests for magic control blocks nesting Arkadiusz Hiler
2020-05-05 6:41 ` Petri Latvala
2020-05-05 12:32 ` Arkadiusz Hiler
2020-05-04 12:15 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_core: Make assert on invalid magic blocks nesting more verbose Patchwork
2020-05-04 21:33 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-05-05 12:33 ` Arkadiusz Hiler
2020-05-05 6:36 ` [igt-dev] [PATCH i-g-t 1/3] " Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505063642.GI9497@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.