From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [GIT PULL FOR v5.8] Add Tegra210 Video input driver
Date: Tue, 5 May 2020 14:17:35 +0200 [thread overview]
Message-ID: <20200505141735.53526ede@coco.lan> (raw)
In-Reply-To: <c95abf33-bfd4-489f-2c20-536e76b848ce@xs4all.nl>
Em Tue, 5 May 2020 10:33:00 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> The following changes since commit e51759f56d314d28c25be7606b03791f048e44c7:
>
> media: v4l2-ctrls.h: clarify the p_def argument of v4l2_ctrl_new_std_compound (2020-04-29 12:04:58 +0200)
>
> are available in the Git repository at:
>
> git://linuxtv.org/hverkuil/media_tree.git tags/br-tegra
>
> for you to fetch changes up to 0bba0154ded02babccd59e21c6a27c5ad7d50faf:
>
> MAINTAINERS: Add Tegra Video driver section (2020-05-05 10:26:05 +0200)
>
> ----------------------------------------------------------------
> Tag branch
>
> ----------------------------------------------------------------
> Sowjanya Komatineni (2):
> media: tegra: Add Tegra210 Video input driver
> MAINTAINERS: Add Tegra Video driver section
As pointed by checkpatch:
WARNING: DT compatible string "nvidia,tegra210-csi" appears un-documented -- check ./Documentation/devicetree/bindings/
#628: FILE: drivers/staging/media/tegra-video/csi.c:521:
+ { .compatible = "nvidia,tegra210-csi", .data = &tegra210_csi_soc },
WARNING: DT compatible string "nvidia,tegra210-csi" appears un-documented -- check ./Documentation/devicetree/bindings/
#3238: FILE: drivers/staging/media/tegra-video/video.c:106:
+ { .compatible = "nvidia,tegra210-csi", },
and double-checked with:
$ git grep "nvidia,tegra210-csi"
drivers/staging/media/tegra-video/csi.c: { .compatible = "nvidia,tegra210-csi", .data = &tegra210_csi_soc },
drivers/staging/media/tegra-video/video.c: { .compatible = "nvidia,tegra210-csi", },
The DT specs for this driver are missing. I even checked at linux-next:
there's no DT bindings for this.
While the code sounds ok, I'll reject this PR. Please submit a new one
together with the DT file properly reviewed by DT maintainers.
Thanks,
Mauro
next prev parent reply other threads:[~2020-05-05 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 8:33 [GIT PULL FOR v5.8] Add Tegra210 Video input driver Hans Verkuil
2020-05-05 8:42 ` [GIT PULL FOR v5.8] Add Tegra210 Video input driver (#63596) Jenkins
2020-05-05 12:17 ` Mauro Carvalho Chehab [this message]
2020-05-05 12:24 ` [GIT PULL FOR v5.8] Add Tegra210 Video input driver Hans Verkuil
2020-05-05 14:15 ` Mauro Carvalho Chehab
2020-05-05 14:26 ` Hans Verkuil
2020-05-05 20:22 ` Thierry Reding
2020-05-05 20:39 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2020-04-24 12:00 Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505141735.53526ede@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skomatineni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.