From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB2DC47254 for ; Tue, 5 May 2020 15:23:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D66182073B for ; Tue, 5 May 2020 15:23:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KB0RsJHB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D66182073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVzQ5-00069H-2f for qemu-devel@archiver.kernel.org; Tue, 05 May 2020 11:23:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVzPP-0005hc-O7 for qemu-devel@nongnu.org; Tue, 05 May 2020 11:22:59 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:57133 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jVzPO-0005YX-UF for qemu-devel@nongnu.org; Tue, 05 May 2020 11:22:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588692177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=udu9YjlXQwXvgq093bxW3P1jJOiLZ4eVV1osHESK+dM=; b=KB0RsJHBQ1CTcG/r4rg6C+GreLfOhD8hfS7RLyNL3S+VKSccaI1CwJ53WrPrmXgHdcYOok RaUtKLJFfGoEnoEr5VHAzFECa/Gg2IantuMp/oGWnUlVCvZszR1OhDsLbBp4m9vqhAynaj 01SfPm/wSZnqmpMB7wX9kejuWDndN5g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-GT-O4w_NPoOKaPWr8HMHPg-1; Tue, 05 May 2020 11:22:55 -0400 X-MC-Unique: GT-O4w_NPoOKaPWr8HMHPg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DAC3E107ACF3; Tue, 5 May 2020 15:22:54 +0000 (UTC) Received: from localhost (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF1CA5D9D5; Tue, 5 May 2020 15:22:39 +0000 (UTC) Date: Tue, 5 May 2020 17:22:38 +0200 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v2 10/13] microvm: disable virtio-mmio cmdline hack Message-ID: <20200505172238.6bbaeb9b@redhat.com> In-Reply-To: <20200505134305.22666-11-kraxel@redhat.com> References: <20200505134305.22666-1-kraxel@redhat.com> <20200505134305.22666-11-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 00:37:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 5 May 2020 15:43:02 +0200 Gerd Hoffmann wrote: > ... in case we are using ACPI. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386/microvm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c > index 6ba2d9d3f028..a3708fdf1e39 100644 > --- a/hw/i386/microvm.c > +++ b/hw/i386/microvm.c > @@ -369,7 +369,8 @@ static void microvm_machine_reset(MachineState *machine) > CPUState *cs; > X86CPU *cpu; > > - if (machine->kernel_filename != NULL && > + if (!x86_machine_is_acpi_enabled(X86_MACHINE(machine)) && > + machine->kernel_filename != NULL && > mms->auto_kernel_cmdline && !mms->kernel_cmdline_fixed) { > microvm_fix_kernel_cmdline(machine); > mms->kernel_cmdline_fixed = true;