From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCD0C47254 for ; Tue, 5 May 2020 19:14:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9A5C206B9 for ; Tue, 5 May 2020 19:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728233AbgEETOH (ORCPT ); Tue, 5 May 2020 15:14:07 -0400 Received: from correo.us.es ([193.147.175.20]:55004 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726350AbgEETOH (ORCPT ); Tue, 5 May 2020 15:14:07 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 0856139626C for ; Tue, 5 May 2020 21:14:06 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id EEAE02067D for ; Tue, 5 May 2020 21:14:05 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E427ADA7B2; Tue, 5 May 2020 21:14:05 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0D425115410; Tue, 5 May 2020 21:14:04 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 05 May 2020 21:14:04 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id E0BC942EE38F; Tue, 5 May 2020 21:14:03 +0200 (CEST) Date: Tue, 5 May 2020 21:14:03 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Florent Fourcot Cc: Romain Bellan , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf-next v5 1/1] netfilter: ctnetlink: add kernel side filtering for dump Message-ID: <20200505191403.GA4129@salvia> References: <20200330204637.11472-1-romain.bellan@wifirst.fr> <20200426214338.GA2276@salvia> <66100a4b-a879-a8f4-f684-2b098a89cdc8@wifirst.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66100a4b-a879-a8f4-f684-2b098a89cdc8@wifirst.fr> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hello Florent, On Mon, May 04, 2020 at 09:37:37PM +0200, Florent Fourcot wrote: > Hello Pablo, > > We just posted a v6. We hope that this one will be the good one. Thanks, I'll review asap. > > The test this needs to be compiled via: > > > > gcc -lnetfilter_conntrack test-conntrack.c -o test > > > > Thanks for the pointer, it helped us a lot, it was not clear before for us > how to test it. I should have said since the beginning, I forgot about these tests when reviewing. > We applied patch on top of current net-next HEAD and it looks good for this > one (OK: 122 BAD: 0). Great. I'll review asap.