From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D84C47247 for ; Wed, 6 May 2020 02:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6E332075E for ; Wed, 6 May 2020 02:53:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="j1ofKvDT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726603AbgEFCxN (ORCPT ); Tue, 5 May 2020 22:53:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbgEFCxN (ORCPT ); Tue, 5 May 2020 22:53:13 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAE42C061A10 for ; Tue, 5 May 2020 19:53:12 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id t11so458607pgg.2 for ; Tue, 05 May 2020 19:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1CtP5FNOcKefe/Fa1C1BLCGuo+JOUuFdH1Z8Djbibw0=; b=j1ofKvDTJMSEa9A9oHELSXXGIIxOkdPrWOa8yR7W1C2RzH/XUiycpjKUNifMfYbGbY jqsxiP0YRJ2+6zA+1+RJ8Lzd2koIEghHA2o0NMMfLLOllkEHZtGCIAa0RfZATsCjKM4o /UC40jJr8c5QZMH9kbGACTQaOfrDPHR9/TCik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1CtP5FNOcKefe/Fa1C1BLCGuo+JOUuFdH1Z8Djbibw0=; b=IWeEneAChJbWmiQQ/eGTY8LG8AnB4sF0ICmZhvl3CVPgUeCWkBRXy0VhgvhvglgBju a5qOthXaGPCmRdX29LIOt+2xr3W1/TrH4BO9kyBIfueOM/WNkMRd9GWBNdcVH+CDxcS1 ptakHeSAvB0/TSA67YHBqI0LeDDn0wpz40i+TneWTjqnZ7Vr+huPZ5VLpTJ8cBxiD3zs cdjkfIVadlqDXRfT8DPKnDxasjQWVxahNVpZiQfmQ4dV/n+P296R2mw+lk1WIuQqZMe5 oyu3LE493OBUSEhN5qF9Px7MwQhC0ZX2hJTFyDnJoD+NSHtUc6Wp4iv6ZbIIcMOzx7Nv KOMQ== X-Gm-Message-State: AGi0PuaXbiD+f46oX4f/PIsp9trFgeMHHa75WP4x03L6wTK31r+nrW5J WWOAfw3GwBAQ4VOcT0PG8iNGkQ== X-Google-Smtp-Source: APiQypIxNUlmjtAUs1cla1nSjw6uo9XfK3/p4S7YPx37fzaZFOPefx3FkgGdn1P7/2EZYjoeU+NEJw== X-Received: by 2002:a62:b611:: with SMTP id j17mr5971991pff.214.1588733592406; Tue, 05 May 2020 19:53:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w11sm417431pgj.4.2020.05.05.19.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2020 19:53:11 -0700 (PDT) Date: Tue, 5 May 2020 19:53:10 -0700 From: Kees Cook To: Nick Desaulniers Cc: "Jason A. Donenfeld" , George Burgess , Nathan Chancellor , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , LKML , clang-built-linux , Arnd Bergmann Subject: Re: [PATCH] Kbuild: disable FORTIFY_SOURCE on clang-10 Message-ID: <202005051951.23FABC8C7@keescook> References: <20200505215503.691205-1-Jason@zx2c4.com> <20200505222540.GA230458@ubuntu-s3-xlarge-x86> <202005051617.F9B32B5526@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, May 05, 2020 at 04:36:49PM -0700, Nick Desaulniers wrote: > On Tue, May 5, 2020 at 4:22 PM Jason A. Donenfeld wrote: > > > > On Tue, May 5, 2020 at 5:19 PM Kees Cook wrote: > > > > > > (Though as was mentioned, it's likely that FORTIFY_SOURCE isn't working > > > _at all_ under Clang, so I may still send a patch to depend on !clang > > > just to avoid surprises until it's fixed, but I haven't had time to > > > chase down a solution yet.) > > Not good. If it's completely broken, turn it off, and we'll prioritize fixing. The problem is what George mentioned: it's unclear how broken it is -- it may not be all uses. I haven't had time to finish the testing for it, but it's on the TODO list. :) -- Kees Cook