From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1322DC4725B for ; Wed, 6 May 2020 04:17:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9DBE206DD for ; Wed, 6 May 2020 04:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588738660; bh=naqyp/H03c6y4iLNNY9qG1yMwqkqKKJO6Juu0Kr3MXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=icx9X5LBveiis6kSXRP40zksD2oFCXKeYTYqH6hV1OUYJYtlkF+5D8K0yLxOr1kXM TInGpRRUi+a5JilHX8NSDl9iJTWnXAEIwGJHlN3WEKhFsVJMUqGDyLVlAsp3DWfRhb Tkv/9LXrCPa0bklmcTVUg7xOiuAfiP3cB7EYGxvM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725892AbgEFERh (ORCPT ); Wed, 6 May 2020 00:17:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:57498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725300AbgEFERh (ORCPT ); Wed, 6 May 2020 00:17:37 -0400 Received: from localhost (unknown [122.181.213.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40E57206D5; Wed, 6 May 2020 04:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588738657; bh=naqyp/H03c6y4iLNNY9qG1yMwqkqKKJO6Juu0Kr3MXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eyh+xxkUnMKs8UNQTwVOGAznBrv+Cz2ViPf6RD+unlnTEZkU9EIttDjVHxdZXqN9C xWcOZ8NsPEMwCbJ756utNRX6RlRGBKxXUWgDtVC2CmIwHD7BGCnjH2M+uvxuToMm86 di8GKLOnviCzLvLfMpUPAaKEQSUALYkdqm64d2AA= Date: Wed, 6 May 2020 09:47:32 +0530 From: Vinod Koul To: Wesley Cheng Cc: Rob Herring , agross@kernel.org, bjorn.andersson@linaro.org, kishon@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, p.zabel@pengutronix.de, mgautam@codeaurora.org, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jackp@codeaurora.org Subject: Re: [PATCH v8 1/5] dt-bindings: phy: Add binding for qcom,usb-snps-femto-v2 Message-ID: <20200506041732.GY1375924@vkoul-mobl> References: <1588636467-23409-1-git-send-email-wcheng@codeaurora.org> <1588636467-23409-2-git-send-email-wcheng@codeaurora.org> <20200505133408.GA24731@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 05-05-20, 12:38, Wesley Cheng wrote: > > > On 5/5/2020 6:34 AM, Rob Herring wrote: > > On Mon, 4 May 2020 16:54:23 -0700, Wesley Cheng wrote: > >> This binding shows the descriptions and properties for the > >> Synopsis Femto USB PHY V2 used on QCOM platforms. > >> > >> Signed-off-by: Wesley Cheng > >> Reviewed-by: Rob Herring > >> Reviewed-by: Stephen Boyd > >> --- > >> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 77 ++++++++++++++++++++++ > >> 1 file changed, 77 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml > >> > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda-pll-supply' is a required property > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda18-supply' is a required property > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda33-supply' is a required property > > > > See https://patchwork.ozlabs.org/patch/1283143 > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure dt-schema is up to date: > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > Please check and re-submit. > > > > Hi Rob, > > I updated the dt-schema version, and I can see the same error. Will fix > and resubmit. I also realized that the dt_binding_check doesn't stop if No, pls submit the fix against already applied patches and also give credit to Rob by adding a "Reported-by: ..." > errors are detected in the example DT checking phase, and that was > probably why I missed this initially. I'll pass the DT_SCHEMA_FILES > argument to my specific binding next time to help verify my file. > Thanks again! > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project -- ~Vinod