From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FDBC28CBC for ; Wed, 6 May 2020 10:04:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D4E220714 for ; Wed, 6 May 2020 10:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V4ZHnLlP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D4E220714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGv7-00033D-JJ for qemu-devel@archiver.kernel.org; Wed, 06 May 2020 06:04:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGuJ-000286-35 for qemu-devel@nongnu.org; Wed, 06 May 2020 06:04:03 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:34805 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jWGuI-0001vI-1m for qemu-devel@nongnu.org; Wed, 06 May 2020 06:04:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588759440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TgmFOP6GtHoeS021a9fPGp/+Bylso0c6IzNTlujDOYM=; b=V4ZHnLlPIMFJQxv6YaSngbun4V3TUT3Zj0yRlwRUu8wBbIeSzVBLkk9RVR/z8uRIdCYiNI wO829ydUTyBqNbOvYt3ddaqLHmJ3wkwa4WFUcRrxzD80cbqqgAeUAKQZg6uicSMoVsJZIN d62J5L8c1F3z/9exOtjs7Y2sHYrOv6Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-nBaEBfIwOUqz8D1xZZSAfw-1; Wed, 06 May 2020 06:03:53 -0400 X-MC-Unique: nBaEBfIwOUqz8D1xZZSAfw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 83261835B40; Wed, 6 May 2020 10:03:52 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-193.ams2.redhat.com [10.36.113.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A20E70545; Wed, 6 May 2020 10:03:47 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 253441747D; Wed, 6 May 2020 12:03:46 +0200 (CEST) Date: Wed, 6 May 2020 12:03:46 +0200 From: Gerd Hoffmann To: Igor Mammedov Subject: Re: [PATCH v2 05/13] acpi: move acpi_init_common_fadt_data to acpi-common.c Message-ID: <20200506100346.l2d47yqzrfzeqow2@sirius.home.kraxel.org> References: <20200505134305.22666-1-kraxel@redhat.com> <20200505134305.22666-6-kraxel@redhat.com> <20200505162555.104fa99a@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200505162555.104fa99a@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 02:39:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 05, 2020 at 04:25:55PM +0200, Igor Mammedov wrote: > On Tue, 5 May 2020 15:42:57 +0200 > Gerd Hoffmann wrote: >=20 > the same question like with FACS, why legacy data are needed for with red= uced profile? > it mostly initializes data for fixed-hw model. >=20 > I'd preffer if you drop FACS and use minimal FADT like build_fadt_rev5() = does > without pulling along a bunch of legacy junk (unless there is a good just= ification for it). Leftover from the isa-acpi version, it is indeed not needed any more (same for facs). take care, Gerd