From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F42BC38A24 for ; Wed, 6 May 2020 10:36:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 486A920663 for ; Wed, 6 May 2020 10:36:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ms3861ee" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 486A920663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWHPr-0005Xg-DF for qemu-devel@archiver.kernel.org; Wed, 06 May 2020 06:36:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWHPF-00056X-Ea for qemu-devel@nongnu.org; Wed, 06 May 2020 06:36:01 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:31504 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jWHPD-0001wW-IZ for qemu-devel@nongnu.org; Wed, 06 May 2020 06:36:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588761358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mndt1CYAju93cKZGjsE3QO3/1IaGvGmW93/WpzIzLcQ=; b=Ms3861ee5reKyuyg2+yUjE95G6B9krFpm1UpCSk4ivSbQSYTq/kZOunPc+ZB1MRNsc3KSm DH9SNd63wOfjIF7gIQdqRZL3T9SahQ6LIfExUl3JReeergmL/fcC6vmWsNkXRoMfWBvZWs yLD78AspcbE9zOPd762e8PiInj0IwJM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-Xuecqe8uN7-sKxvGDfocgg-1; Wed, 06 May 2020 06:35:56 -0400 X-MC-Unique: Xuecqe8uN7-sKxvGDfocgg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C23A5460; Wed, 6 May 2020 10:35:55 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-193.ams2.redhat.com [10.36.113.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A8D25C1D4; Wed, 6 May 2020 10:35:50 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4809A1747D; Wed, 6 May 2020 12:35:49 +0200 (CEST) Date: Wed, 6 May 2020 12:35:49 +0200 From: Gerd Hoffmann To: Igor Mammedov Subject: Re: [PATCH v2 09/13] microvm: add minimal acpi support Message-ID: <20200506103549.yplkfmv3uqdbeumt@sirius.home.kraxel.org> References: <20200505134305.22666-1-kraxel@redhat.com> <20200505134305.22666-10-kraxel@redhat.com> <20200505172037.2bd55d6e@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200505172037.2bd55d6e@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 23:48:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > > +/* FIXME: copy & paste */ > > +static void acpi_dsdt_add_power_button(Aml *scope) > > +{ > > + Aml *dev =3D aml_device(ACPI_POWER_BUTTON_DEVICE); > > + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C"))); > > + aml_append(dev, aml_name_decl("_UID", aml_int(0))); > > + aml_append(scope, dev); > > +} >=20 > could be unified with ARM's version Yep. Suggestions for a good place? hw/acpi/aml-build.c ? > > + acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE); > > + acpi_align_size(tables->linker->cmd_blob, ACPI_BUILD_ALIGN_SIZE); > I'd drop these as that was mostly to counter various migration issues on = legacy Dropped. take care, Gerd