All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] input/keyboard/qt1050: fix unsigned comparison with 0
@ 2020-05-06 11:04 ChenTao
  0 siblings, 0 replies; only message in thread
From: ChenTao @ 2020-05-06 11:04 UTC (permalink / raw)
  To: dmitry.torokhov; +Cc: robh, m.felsch, linux-input, linux-kernel, chentao107

Fixes warning because num is u32 and can never be negtative

drivers/input/keyboard/qt1050.c:371:18: warning:
comparison of unsigned expression < 0 is always false [-Wtype-limits]
   if (button.num < 0 || button.num > QT1050_MAX_KEYS - 1)

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenTao <chentao107@huawei.com>
---
 drivers/input/keyboard/qt1050.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c
index 403060d05c3b..a9ac99f62e39 100644
--- a/drivers/input/keyboard/qt1050.c
+++ b/drivers/input/keyboard/qt1050.c
@@ -368,7 +368,7 @@ static int qt1050_parse_fw(struct qt1050_priv *ts)
 			dev_err(dev, "Button without pad number\n");
 			goto err;
 		}
-		if (button.num < 0 || button.num > QT1050_MAX_KEYS - 1)
+		if (button.num > QT1050_MAX_KEYS - 1)
 			goto err;
 
 		ts->reg_keys |= BIT(button.num);
-- 
2.22.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-06 11:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 11:04 [PATCH -next] input/keyboard/qt1050: fix unsigned comparison with 0 ChenTao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.