All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v4 03/13] acpi: rtc: use a single crs range
Date: Wed, 6 May 2020 14:38:39 +0200	[thread overview]
Message-ID: <20200506143839.2439cc3f@redhat.com> (raw)
In-Reply-To: <20200506083902.shumz2k3v5cbo6dl@sirius.home.kraxel.org>

On Wed, 6 May 2020 10:39:02 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

>   Hi,
> 
> > >      crs = aml_resource_template();
> > >      aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
> > > -                           0x10, 0x02));
> > > +                           0x10, 0x08));
> > >      aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ));
> > > -    aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2,
> > > -                           0x02, 0x06));  
> > can we just drop the later range as unused? (I don't see where it's actually initialized)  
> 
> I'd rather follow what physical hardware is doing here
> for better compatibility ...

maybe add comment here why it doesn't match IO range that RTC actualy provides,
otherwise it's looks very confusing

> 
> take care,
>   Gerd
> 



  reply	other threads:[~2020-05-06 12:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 11:38 [PATCH v4 00/13] acpi: i386 tweaks Gerd Hoffmann
2020-05-05 11:38 ` [PATCH v4 01/13] qtest: allow DSDT acpi table changes Gerd Hoffmann
2020-05-05 11:38 ` [PATCH v4 02/13] acpi: move aml builder code for rtc device Gerd Hoffmann
2020-05-05 13:21   ` Igor Mammedov
2020-05-05 13:28   ` Philippe Mathieu-Daudé
2020-05-05 11:38 ` [PATCH v4 03/13] acpi: rtc: use a single crs range Gerd Hoffmann
2020-05-05 13:24   ` Igor Mammedov
2020-05-06  8:39     ` Gerd Hoffmann
2020-05-06 12:38       ` Igor Mammedov [this message]
2020-05-05 11:38 ` [PATCH v4 04/13] acpi: serial: don't use _STA method Gerd Hoffmann
2020-05-05 11:38 ` [PATCH v4 05/13] acpi: move aml builder code for serial device Gerd Hoffmann
2020-05-05 13:46   ` Philippe Mathieu-Daudé
2020-05-05 11:38 ` [PATCH v4 06/13] acpi: parallel: don't use _STA method Gerd Hoffmann
2020-05-05 11:38 ` [PATCH v4 07/13] acpi: move aml builder code for parallel device Gerd Hoffmann
2020-05-05 13:35   ` Philippe Mathieu-Daudé
2020-05-06  8:46     ` Gerd Hoffmann
2020-05-05 11:38 ` [PATCH v4 08/13] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-05-05 11:38 ` [PATCH v4 09/13] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-05-05 11:38 ` [PATCH v4 10/13] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-05-05 11:38 ` [PATCH v4 11/13] acpi: simplify build_isa_devices_aml() Gerd Hoffmann
2020-05-05 13:26   ` Igor Mammedov
2020-05-05 13:29   ` Philippe Mathieu-Daudé
2020-05-05 11:38 ` [PATCH v4 12/13] acpi: drop serial/parallel enable bits from dsdt Gerd Hoffmann
2020-05-05 13:38   ` Igor Mammedov
2020-05-05 11:38 ` [PATCH v4 13/13] floppy: make isa_fdc_get_drive_max_chs static Gerd Hoffmann
2020-05-05 13:39   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200506143839.2439cc3f@redhat.com \
    --to=imammedo@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.