From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D8AC38A24 for ; Wed, 6 May 2020 12:42:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E03C20752 for ; Wed, 6 May 2020 12:42:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i+L6ils2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E03C20752 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWJNx-0004vt-KZ for qemu-devel@archiver.kernel.org; Wed, 06 May 2020 08:42:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWJNE-00040d-E6 for qemu-devel@nongnu.org; Wed, 06 May 2020 08:42:04 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:32665 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jWJND-0007vR-KE for qemu-devel@nongnu.org; Wed, 06 May 2020 08:42:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588768923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b+aumLI5ASUJTiZpYbaRAhuuAnmXcwT0juGSF4WTVN4=; b=i+L6ils2II1GS2Up0uvMg2FZUsdcG8YtmcBAgOT2h9eJL+lOwDwD42ppuJyq9qz5/erKeh dkI7lTninuBsa0xr76eNpQGK530R63U+UQWQbrSy0lNzip2bN2uHUN+puCqSHurIOQksRb xv5AwH/GV1DigaqmrVV7bQqzE159KAc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-Wvzj4IJXNwCodWvnWmj-sw-1; Wed, 06 May 2020 08:42:01 -0400 X-MC-Unique: Wvzj4IJXNwCodWvnWmj-sw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A1271005510; Wed, 6 May 2020 12:42:00 +0000 (UTC) Received: from localhost (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0F611001B07; Wed, 6 May 2020 12:41:46 +0000 (UTC) Date: Wed, 6 May 2020 14:41:43 +0200 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v2 08/13] acpi: generic event device for x86 Message-ID: <20200506144143.1f68c383@redhat.com> In-Reply-To: <20200506103106.nih5mf5zpltv3fns@sirius.home.kraxel.org> References: <20200505134305.22666-1-kraxel@redhat.com> <20200505134305.22666-9-kraxel@redhat.com> <20200505170316.7e72da4d@redhat.com> <20200506103106.nih5mf5zpltv3fns@sirius.home.kraxel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=imammedo@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 04:02:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 6 May 2020 12:31:06 +0200 Gerd Hoffmann wrote: > On Tue, May 05, 2020 at 05:03:16PM +0200, Igor Mammedov wrote: > > On Tue, 5 May 2020 15:43:00 +0200 > > Gerd Hoffmann wrote: > > > > > Uses TYPE_ACPI_GED as QOM parent for code reuse. > > > Add registers for sleep states and reset. > > > Add powerdown notifier for power button events. > > registers aren't x86 specific per spec, > > can we put these registers into TYPE_ACPI_GED > > and enable the optionally like is done with memory hotplug registers > > in acpi_ged_initfn() > > Sure, will do. > > > > Set AcpiDeviceIfClass->madt_cpu. > > that's the only reason I could justify adding x86 specific flavour. > > Also the powerdown notifier. Seems the workflow is slightly different > on x86 (acpi device registers notifier) and arm (machine registers > notifier and calls acpidev->send_event). Is it possible to use ARM's approach, without notifier? > > take care, > Gerd >