From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4279CC38A24 for ; Thu, 7 May 2020 18:16:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DC0A2145D for ; Thu, 7 May 2020 18:16:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728181AbgEGSQT (ORCPT ); Thu, 7 May 2020 14:16:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:53606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbgEGSQT (ORCPT ); Thu, 7 May 2020 14:16:19 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BEFE20735; Thu, 7 May 2020 18:16:18 +0000 (UTC) Date: Thu, 7 May 2020 14:16:16 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Yunfeng Ye , , , Subject: Re: [PATCH] tools/bootconfig: fix resource leak in apply_xbc() Message-ID: <20200507141616.5fb38310@gandalf.local.home> In-Reply-To: <20200508005805.9ae13059958e36ce9ebdd5aa@kernel.org> References: <583a49c9-c27a-931d-e6c2-6f63a4b18bea@huawei.com> <20200508005647.dc6f79c0aeca041203af1d8d@kernel.org> <20200508005805.9ae13059958e36ce9ebdd5aa@kernel.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 May 2020 00:58:05 +0900 Masami Hiramatsu wrote: > On Fri, 8 May 2020 00:56:47 +0900 > Masami Hiramatsu wrote: > > > On Thu, 7 May 2020 17:23:36 +0800 > > Yunfeng Ye wrote: > > > > > The @data and @fd is leak in the error path of apply_xbc(), so this > > > patch fix it. > > > > Good catch! Thanks for fixing! > > > > Acked-by: Masami Hiramatsu > > > > Hi Steve, can you pick this up? Yeah. I can add it to my 'for-linus' queue. As it's just part of the tools directory, I can skip the full testing I run on my patches. -- Steve