From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3670CC38A2A for ; Thu, 7 May 2020 14:36:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01FB1208D6 for ; Thu, 7 May 2020 14:36:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZzB4d4PH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728911AbgEGOgY (ORCPT ); Thu, 7 May 2020 10:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728074AbgEGOgV (ORCPT ); Thu, 7 May 2020 10:36:21 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E26CC05BD43 for ; Thu, 7 May 2020 07:36:21 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id u127so7082430wmg.1 for ; Thu, 07 May 2020 07:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=97qbtlSksxUqP4IepQZvJvrELnOIuCcLtceZei2X0fU=; b=ZzB4d4PH21eRkcpcL8/dT+++RvB0ZZmSphkIMJLtD5oMY2Jnwy7S98JFpZfw1OYm52 3TWG2h2gorD9PKb0JKdyLP7kgH0CYBI6AQD+bD51IoyPOPJmai2OhLaOaM2Tn8KR/r+T 0HjMn9km6DG+HcLGaNGTTtsaAmKgEi66yeYEVYKrej1QmHPcsTZfgNVFFeqPB5IR4/oJ G297cddKz4Z7Lxx7yvZy8V268l+77Bsr7s7lMPa0lTjhhO62NCnger0sZ9xW99EGDqJN GyLqbTJdof20XyI1vBiW1i2flDKKGUJpK3R7pfKCu/PK8sMvX8aEdJ/CQGv2O2uojqIf fROw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=97qbtlSksxUqP4IepQZvJvrELnOIuCcLtceZei2X0fU=; b=qdYbRwqapsTMBLMkd7eB5YqMNBMXT38IjC2eUaEmVm8UMzP+e7JD8g34KepwZ3BNq8 OiWKliqJ0A2hxELTqlcrrqKK2hj45hjb1PLeCNrdS1GuMuNMZsXg/zc9Tgq18yb/OfDf 2I0MSNhab8SYV7di7HhNTuvMyEh1Q2xjoBKYP51hvw/l0UxKFHpjU7Ie5aMeAe2s3zBM 5V7rEkH63tAJwcLxDG2Ap8dWUxXGFwtlKJCt8Wzj7ajP8NUQNsBHsU8daJNyoQVCzAe4 FYHr1ToAna++/ri82EESq7rZ7vbQp0NP/tPZFWIWtp0uSFtEB4lJYdKQ15IdG5bm/ZcW KQnA== X-Gm-Message-State: AGi0Pua5ima61+tG6J4JVA57DPgE9IrSC+ISM53BZ+K5SmRXZn57KS8m ztbA05DUGORDVHbgiZ4q0WiOTA== X-Google-Smtp-Source: APiQypKByb7yOAaqMEZY3XrineEZDS7bGjGUh3lbDYheXhS+bRdzViSRoAmOnUwDPOJrmi6GqqsTGw== X-Received: by 2002:a1c:7d4b:: with SMTP id y72mr10888700wmc.11.1588862179402; Thu, 07 May 2020 07:36:19 -0700 (PDT) Received: from dbrazdil-macbookpro.roam.corp.google.com ([2a01:4b00:8523:2d03:1887:a290:f251:d169]) by smtp.gmail.com with ESMTPSA id c190sm8793473wme.4.2020.05.07.07.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 07:36:18 -0700 (PDT) From: David Brazdil X-Google-Original-From: David Brazdil Date: Thu, 7 May 2020 15:36:17 +0100 To: Marc Zyngier Cc: David Brazdil , Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/15] arm64: kvm: Fix symbol dependency in __hyp_call_panic_nvhe Message-ID: <20200507143617.2j5x3mfxi3ber7ig@dbrazdil-macbookpro.roam.corp.google.com> References: <20200430144831.59194-1-dbrazdil@google.com> <20200430144831.59194-4-dbrazdil@google.com> <87blmzj2w5.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87blmzj2w5.wl-maz@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, > > What breaks without this constraint? Is it a fix that should go in > early? Otherwise looks good. This only becomes an issue when __hyp_call_panic_nvhe() and __hyp_call_panic_vhe() are moved to separate files, so I don't think it's necessary to go in early. Currently the string variable (declared static) is seen by the C compiler as used by __hyp_call_panic_vhe(). But when split, the variable in the nVHE source file becomes unused, is dropped by the compiler and the inline assembly's reference is unresolved. We could then alias __hyp_text___hyp_panic_string back to the VHE copy, but this is the right way of addressing it. Thanks for the review, David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28242C47247 for ; Thu, 7 May 2020 14:36:32 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id A65A52083B for ; Thu, 7 May 2020 14:36:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="ZzB4d4PH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A65A52083B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 107F14B3A1; Thu, 7 May 2020 10:36:31 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fA5fYpbQxWnL; Thu, 7 May 2020 10:36:27 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2744C4B325; Thu, 7 May 2020 10:36:27 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E209C4B316 for ; Thu, 7 May 2020 10:36:25 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lUfIqinFntIi for ; Thu, 7 May 2020 10:36:20 -0400 (EDT) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id CE5E44B2C3 for ; Thu, 7 May 2020 10:36:20 -0400 (EDT) Received: by mail-wm1-f68.google.com with SMTP id y24so7112108wma.4 for ; Thu, 07 May 2020 07:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=97qbtlSksxUqP4IepQZvJvrELnOIuCcLtceZei2X0fU=; b=ZzB4d4PH21eRkcpcL8/dT+++RvB0ZZmSphkIMJLtD5oMY2Jnwy7S98JFpZfw1OYm52 3TWG2h2gorD9PKb0JKdyLP7kgH0CYBI6AQD+bD51IoyPOPJmai2OhLaOaM2Tn8KR/r+T 0HjMn9km6DG+HcLGaNGTTtsaAmKgEi66yeYEVYKrej1QmHPcsTZfgNVFFeqPB5IR4/oJ G297cddKz4Z7Lxx7yvZy8V268l+77Bsr7s7lMPa0lTjhhO62NCnger0sZ9xW99EGDqJN GyLqbTJdof20XyI1vBiW1i2flDKKGUJpK3R7pfKCu/PK8sMvX8aEdJ/CQGv2O2uojqIf fROw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=97qbtlSksxUqP4IepQZvJvrELnOIuCcLtceZei2X0fU=; b=HZ6NlehrUlsPx6rB7gB3H9gmXkX33cHuSioetsfcPWngdpU7dNE9DdetQLdUXa9q5X R1ss/rSo8wAO/dswW/ra7/atOTdvCkiD9GdNsCevzcfw5Vl2wRtBkkgPtjnisbHItSBW kyS+6j+pNee8lzbMgBKlCChs3cdiESjLhu4c5sUR3hY5W8tUg8mgUtkQ3ATriD+nNLRr uDld7NWGTT6+mutN9iwD6aglJJgfyWYVXa6OiimYdTJ4ZqdPTOjG/q7n5OSkycaI1c6r Qm2Up/asU53iipGF0swk0AloXEPhSsxac/1WV+idJNl0B9FcdDJK0CFfr8n7oj756wih wuRQ== X-Gm-Message-State: AGi0PuZs/NqhCuE8nUHJfkH1fDzWf21dTUder8UYGWFBtoQiv6qP6P9T RNJzYxEGYDWNuWO/coZyrCQL0A== X-Google-Smtp-Source: APiQypKByb7yOAaqMEZY3XrineEZDS7bGjGUh3lbDYheXhS+bRdzViSRoAmOnUwDPOJrmi6GqqsTGw== X-Received: by 2002:a1c:7d4b:: with SMTP id y72mr10888700wmc.11.1588862179402; Thu, 07 May 2020 07:36:19 -0700 (PDT) Received: from dbrazdil-macbookpro.roam.corp.google.com ([2a01:4b00:8523:2d03:1887:a290:f251:d169]) by smtp.gmail.com with ESMTPSA id c190sm8793473wme.4.2020.05.07.07.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 07:36:18 -0700 (PDT) From: David Brazdil X-Google-Original-From: David Brazdil Date: Thu, 7 May 2020 15:36:17 +0100 To: Marc Zyngier Subject: Re: [PATCH 03/15] arm64: kvm: Fix symbol dependency in __hyp_call_panic_nvhe Message-ID: <20200507143617.2j5x3mfxi3ber7ig@dbrazdil-macbookpro.roam.corp.google.com> References: <20200430144831.59194-1-dbrazdil@google.com> <20200430144831.59194-4-dbrazdil@google.com> <87blmzj2w5.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87blmzj2w5.wl-maz@kernel.org> Cc: Catalin Marinas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Marc, > > What breaks without this constraint? Is it a fix that should go in > early? Otherwise looks good. This only becomes an issue when __hyp_call_panic_nvhe() and __hyp_call_panic_vhe() are moved to separate files, so I don't think it's necessary to go in early. Currently the string variable (declared static) is seen by the C compiler as used by __hyp_call_panic_vhe(). But when split, the variable in the nVHE source file becomes unused, is dropped by the compiler and the inline assembly's reference is unresolved. We could then alias __hyp_text___hyp_panic_string back to the VHE copy, but this is the right way of addressing it. Thanks for the review, David _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50C1C38A2A for ; Thu, 7 May 2020 14:36:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9697D2073A for ; Thu, 7 May 2020 14:36:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X10hEthu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="ZzB4d4PH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9697D2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NarTsz8NqZHc0LpHBjJysJHCMA00IcihZCmZT6swMxI=; b=X10hEthucz55g+ 9K4iQ4H+IsyLz9vJ8JSapLHdK5Pbuy7GSHg/umfSIH4WgS8gdI+nQeUkNCn6uteOl/KlGACXoJQ+1 IYf5OTaUQ+5SQ5rPr3KDZquWNTSuLaAwcCs8VMKyYCMLyB4qL426aUT5MFgGW3fmDIxRqiiSViwVP Bgj3M6/Rzztb6ScO0h3tVYpNn7f3Y0/JBHgcIrPLmFVuDHKAJHO2T7dpCHpjVPqd6OxJaJg15JY01 0jouZ7T7FDPBar7yrWBLdvITnbpa09diNdXhE7yayCjliuylu25kbOLdTTluTAgTyQmFpK6hTGkwe X6kJhpCdPRQtji6DZr6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWhdU-0002F3-48; Thu, 07 May 2020 14:36:28 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWhdP-0002DU-VO for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 14:36:26 +0000 Received: by mail-wm1-x344.google.com with SMTP id h4so6812614wmb.4 for ; Thu, 07 May 2020 07:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=97qbtlSksxUqP4IepQZvJvrELnOIuCcLtceZei2X0fU=; b=ZzB4d4PH21eRkcpcL8/dT+++RvB0ZZmSphkIMJLtD5oMY2Jnwy7S98JFpZfw1OYm52 3TWG2h2gorD9PKb0JKdyLP7kgH0CYBI6AQD+bD51IoyPOPJmai2OhLaOaM2Tn8KR/r+T 0HjMn9km6DG+HcLGaNGTTtsaAmKgEi66yeYEVYKrej1QmHPcsTZfgNVFFeqPB5IR4/oJ G297cddKz4Z7Lxx7yvZy8V268l+77Bsr7s7lMPa0lTjhhO62NCnger0sZ9xW99EGDqJN GyLqbTJdof20XyI1vBiW1i2flDKKGUJpK3R7pfKCu/PK8sMvX8aEdJ/CQGv2O2uojqIf fROw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=97qbtlSksxUqP4IepQZvJvrELnOIuCcLtceZei2X0fU=; b=oVglBXljtFfEJjbITEwvBkDeCUzQ4+f5gpU9wZsDftNg/KjMsUD1PSucVGZ5TN1+qA tzyNHJ6UDtnGzxDtyX74EwZfkKycD6PVHSecWrTtzUrT7cWa/eMcZeJWEzMesyV8uQIo Y14l5qwU08YR1+5J/OPvDx//cRuF4i2f61dSb4OEJSQvw6uLVgq00I4SmEPF10JwDbWf PAATzVgtlYWCwLgUUdOzJ9thOR68ezTfKjuLgowPt3bmsjAMszRSdGa9YQfBeoar32GG n3PkxZFqQ7Y8GrNZRKKst2mXey9ONTj580Pta2An5qZ1lnIts+umbiYtXFqqNfP74ETG jvfg== X-Gm-Message-State: AGi0PuZrM2JlzWNAlQFiGp4WTkLzD/wpMDsqZauAIs0iNupWRGpaDGe4 VwgPiGcNsH813inBqNHHv3U5aA== X-Google-Smtp-Source: APiQypKByb7yOAaqMEZY3XrineEZDS7bGjGUh3lbDYheXhS+bRdzViSRoAmOnUwDPOJrmi6GqqsTGw== X-Received: by 2002:a1c:7d4b:: with SMTP id y72mr10888700wmc.11.1588862179402; Thu, 07 May 2020 07:36:19 -0700 (PDT) Received: from dbrazdil-macbookpro.roam.corp.google.com ([2a01:4b00:8523:2d03:1887:a290:f251:d169]) by smtp.gmail.com with ESMTPSA id c190sm8793473wme.4.2020.05.07.07.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 07:36:18 -0700 (PDT) From: David Brazdil X-Google-Original-From: David Brazdil Date: Thu, 7 May 2020 15:36:17 +0100 To: Marc Zyngier Subject: Re: [PATCH 03/15] arm64: kvm: Fix symbol dependency in __hyp_call_panic_nvhe Message-ID: <20200507143617.2j5x3mfxi3ber7ig@dbrazdil-macbookpro.roam.corp.google.com> References: <20200430144831.59194-1-dbrazdil@google.com> <20200430144831.59194-4-dbrazdil@google.com> <87blmzj2w5.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87blmzj2w5.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_073624_036284_C782D563 X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, David Brazdil , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, > > What breaks without this constraint? Is it a fix that should go in > early? Otherwise looks good. This only becomes an issue when __hyp_call_panic_nvhe() and __hyp_call_panic_vhe() are moved to separate files, so I don't think it's necessary to go in early. Currently the string variable (declared static) is seen by the C compiler as used by __hyp_call_panic_vhe(). But when split, the variable in the nVHE source file becomes unused, is dropped by the compiler and the inline assembly's reference is unresolved. We could then alias __hyp_text___hyp_panic_string back to the VHE copy, but this is the right way of addressing it. Thanks for the review, David _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel