From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA16C38A2A for ; Thu, 7 May 2020 14:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E65F205C9 for ; Thu, 7 May 2020 14:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588860374; bh=mO6hqdjkkEolTS2CEQMY7rXxD9a75gLngCfq93qWT2g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=L2qoab14iOdI7Jl7N1NgO3gAiByjjeSXu7BATIWTF00iIclqbiidQ1bRf58nkl41U g1UbRpeSyqe236KrIGA3gsYoE/gvP0VybIDobmmsl1Zt9jvW5jLiKyd2L8f/XuGMyD loWrR2bYnk8c8nTirIBO2EcUAapAX1m+fRszLlUw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726742AbgEGOGN (ORCPT ); Thu, 7 May 2020 10:06:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726644AbgEGOGN (ORCPT ); Thu, 7 May 2020 10:06:13 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FF1BC05BD43 for ; Thu, 7 May 2020 07:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=VdMq/Jc7qCK1txecCcqfPFUFad+GzEPdwS+Cdig9ARE=; b=GafhsXpWf7nec1WgDx5zoTea0V XcoaJ0nwre6dEwF02YkufHpl1aIMEdmHc4stcKlvshEHs93tdtsXznmrnGrPIm5Has30xjzQFTIbd 0RK3yPNrLbDiIdYAdlsSzD0NT8+d8gM8Wyyv8sSI2tu3EdbC/9/9hdhJAZ5XcTmxOY5EyXntgpQqn 3+JoLyhL6BsMfXcGUnLRMUvbYIasz/QYkOKGaxy2dRBwTiDU+NZZLUE0PQoh1yE+f1iLUdi1SP5Lh 595FMxf9/3nKspvS/xi6sz/gIbidFWOl8eD0BnMQu9Sfe1sJ+K5HKDsOSt/IyGLgIEExG/QJbTje2 ilBP7/MA==; Received: from ip5f5ad5c5.dynamic.kabel-deutschland.de ([95.90.213.197] helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWh9z-0002UW-Nd; Thu, 07 May 2020 14:06:00 +0000 Date: Thu, 7 May 2020 16:05:54 +0200 From: Mauro Carvalho Chehab To: Jacopo Mondi Cc: Hans Verkuil , Sakari Ailus , Laurent Pinchart , tfiga@google.com, pavel@ucw.cz, linux-media@vger.kernel.org, libcamera-devel@lists.libcamera.org Subject: Re: [PATCH v9 02/11] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_LOCATION Message-ID: <20200507160530.21cf5922@coco.lan> In-Reply-To: <20200507123649.q3ecciyxulzisn62@uno.localdomain> References: <20200417124110.72313-1-jacopo@jmondi.org> <20200417124110.72313-3-jacopo@jmondi.org> <20200505140206.589f54ae@coco.lan> <20200505165826.1ce8bb0d@coco.lan> <20200506113909.1489bd1e@coco.lan> <20200506110730.rvhxoh74u3rmemtw@uno.localdomain> <20200506132847.03860fce@coco.lan> <20200507123649.q3ecciyxulzisn62@uno.localdomain> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Thu, 7 May 2020 14:36:49 +0200 Jacopo Mondi escreveu: > Hi Mauro, > > On Wed, May 06, 2020 at 01:28:47PM +0200, Mauro Carvalho Chehab wrote: > > Em Wed, 6 May 2020 13:07:30 +0200 > > Jacopo Mondi escreveu: > > > > > > So, if that would be ok for you, I can live with a > > > > > > > > V4L2_CID_CAMERA_VIEWING_ANGLE (or some similar name) that will > > > > specify the angle where the sensor is mounted (for fixed sensors), > > > > or the current angle, in case of movable ones, being RO for fixed > > > > sensors and RW for movable ones. > > > > > > > > Let's postpone discussions for a LOCATION control once this > > > > would be needed by some driver. > > > > > > Would V4L2_CID_CAMERA_ORIENTATION work ? > > > > Yeah, either V4L2_CID_CAMERA_ORIENTATION or CID_LENS_FACING would > > equally work (although I would prefer the one with a shorter name). > > > > Yeah, CID_LENS_FACING is nice and shorter, but I would refrain from > polluting the LENS_ namespace, this control applies to the whole camera > module, so I would keep it in the CAMERA_ namespace... And > 'orientation' gives a nice match with the DT property, which I would > not call 'facing' or 'facing_side' as 'orientation' seems more > appropriate as a dt-property name to me.. Ok. V4L2_CID_CAMERA_ORIENTATION works for me. Thanks, Mauro