From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD7A3C38A24 for ; Thu, 7 May 2020 15:53:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DD7A20659 for ; Thu, 7 May 2020 15:53:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726661AbgEGPxI (ORCPT ); Thu, 7 May 2020 11:53:08 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:46389 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbgEGPxH (ORCPT ); Thu, 7 May 2020 11:53:07 -0400 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 48DF8240007; Thu, 7 May 2020 15:53:03 +0000 (UTC) Date: Thu, 7 May 2020 17:53:01 +0200 From: Miquel Raynal To: Boris Brezillon Cc: Vignesh Raghavendra , Mark Rutland , Rob Herring , , Richard Weinberger , Tudor Ambarus , , Thomas Petazzoni , Michal Simek , Naga Sureshkumar Relli Subject: Re: [PATCH v3 7/8] mtd: rawnand: arasan: Add new Arasan NAND controller Message-ID: <20200507175301.7affb8f7@xps13> In-Reply-To: <20200507172453.15a03574@collabora.com> References: <20200507110034.14736-1-miquel.raynal@bootlin.com> <20200507110034.14736-8-miquel.raynal@bootlin.com> <20200507141103.0c241877@collabora.com> <20200507171311.7669d0db@xps13> <20200507172453.15a03574@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Boris, Boris Brezillon wrote on Thu, 7 May 2020 17:24:53 +0200: > On Thu, 7 May 2020 17:13:11 +0200 > Miquel Raynal wrote: > > > Hi Boris, > > > > Boris Brezillon wrote on Thu, 7 May > > 2020 14:11:03 +0200: > > > > > On Thu, 7 May 2020 13:00:33 +0200 > > > Miquel Raynal wrote: > > > > > > > > > > + > > > > +static void anfc_chips_cleanup(struct arasan_nfc *nfc) > > > > +{ > > > > + struct anand *anand, *tmp; > > > > + > > > > + list_for_each_entry_safe(anand, tmp, &nfc->chips, node) { > > > > + nand_release(&anand->chip); > > > > > > ret = mtd_device_unregister(nand_to_mtd(&anand->chip)); > > > WARN_ON(ret); > > > nand_cleanup(&anand->chip); > > > > > > Or maybe add this WARN_ON() to nand_release() so we don't have to ask > > > people to use mtd_device_unregister() + nand_cleanup(). > > > > I don't get your point here? I'm not against adding a warn_on between > > both functions but it's not related to this driver? > > We've asked people to not call nand_release() but instead call > mtd_device_unregister()+nand_cleanup(), which is not done here. My > point is, if even us can't get it right, maybe it's a sign we should > instead patch nand_release() to do the right thing. It's in my todo-list, yes. What about just dropping nand_release entirely? So that nand_scan_tail as its nand cleanup and mtd_device_register as its mtd_device_unregister and everything will be much clearer? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74F09C38A24 for ; Thu, 7 May 2020 15:53:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 369AE20659 for ; Thu, 7 May 2020 15:53:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y37yt3v5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 369AE20659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5cVw2TEanieDbo0BkRS6c6yTjFUtFuzQU8ZJg1o4Htg=; b=Y37yt3v5SYw8ki RCLgwWVtXgqVsy/HFbxB0J2GSlxz5nFXpRtl7BggyBeAOPp6SbvSL9QnokhWAcqGUn51/YtAblCs+ uba1frcCUGjw6KWyLW8elWcHHYYvbXGjp04K5jmlp6/rqJAxdO+gYvsHwxKqh5jspHXr7lqZxJtRh XOUOwwKpnu/KDpe69fAimhd+DyGh4lhbyYbkUJpe7B34SsiM8SZ+1X1MlCQ5bphxiu8a1qlNlONIK Ff9ksLj64RlX6u6+XqSHreB6QKcXw3yhF+2kqr0C+NUr+NrK6T607T0fOJlIXdjJsGtTm2LKSlwLp g1j/0p7cIrEQ/MdmzRxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWipk-0007CE-9M; Thu, 07 May 2020 15:53:12 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWiph-0007BO-JB for linux-mtd@lists.infradead.org; Thu, 07 May 2020 15:53:11 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 48DF8240007; Thu, 7 May 2020 15:53:03 +0000 (UTC) Date: Thu, 7 May 2020 17:53:01 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v3 7/8] mtd: rawnand: arasan: Add new Arasan NAND controller Message-ID: <20200507175301.7affb8f7@xps13> In-Reply-To: <20200507172453.15a03574@collabora.com> References: <20200507110034.14736-1-miquel.raynal@bootlin.com> <20200507110034.14736-8-miquel.raynal@bootlin.com> <20200507141103.0c241877@collabora.com> <20200507171311.7669d0db@xps13> <20200507172453.15a03574@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_085309_770429_21FE02C2 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Naga Sureshkumar Relli Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Boris, Boris Brezillon wrote on Thu, 7 May 2020 17:24:53 +0200: > On Thu, 7 May 2020 17:13:11 +0200 > Miquel Raynal wrote: > > > Hi Boris, > > > > Boris Brezillon wrote on Thu, 7 May > > 2020 14:11:03 +0200: > > > > > On Thu, 7 May 2020 13:00:33 +0200 > > > Miquel Raynal wrote: > > > > > > > > > > + > > > > +static void anfc_chips_cleanup(struct arasan_nfc *nfc) > > > > +{ > > > > + struct anand *anand, *tmp; > > > > + > > > > + list_for_each_entry_safe(anand, tmp, &nfc->chips, node) { > > > > + nand_release(&anand->chip); > > > > > > ret = mtd_device_unregister(nand_to_mtd(&anand->chip)); > > > WARN_ON(ret); > > > nand_cleanup(&anand->chip); > > > > > > Or maybe add this WARN_ON() to nand_release() so we don't have to ask > > > people to use mtd_device_unregister() + nand_cleanup(). > > > > I don't get your point here? I'm not against adding a warn_on between > > both functions but it's not related to this driver? > > We've asked people to not call nand_release() but instead call > mtd_device_unregister()+nand_cleanup(), which is not done here. My > point is, if even us can't get it right, maybe it's a sign we should > instead patch nand_release() to do the right thing. It's in my todo-list, yes. What about just dropping nand_release entirely? So that nand_scan_tail as its nand cleanup and mtd_device_register as its mtd_device_unregister and everything will be much clearer? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/