From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C54C35280 for ; Thu, 7 May 2020 22:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F383A2083B for ; Thu, 7 May 2020 22:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbgEGWvK (ORCPT ); Thu, 7 May 2020 18:51:10 -0400 Received: from mga05.intel.com ([192.55.52.43]:21779 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbgEGWvK (ORCPT ); Thu, 7 May 2020 18:51:10 -0400 IronPort-SDR: vw/e2MqeB/h5k3zreXy2lpvnku/QsEh2njn2MQpCmDJBA5zNEydqk6K0asPBDqDeSZ2Mza0yZP ZldPXEooPtmg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 15:51:10 -0700 IronPort-SDR: KkjD1YAKdFT3e8D2XZABzY3aQLKnEXKOn0h0SQMKXa5uihRm4jFYYxRo95q/YttHS9mZ9NUdq7 NTH13HRvGuSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,365,1583222400"; d="scan'208";a="251643272" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga008.fm.intel.com with ESMTP; 07 May 2020 15:51:09 -0700 Date: Thu, 7 May 2020 15:51:09 -0700 From: Ira Weiny To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , Dan Williams , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dri-devel@lists.freedesktop.org, Christian Koenig , Al Viro , Christoph Hellwig Subject: Re: [PATCH V3 15/15] kmap: Consolidate kmap_prot definitions Message-ID: <20200507225109.GB1428632@iweiny-DESK2.sc.intel.com> References: <20200507150004.1423069-1-ira.weiny@intel.com> <20200507150004.1423069-16-ira.weiny@intel.com> <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Thu, May 07, 2020 at 01:53:07PM -0700, Andrew Morton wrote: > On Thu, 7 May 2020 08:00:03 -0700 ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > Most architectures define kmap_prot to be PAGE_KERNEL. > > > > Let sparc and xtensa define there own and define PAGE_KERNEL as the > > default if not overridden. > > > > checkpatch considered useful ;) Yes sorry... V3.1 on it's way... Ira > > > From: Andrew Morton > Subject: kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > > WARNING: macros should not use a trailing semicolon > #134: FILE: arch/sparc/include/asm/highmem.h:33: > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > > total: 0 errors, 1 warnings, 100 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > ./patches/kmap-consolidate-kmap_prot-definitions.patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Please run checkpatch prior to sending patches > > Cc: Ira Weiny > Signed-off-by: Andrew Morton > --- > > arch/sparc/include/asm/highmem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/sparc/include/asm/highmem.h~kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > +++ a/arch/sparc/include/asm/highmem.h > @@ -30,7 +30,7 @@ > /* declarations for highmem.c */ > extern unsigned long highstart_pfn, highend_pfn; > > -#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE) > extern pte_t *pkmap_page_table; > > void kmap_init(void) __init; > _ > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ira Weiny Date: Thu, 07 May 2020 22:51:09 +0000 Subject: Re: [PATCH V3 15/15] kmap: Consolidate kmap_prot definitions Message-Id: <20200507225109.GB1428632@iweiny-DESK2.sc.intel.com> List-Id: References: <20200507150004.1423069-1-ira.weiny@intel.com> <20200507150004.1423069-16-ira.weiny@intel.com> <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> In-Reply-To: <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Thu, May 07, 2020 at 01:53:07PM -0700, Andrew Morton wrote: > On Thu, 7 May 2020 08:00:03 -0700 ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > Most architectures define kmap_prot to be PAGE_KERNEL. > > > > Let sparc and xtensa define there own and define PAGE_KERNEL as the > > default if not overridden. > > > > checkpatch considered useful ;) Yes sorry... V3.1 on it's way... Ira > > > From: Andrew Morton > Subject: kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > > WARNING: macros should not use a trailing semicolon > #134: FILE: arch/sparc/include/asm/highmem.h:33: > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > > total: 0 errors, 1 warnings, 100 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > ./patches/kmap-consolidate-kmap_prot-definitions.patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Please run checkpatch prior to sending patches > > Cc: Ira Weiny > Signed-off-by: Andrew Morton > --- > > arch/sparc/include/asm/highmem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/sparc/include/asm/highmem.h~kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > +++ a/arch/sparc/include/asm/highmem.h > @@ -30,7 +30,7 @@ > /* declarations for highmem.c */ > extern unsigned long highstart_pfn, highend_pfn; > > -#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE) > extern pte_t *pkmap_page_table; > > void kmap_init(void) __init; > _ > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F77DC35280 for ; Thu, 7 May 2020 22:54:37 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 483D32083B for ; Thu, 7 May 2020 22:54:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 483D32083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49J80p72vxzDqn1 for ; Fri, 8 May 2020 08:54:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ira.weiny@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49J7wy0dZczDqkZ for ; Fri, 8 May 2020 08:51:13 +1000 (AEST) IronPort-SDR: hfUF8TAS60IK8AyWbVAenGco7wW00QXUGje6n1tPaArgUURJlFAaYDCxhLn5qugPjzrPgJ6Fqk eucPy7kcl1RA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 15:51:10 -0700 IronPort-SDR: KkjD1YAKdFT3e8D2XZABzY3aQLKnEXKOn0h0SQMKXa5uihRm4jFYYxRo95q/YttHS9mZ9NUdq7 NTH13HRvGuSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,365,1583222400"; d="scan'208";a="251643272" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga008.fm.intel.com with ESMTP; 07 May 2020 15:51:09 -0700 Date: Thu, 7 May 2020 15:51:09 -0700 From: Ira Weiny To: Andrew Morton Subject: Re: [PATCH V3 15/15] kmap: Consolidate kmap_prot definitions Message-ID: <20200507225109.GB1428632@iweiny-DESK2.sc.intel.com> References: <20200507150004.1423069-1-ira.weiny@intel.com> <20200507150004.1423069-16-ira.weiny@intel.com> <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> User-Agent: Mutt/1.11.1 (2018-12-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, May 07, 2020 at 01:53:07PM -0700, Andrew Morton wrote: > On Thu, 7 May 2020 08:00:03 -0700 ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > Most architectures define kmap_prot to be PAGE_KERNEL. > > > > Let sparc and xtensa define there own and define PAGE_KERNEL as the > > default if not overridden. > > > > checkpatch considered useful ;) Yes sorry... V3.1 on it's way... Ira > > > From: Andrew Morton > Subject: kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > > WARNING: macros should not use a trailing semicolon > #134: FILE: arch/sparc/include/asm/highmem.h:33: > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > > total: 0 errors, 1 warnings, 100 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > ./patches/kmap-consolidate-kmap_prot-definitions.patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Please run checkpatch prior to sending patches > > Cc: Ira Weiny > Signed-off-by: Andrew Morton > --- > > arch/sparc/include/asm/highmem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/sparc/include/asm/highmem.h~kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > +++ a/arch/sparc/include/asm/highmem.h > @@ -30,7 +30,7 @@ > /* declarations for highmem.c */ > extern unsigned long highstart_pfn, highend_pfn; > > -#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE) > extern pte_t *pkmap_page_table; > > void kmap_init(void) __init; > _ > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2535C47247 for ; Thu, 7 May 2020 22:51:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8087D2083B for ; Thu, 7 May 2020 22:51:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mB5Eqddv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8087D2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Eze8YCCJeYUL2VaGAVlMALC8nD2PAJxGOfNCmwF4oSs=; b=mB5Eqddvk0MoMw bCu3bkKR8AVWdcDwyQqRdU5Ny2c1JdpiSpIZ7hIq65MQk8VAcKXuEMwmyA8oe7Rkef8qdK1nZGFFi h0584OE/DJVp4t0l4dXy6sJm8HdhuY2w6bclI4Fs4lTBYmdjyMhiqNXM3n/+UqZxtAJfsbxFe0IRp dZb99i6RCtVdPmVgPls/dN85AxpTqxZdurJ/3kfC0o+QYYXt31DwK+Qq8QfMLt2F/40V5MYzbzU65 RlAiLSOnGNlA1rhXc++Is/rzyY4e40R1c35rm2hHc2RoOWOERvo1Gu/U4iyRcgyVi6iUbhbriMtxn LiqppK/Mu7UwMKVdYCSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWpMQ-00078n-S3; Thu, 07 May 2020 22:51:22 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWpME-0006uz-J4; Thu, 07 May 2020 22:51:12 +0000 IronPort-SDR: ttswIfcYKM6NM2yuiOzlBuQDeCJzBxZ2BHqWeRbgm4KjA1Q6weS+oGS2KFedBLWxepUY29f0i4 EtkrAUSGcbFw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 15:51:10 -0700 IronPort-SDR: KkjD1YAKdFT3e8D2XZABzY3aQLKnEXKOn0h0SQMKXa5uihRm4jFYYxRo95q/YttHS9mZ9NUdq7 NTH13HRvGuSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,365,1583222400"; d="scan'208";a="251643272" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga008.fm.intel.com with ESMTP; 07 May 2020 15:51:09 -0700 Date: Thu, 7 May 2020 15:51:09 -0700 From: Ira Weiny To: Andrew Morton Subject: Re: [PATCH V3 15/15] kmap: Consolidate kmap_prot definitions Message-ID: <20200507225109.GB1428632@iweiny-DESK2.sc.intel.com> References: <20200507150004.1423069-1-ira.weiny@intel.com> <20200507150004.1423069-16-ira.weiny@intel.com> <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> User-Agent: Mutt/1.11.1 (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_155110_639379_9CF30627 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Thu, May 07, 2020 at 01:53:07PM -0700, Andrew Morton wrote: > On Thu, 7 May 2020 08:00:03 -0700 ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > Most architectures define kmap_prot to be PAGE_KERNEL. > > > > Let sparc and xtensa define there own and define PAGE_KERNEL as the > > default if not overridden. > > > > checkpatch considered useful ;) Yes sorry... V3.1 on it's way... Ira > > > From: Andrew Morton > Subject: kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > > WARNING: macros should not use a trailing semicolon > #134: FILE: arch/sparc/include/asm/highmem.h:33: > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > > total: 0 errors, 1 warnings, 100 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > ./patches/kmap-consolidate-kmap_prot-definitions.patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Please run checkpatch prior to sending patches > > Cc: Ira Weiny > Signed-off-by: Andrew Morton > --- > > arch/sparc/include/asm/highmem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/sparc/include/asm/highmem.h~kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > +++ a/arch/sparc/include/asm/highmem.h > @@ -30,7 +30,7 @@ > /* declarations for highmem.c */ > extern unsigned long highstart_pfn, highend_pfn; > > -#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE) > extern pte_t *pkmap_page_table; > > void kmap_init(void) __init; > _ > _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F9CC47247 for ; Thu, 7 May 2020 22:51:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08101208CA for ; Thu, 7 May 2020 22:51:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cPAzSVZq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08101208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zruqD8xWjMGxDf9K0TFrhRZ4PkLZoWz7XEau1J5IXJA=; b=cPAzSVZqY9MM2n YO+X8b9T1huc7pDLMt9vb+5bUza/VRogBUEV4FlaE4jUOHh0l13xgGf1bsj813gh7oSGPSvN3Ys53 7QH4B9q3WXt7GaZxEFku9TWraVF/rg31CZtKekL3wnKAE8KCcwA19Qg+VwDn/r6Zkn6YYkHl00Izz 5fLXjZNk9vAt/zeWQ/YnRFSltZF5gxM80/w2c1RHG9Fi101JXcFYPoI5B3u3Vv36xOdTeViAYmbKK t1NjsFnqrBfEU+C8EdvD7pi+m2CL8kvyllj+OqCg4Jge6zQsEUAU0T1MrvI5CdLfi2QtYrTSQ04/G xXfFo3GMU4+Js91iRJIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWpMI-0006yl-H3; Thu, 07 May 2020 22:51:14 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWpME-0006uz-J4; Thu, 07 May 2020 22:51:12 +0000 IronPort-SDR: ttswIfcYKM6NM2yuiOzlBuQDeCJzBxZ2BHqWeRbgm4KjA1Q6weS+oGS2KFedBLWxepUY29f0i4 EtkrAUSGcbFw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 15:51:10 -0700 IronPort-SDR: KkjD1YAKdFT3e8D2XZABzY3aQLKnEXKOn0h0SQMKXa5uihRm4jFYYxRo95q/YttHS9mZ9NUdq7 NTH13HRvGuSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,365,1583222400"; d="scan'208";a="251643272" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga008.fm.intel.com with ESMTP; 07 May 2020 15:51:09 -0700 Date: Thu, 7 May 2020 15:51:09 -0700 From: Ira Weiny To: Andrew Morton Subject: Re: [PATCH V3 15/15] kmap: Consolidate kmap_prot definitions Message-ID: <20200507225109.GB1428632@iweiny-DESK2.sc.intel.com> References: <20200507150004.1423069-1-ira.weiny@intel.com> <20200507150004.1423069-16-ira.weiny@intel.com> <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> User-Agent: Mutt/1.11.1 (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_155110_639379_9CF30627 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 07, 2020 at 01:53:07PM -0700, Andrew Morton wrote: > On Thu, 7 May 2020 08:00:03 -0700 ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > Most architectures define kmap_prot to be PAGE_KERNEL. > > > > Let sparc and xtensa define there own and define PAGE_KERNEL as the > > default if not overridden. > > > > checkpatch considered useful ;) Yes sorry... V3.1 on it's way... Ira > > > From: Andrew Morton > Subject: kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > > WARNING: macros should not use a trailing semicolon > #134: FILE: arch/sparc/include/asm/highmem.h:33: > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > > total: 0 errors, 1 warnings, 100 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > ./patches/kmap-consolidate-kmap_prot-definitions.patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Please run checkpatch prior to sending patches > > Cc: Ira Weiny > Signed-off-by: Andrew Morton > --- > > arch/sparc/include/asm/highmem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/sparc/include/asm/highmem.h~kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > +++ a/arch/sparc/include/asm/highmem.h > @@ -30,7 +30,7 @@ > /* declarations for highmem.c */ > extern unsigned long highstart_pfn, highend_pfn; > > -#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE) > extern pte_t *pkmap_page_table; > > void kmap_init(void) __init; > _ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDC5C4724C for ; Thu, 7 May 2020 22:51:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF4B82083B for ; Thu, 7 May 2020 22:51:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF4B82083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 470906E1F1; Thu, 7 May 2020 22:51:11 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 468FD6E1F1 for ; Thu, 7 May 2020 22:51:10 +0000 (UTC) IronPort-SDR: eUCqbuWf+iD/B5iUS/svtASJG7vsMcwaSRAQmqzXPwBJa/m5LXTYC4dD/827VpaNVihvRHEHdH uwL/YdecOfew== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 15:51:09 -0700 IronPort-SDR: KkjD1YAKdFT3e8D2XZABzY3aQLKnEXKOn0h0SQMKXa5uihRm4jFYYxRo95q/YttHS9mZ9NUdq7 NTH13HRvGuSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,365,1583222400"; d="scan'208";a="251643272" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga008.fm.intel.com with ESMTP; 07 May 2020 15:51:09 -0700 Date: Thu, 7 May 2020 15:51:09 -0700 From: Ira Weiny To: Andrew Morton Subject: Re: [PATCH V3 15/15] kmap: Consolidate kmap_prot definitions Message-ID: <20200507225109.GB1428632@iweiny-DESK2.sc.intel.com> References: <20200507150004.1423069-1-ira.weiny@intel.com> <20200507150004.1423069-16-ira.weiny@intel.com> <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200507135307.4ba10d99c611f17beab31751@linux-foundation.org> User-Agent: Mutt/1.11.1 (2018-12-01) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 07, 2020 at 01:53:07PM -0700, Andrew Morton wrote: > On Thu, 7 May 2020 08:00:03 -0700 ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > Most architectures define kmap_prot to be PAGE_KERNEL. > > > > Let sparc and xtensa define there own and define PAGE_KERNEL as the > > default if not overridden. > > > > checkpatch considered useful ;) Yes sorry... V3.1 on it's way... Ira > > > From: Andrew Morton > Subject: kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > > WARNING: macros should not use a trailing semicolon > #134: FILE: arch/sparc/include/asm/highmem.h:33: > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > > total: 0 errors, 1 warnings, 100 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > ./patches/kmap-consolidate-kmap_prot-definitions.patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Please run checkpatch prior to sending patches > > Cc: Ira Weiny > Signed-off-by: Andrew Morton > --- > > arch/sparc/include/asm/highmem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/sparc/include/asm/highmem.h~kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > +++ a/arch/sparc/include/asm/highmem.h > @@ -30,7 +30,7 @@ > /* declarations for highmem.c */ > extern unsigned long highstart_pfn, highend_pfn; > > -#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE) > extern pte_t *pkmap_page_table; > > void kmap_init(void) __init; > _ > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel