From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3134363397586013433==" MIME-Version: 1.0 From: kbuild test robot Subject: [PATCH] PCI: fix platform_get_irq.cocci warnings Date: Fri, 08 May 2020 07:27:26 +0800 Message-ID: <20200507232726.GA15331@a836a3f6df01> In-Reply-To: <202005080708.oPqRROEz%lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============3134363397586013433== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-pci(a)vger.kernel.org TO: Aman Sharma CC: Bjorn Helgaas CC: Lorenzo Pieralisi CC: Andrew Murray CC: Thierry Reding CC: Jonathan Hunter CC: Vidya Sagar CC: linux-pci(a)vger.kernel.org CC: linux-tegra(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kbuild test robot drivers/pci/controller/dwc/pcie-tegra194.c:2194:2-9: line 2194 is redundant= because platform_get_irq() already prints an error Remove dev_err() messages after platform_get_irq*() failures Generated by: scripts/coccinelle/api/platform_get_irq.cocci Fixes: 198938ec966d ("PCI: Check for platform_get_irq() failure consistentl= y") CC: Aman Sharma Signed-off-by: kbuild test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci= /misc head: a88f8c176147d9778330082fcc34b7107da756aa commit: 198938ec966d45c47eb7c1f6d2a4ac82c12bf5ce [2/3] PCI: Check for platf= orm_get_irq() failure consistently :::::: branch date: 3 hours ago :::::: commit date: 2 days ago Please take the patch only if it's a positive warning. Thanks! pcie-tegra194.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -2191,7 +2191,6 @@ static int tegra_pcie_dw_probe(struct pl = pp->irq =3D platform_get_irq_byname(pdev, "intr"); if (pp->irq < 0) { - dev_err(dev, "Failed to get \"intr\" interrupt\n"); return pp->irq; } =20 --===============3134363397586013433==--