From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3D0C35280 for ; Fri, 8 May 2020 00:04:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 815F12082E for ; Fri, 8 May 2020 00:04:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="krVrVHtW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbgEHAER (ORCPT ); Thu, 7 May 2020 20:04:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726464AbgEHAER (ORCPT ); Thu, 7 May 2020 20:04:17 -0400 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 377A1C05BD43 for ; Thu, 7 May 2020 17:04:17 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id r3so22437qvm.1 for ; Thu, 07 May 2020 17:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2thaB8NuEajRNyAZPfj2ahshuNntoNHnFvdss0W1UZM=; b=krVrVHtWCPse14460tvZqXI94GbqW0s1ZjlGaNIV8uuD3N0NDhrRxkCvBWqjQNqLA0 jCqs/OSu603ANt/nKyfGRwpC73aKWiiqQRWSUrnCZTSYcJxROvp59SUOaK1XOGv1nibj qoKZyYKqV8BZQw4hZt21PouoKPldpY4dQXhtxJmbqCZ1kfcgcuMBo3E4fXDMFtI9iIq5 qjOgQtU5jpp9lmbUdZXhSmvSVXolkYzi8uJ2DxStsVWo2FLQ0n5GkO6eTsbmDykYy099 3+vNanYafLz59aXcO5q3gIx9wDDuDkc6WH4JEN8vYPLE+hX7JIKuYADwCnHOdTWy7kPa u9cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2thaB8NuEajRNyAZPfj2ahshuNntoNHnFvdss0W1UZM=; b=S3O2BoUy6tbdrzfG94enWWVtNrG8KNMMVhyWT+6I9eRFbBbeC4SumGvjSnyPcCbzih K6kenA+06vOBmcn/HFLRCI92pQSCqfCp9yXzvJhWenuhmTOBw5XJ6ZhMyUrt+Quy9t0A LDwbSjf3rM+f6YvK5aZeG7bTpV+BlvuxRS5SCA5bybG7bcGJNTxrVNZGR35K23wk0mQa 7nge6nOOIN9H8oVdoKGV4MBuAzZM9LJGqsai5cC1Cujvjp9CfkDZrkLWithcWoEmpMMq Tfy5fcCUWFpIi2vRQ8LXa4B7rM1Ynk2Mj3scdBPZVJDp4jyjdcOXX2esiZ00zqHzu+bn jF9A== X-Gm-Message-State: AGi0Pua9Tu6sSAo9HNMtDMxtJB5XvL10IwvC9ECvxJT2nPi9hwq+juj3 +iCVDAG2kqytvxpC40gykVGyKw== X-Google-Smtp-Source: APiQypIOWSUwEdj/qgeHNzM9aQNKP6cGb0OMtCYmu0sroLLZqUodgxtmJH26nuxT1g/GP20i0tP1mw== X-Received: by 2002:ad4:42c9:: with SMTP id f9mr118700qvr.228.1588896256353; Thu, 07 May 2020 17:04:16 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id h188sm5476567qke.82.2020.05.07.17.04.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 May 2020 17:04:15 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jWqUx-0001Ul-Ah; Thu, 07 May 2020 21:04:15 -0300 Date: Thu, 7 May 2020 21:04:15 -0300 From: Jason Gunthorpe To: Colin King Cc: Leon Romanovsky , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz Message-ID: <20200508000415.GA5704@ziepe.ca> References: <20200507151610.52636-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507151610.52636-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, May 07, 2020 at 04:16:10PM +0100, Colin King wrote: > From: Colin Ian King > > The variable rcqe_sz is being unnecessarily assigned twice, fix this > by removing one of the duplicates. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King > Acked-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx5/qp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied to for-next, thanks Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Fri, 08 May 2020 00:04:15 +0000 Subject: Re: [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz Message-Id: <20200508000415.GA5704@ziepe.ca> List-Id: References: <20200507151610.52636-1-colin.king@canonical.com> In-Reply-To: <20200507151610.52636-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Leon Romanovsky , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Thu, May 07, 2020 at 04:16:10PM +0100, Colin King wrote: > From: Colin Ian King > > The variable rcqe_sz is being unnecessarily assigned twice, fix this > by removing one of the duplicates. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King > Acked-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx5/qp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied to for-next, thanks Jason