From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C34FC38A2A for ; Fri, 8 May 2020 09:14:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1460208CA for ; Fri, 8 May 2020 09:14:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UGlphvp8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726091AbgEHJOx (ORCPT ); Fri, 8 May 2020 05:14:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725379AbgEHJOw (ORCPT ); Fri, 8 May 2020 05:14:52 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 830E4C05BD43 for ; Fri, 8 May 2020 02:14:52 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id b6so464613plz.13 for ; Fri, 08 May 2020 02:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nMxBmOmA0pSsTRUw0Y2HDt6KguOgwVLNatcARhBcWek=; b=UGlphvp8K38wllfNZo25/p/gee62yCv5K/mw3jjK3Izj2ivGn5sOvxfchz/UekfLxM 7AzyMfBhLd17KQ5VSr+hVb/EDNVHaiOPIDHAO9c8zRofVoTPsWcvEn2wTBVB1MW8YCwE 91pVouyKwC9xq8xMRHi8bmWyuoeSDJx8OiP1Z2eF4S3SSsC2HRpKZR8Og5MJCMG4uX5w kiZqibm2up6Lc8YqI5ca8YeU5j17Ko8tYj+cQOgD78B81i0kof72vstUjCFhG6V3nazw PQRYe7jR3aBBi8hkS1JFym6cHMvdW1Bd73+M+qftJ7SxwJpx4XPFe/uFCUSRAGDn5JX9 hZtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nMxBmOmA0pSsTRUw0Y2HDt6KguOgwVLNatcARhBcWek=; b=o9Fr1G/K0lyxCITmQZXwGyDl9zRqnAUr8Dvnkd6lbVvW9NF2yR+L3UBHxdAG3jvk2S 9+ZjMzyj8C+I9iPOO+Dat65zHksyKMveWBinDS6gtyoLfqLzk8IpuYvUfkGzW/MhlU9d q8sqBhM7eusgA2hDMnJTLtwOAKJjpapjv7eAbo6peX6vHIG5H2bWjgNRmyKPN74eONDl BvbHGG+ai2n+wO9xRDVvSSeeD1t/T6lI6PewdXQgO45d9Lpw9CdONNKpsdNvz9Odi1aO 4Mivo11OaonRnsR6+qE79TXOl+y1pLByAu3u9oIJm4h5CZf42aUdrt3J/J2rePxHgsXn Pl2Q== X-Gm-Message-State: AGi0PubkXJJuiACUPyQ9/uejlhiGmPiXSZQI1zTzz+81oJzB8XWlOM3g zNsbZwyVZo/pL2+S60qV/iCOcO9y X-Google-Smtp-Source: APiQypKo6zNGflFBY1FjZ8IG226PaDyITAYqx8t3A183iI8TJ+zQm04mg/0MSIZE/ZJFbHA17z6j3Q== X-Received: by 2002:a17:90a:d307:: with SMTP id p7mr4977045pju.207.1588929292004; Fri, 08 May 2020 02:14:52 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id u188sm1187292pfu.33.2020.05.08.02.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 02:14:51 -0700 (PDT) From: Chunyan Zhang To: Mathieu Poirier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chunyan Zhang Subject: [PATCH] coresight: tmc: mark coresight_tmc_groups with static Date: Fri, 8 May 2020 17:13:40 +0800 Message-Id: <20200508091340.11711-1-zhang.lyra@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chunyan Zhang Sparse reports a warning like: drivers/hwtracing/coresight/coresight-tmc.c:364:30: warning: symbol 'coresight_tmc_groups' was not declared. Should it be static? [sparse] coresight_tmc_groups is used in the local file only, so it should be marked with static. Signed-off-by: Chunyan Zhang --- drivers/hwtracing/coresight/coresight-tmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c index 1cf82fa..39fba1d 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.c +++ b/drivers/hwtracing/coresight/coresight-tmc.c @@ -361,7 +361,7 @@ static ssize_t buffer_size_store(struct device *dev, .name = "mgmt", }; -const struct attribute_group *coresight_tmc_groups[] = { +static const struct attribute_group *coresight_tmc_groups[] = { &coresight_tmc_group, &coresight_tmc_mgmt_group, NULL, -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6392C38A2A for ; Fri, 8 May 2020 09:14:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BF61208CA for ; Fri, 8 May 2020 09:14:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nP5pLTkh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UGlphvp8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BF61208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=RgFWC+4zMisqnJjEgcHaD9prCPI1cJLHiFjhaOPR/Hw=; b=nP5pLTkhK0z//Y mNw5DGBeMSPNscjXDlfQ8PxEsk06ZxzUXejyfbsiCmo15Mu7hEf1Wr6ytwsMhN6e0J6az1w0PZVN2 ME2Xzv+k/Mh+ZlVHNFF8enmcrX6elSvCXKKYk6ACW4MvVJ3jWqA42+Zb0RAdFNoPmnype2httmqhs FKzG3ZBJyRE6k2VSLju/XstckKa/nZg/kmhRVkFCW+893KXocU1G4oZ92f5NLztSC4iPcVjoh+XHN DmpjrFbZ5QDIO9Fq6Zspsd1xfT4oOYo7/ysKYTtqhKIXqTpCKDMgRoCnkrkTWQk97vMvxJrDLhXac Pu9BRAbg7rZoL3hA3Q8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWz5s-0001pV-MY; Fri, 08 May 2020 09:14:56 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWz5p-0001or-BM for linux-arm-kernel@lists.infradead.org; Fri, 08 May 2020 09:14:54 +0000 Received: by mail-pj1-x1041.google.com with SMTP id js4so13236pjb.5 for ; Fri, 08 May 2020 02:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nMxBmOmA0pSsTRUw0Y2HDt6KguOgwVLNatcARhBcWek=; b=UGlphvp8K38wllfNZo25/p/gee62yCv5K/mw3jjK3Izj2ivGn5sOvxfchz/UekfLxM 7AzyMfBhLd17KQ5VSr+hVb/EDNVHaiOPIDHAO9c8zRofVoTPsWcvEn2wTBVB1MW8YCwE 91pVouyKwC9xq8xMRHi8bmWyuoeSDJx8OiP1Z2eF4S3SSsC2HRpKZR8Og5MJCMG4uX5w kiZqibm2up6Lc8YqI5ca8YeU5j17Ko8tYj+cQOgD78B81i0kof72vstUjCFhG6V3nazw PQRYe7jR3aBBi8hkS1JFym6cHMvdW1Bd73+M+qftJ7SxwJpx4XPFe/uFCUSRAGDn5JX9 hZtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nMxBmOmA0pSsTRUw0Y2HDt6KguOgwVLNatcARhBcWek=; b=fEfiRTzjeXyFC1g6XBxHSy+s2hB2qwappfg3w5acfUblclHibCC0RsrhdMaV+EfV+z ZmU3sCoYDqPA7QIvIkeePmSMuibi5aOG4FYpOtSZ1SMUQcaYzwkrBJF0JJmcT436RMqZ qttYQa3b/TdKq/QeZm663yU7pltaJv+j8yRwcOPE9O6GgIHHDmk+HwfcjRkwVX0DxGwN 1kjTM62ZwMs4fu1lPyca4HqaPNEwDwM5nOtYOmdxk02CRi1fCwU45VY42u+UzRuLa2Uh VTmjKyBzaaJjmLfLRSDT4V22pdsXS/cL1z7L557RM5eT6TiPm6ZegBmuMJeddAWMB3/t 65Ag== X-Gm-Message-State: AGi0PuY7GSM+Iu2DVPFgB7OTHvp058T5FTxCh7NYZKw0q1L0yk0yobWr P3ZZvieZVr+93qBoEbZRDJ4= X-Google-Smtp-Source: APiQypKo6zNGflFBY1FjZ8IG226PaDyITAYqx8t3A183iI8TJ+zQm04mg/0MSIZE/ZJFbHA17z6j3Q== X-Received: by 2002:a17:90a:d307:: with SMTP id p7mr4977045pju.207.1588929292004; Fri, 08 May 2020 02:14:52 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id u188sm1187292pfu.33.2020.05.08.02.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 02:14:51 -0700 (PDT) From: Chunyan Zhang To: Mathieu Poirier Subject: [PATCH] coresight: tmc: mark coresight_tmc_groups with static Date: Fri, 8 May 2020 17:13:40 +0800 Message-Id: <20200508091340.11711-1-zhang.lyra@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200508_021453_415689_8A0A12ED X-CRM114-Status: GOOD ( 11.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chunyan Zhang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Chunyan Zhang Sparse reports a warning like: drivers/hwtracing/coresight/coresight-tmc.c:364:30: warning: symbol 'coresight_tmc_groups' was not declared. Should it be static? [sparse] coresight_tmc_groups is used in the local file only, so it should be marked with static. Signed-off-by: Chunyan Zhang --- drivers/hwtracing/coresight/coresight-tmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c index 1cf82fa..39fba1d 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.c +++ b/drivers/hwtracing/coresight/coresight-tmc.c @@ -361,7 +361,7 @@ static ssize_t buffer_size_store(struct device *dev, .name = "mgmt", }; -const struct attribute_group *coresight_tmc_groups[] = { +static const struct attribute_group *coresight_tmc_groups[] = { &coresight_tmc_group, &coresight_tmc_mgmt_group, NULL, -- 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel