From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Kenneth Graunke <kenneth@whitecape.org>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: [Intel-gfx] [PATCH 9/9] drm/i915/gt: Declare when we enabled timeslicing
Date: Fri, 8 May 2020 10:29:33 +0100 [thread overview]
Message-ID: <20200508092933.738-9-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20200508092933.738-1-chris@chris-wilson.co.uk>
Let userspace know if they can trust timeslicing by including it as part
of the I915_PARAM_HAS_SCHEDULER::I915_SCHEDULER_CAP_TIMESLICING
v2: Only declare timeslicing if we can safely preempt userspace.
Fixes: 8ee36e048c98 ("drm/i915/execlists: Minimalistic timeslicing")
Link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3802
Link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4854
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Kenneth Graunke <kenneth@whitecape.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/gt/intel_engine_user.c | 1 +
include/uapi/drm/i915_drm.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_user.c b/drivers/gpu/drm/i915/gt/intel_engine_user.c
index 848decee9066..8415511f1465 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_user.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_user.c
@@ -98,6 +98,7 @@ static void set_scheduler_caps(struct drm_i915_private *i915)
MAP(HAS_PREEMPTION, PREEMPTION),
MAP(HAS_SEMAPHORES, SEMAPHORES),
MAP(SUPPORTS_STATS, ENGINE_BUSY_STATS),
+ MAP(HAS_TIMESLICES, TIMESLICING),
#undef MAP
};
struct intel_engine_cs *engine;
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index 704dd0e3bc1d..1ee227b5131a 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -523,6 +523,7 @@ typedef struct drm_i915_irq_wait {
#define I915_SCHEDULER_CAP_PREEMPTION (1ul << 2)
#define I915_SCHEDULER_CAP_SEMAPHORES (1ul << 3)
#define I915_SCHEDULER_CAP_ENGINE_BUSY_STATS (1ul << 4)
+#define I915_SCHEDULER_CAP_TIMESLICING (1ul << 5)
#define I915_PARAM_HUC_STATUS 42
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-08 9:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 9:29 [Intel-gfx] [PATCH 1/9] drm/i915: Ignore submit-fences on the same timeline Chris Wilson
2020-05-08 9:29 ` [Intel-gfx] [PATCH 2/9] drm/i915: Pull waiting on an external dma-fence into its routine Chris Wilson
2020-05-08 10:19 ` Mika Kuoppala
2020-05-08 10:26 ` Chris Wilson
2020-05-08 10:27 ` Chris Wilson
2020-05-08 11:08 ` Mika Kuoppala
2020-05-08 9:29 ` [Intel-gfx] [PATCH 3/9] drm/i915: Prevent using semaphores to chain up to external fences Chris Wilson
2020-05-08 15:37 ` Mika Kuoppala
2020-05-08 15:43 ` Chris Wilson
2020-05-08 15:44 ` Mika Kuoppala
2020-05-08 15:56 ` Chris Wilson
2020-05-08 9:29 ` [Intel-gfx] [PATCH 4/9] drm/i915: Tidy awaiting on dma-fences Chris Wilson
2020-05-08 15:50 ` Mika Kuoppala
2020-05-08 15:58 ` Chris Wilson
2020-05-08 9:29 ` [Intel-gfx] [PATCH 5/9] dma-buf: Proxy fence, an unsignaled fence placeholder Chris Wilson
2020-05-08 9:29 ` [Intel-gfx] [PATCH 6/9] drm/syncobj: Allow use of dma-fence-proxy Chris Wilson
2020-05-08 9:29 ` [Intel-gfx] [PATCH 7/9] drm/i915/gem: Teach execbuf how to wait on future syncobj Chris Wilson
2020-05-08 9:29 ` [Intel-gfx] [PATCH 8/9] drm/i915/gem: Allow combining submit-fences with syncobj Chris Wilson
2020-05-08 9:29 ` Chris Wilson [this message]
2020-05-08 9:57 ` [Intel-gfx] [PATCH 1/9] drm/i915: Ignore submit-fences on the same timeline Mika Kuoppala
2020-05-08 10:09 ` Chris Wilson
2020-05-08 11:11 ` Mika Kuoppala
2020-05-08 10:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] " Patchwork
2020-05-08 10:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-08 12:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508092933.738-9-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.