From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D9FC38A2A for ; Fri, 8 May 2020 11:02:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F081208CA for ; Fri, 8 May 2020 11:02:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F081208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 031FC6EAE2; Fri, 8 May 2020 11:02:57 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70F6F6EAE2 for ; Fri, 8 May 2020 11:02:55 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 4250180500; Fri, 8 May 2020 13:02:53 +0200 (CEST) Date: Fri, 8 May 2020 13:02:51 +0200 From: Sam Ravnborg To: Emil Velikov Subject: Re: [PATCH 36/36] drm/gem: remove _unlocked suffix in drm_object_put_unlocked Message-ID: <20200508110251.GA15931@ravnborg.org> References: <20200507150822.114464-1-emil.l.velikov@gmail.com> <20200507150822.114464-37-emil.l.velikov@gmail.com> <20200507181413.GD13247@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=MOBOZvRl c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=QX4gbG5DAAAA:8 a=gMF24IRGu3KNNTbqFggA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , ML dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Emil. On Fri, May 08, 2020 at 11:15:24AM +0100, Emil Velikov wrote: > On Thu, 7 May 2020 at 19:14, Sam Ravnborg wrote: > > > > Hi Emil. > > > > On Thu, May 07, 2020 at 04:08:22PM +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Spelling out _unlocked for each and every driver is a annoying. > > > Especially if we consider how many drivers, do not know (or need to) > > > about the horror stories involving struct_mutex. > > > > > > Just drop the suffix. It makes the API cleaner. > > > > > > Done via the following script: > > > > > > __from=drm_gem_object_put_unlocked > > > __to=drm_gem_object_put > > > for __file in $(git grep --name-only $__from); do > > > sed -i "s/$__from/$__to/g" $__file; > > > done > > > > > > With this patch, the _unlocked define is no longer needed - remove it. > > > > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Signed-off-by: Emil Velikov > > > > I had prefeered this was spilt in three patches: > > 1) drm_gem* > > 2) drm_client, drm_prime, drm-mm > > 3) Removal of the define > > > > Maybe just squash 1) and 2) in the above, but I like it spelled out that > > the backward compatible define is dropped. > > > Think that we can combine your and Thomas' suggestions: > - fold all of drm in once patch - move it all to patch 11 > - keep the #define removal as separate patch Yup, sound like a good plan. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel