* [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe()
@ 2020-05-08 11:44 Tang Bin
2020-05-08 11:48 ` Greg KH
2020-05-08 13:51 ` Alan Stern
0 siblings, 2 replies; 11+ messages in thread
From: Tang Bin @ 2020-05-08 11:44 UTC (permalink / raw)
To: stern, gregkh; +Cc: linux-usb, linux-kernel, Tang Bin, Zhang Shengju
The function ehci_mxc_drv_probe() does not perform sufficient error
checking after executing platform_get_irq(), thus fix it.
Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards")
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/usb/host/ehci-mxc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index a1eb5ee77..a0b42ba59 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
+ if (irq < 0)
+ return irq;
hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev));
if (!hcd)
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() 2020-05-08 11:44 [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Tang Bin @ 2020-05-08 11:48 ` Greg KH 2020-05-08 13:55 ` [PATCH] USB: host: ehci: Add error handling inehci_mxc_drv_probe() Tang Bin 2020-05-08 20:30 ` [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Sergei Shtylyov 2020-05-08 13:51 ` Alan Stern 1 sibling, 2 replies; 11+ messages in thread From: Greg KH @ 2020-05-08 11:48 UTC (permalink / raw) To: Tang Bin; +Cc: stern, linux-usb, linux-kernel, Zhang Shengju On Fri, May 08, 2020 at 07:44:53PM +0800, Tang Bin wrote: > The function ehci_mxc_drv_probe() does not perform sufficient error > checking after executing platform_get_irq(), thus fix it. > > Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/usb/host/ehci-mxc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c > index a1eb5ee77..a0b42ba59 100644 > --- a/drivers/usb/host/ehci-mxc.c > +++ b/drivers/usb/host/ehci-mxc.c > @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > + if (irq < 0) > + return irq; <= ? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] USB: host: ehci: Add error handling inehci_mxc_drv_probe() 2020-05-08 11:48 ` Greg KH @ 2020-05-08 13:55 ` Tang Bin 2020-05-08 14:31 ` Greg KH 2020-05-08 20:30 ` [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Sergei Shtylyov 1 sibling, 1 reply; 11+ messages in thread From: Tang Bin @ 2020-05-08 13:55 UTC (permalink / raw) To: Greg KH; +Cc: stern, linux-usb, linux-kernel, Zhang Shengju Hi, Greg: On 2020/5/8 19:48, Greg KH wrote: > On Fri, May 08, 2020 at 07:44:53PM +0800, Tang Bin wrote: >> The function ehci_mxc_drv_probe() does not perform sufficient error >> checking after executing platform_get_irq(), thus fix it. >> >> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") >> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> >> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >> --- >> drivers/usb/host/ehci-mxc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c >> index a1eb5ee77..a0b42ba59 100644 >> --- a/drivers/usb/host/ehci-mxc.c >> +++ b/drivers/usb/host/ehci-mxc.c >> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) >> } >> >> irq = platform_get_irq(pdev, 0); >> + if (irq < 0) >> + return irq; > <= ? In the file 'drivers/base/platform.c'， the function platform_get_irq() is explained and used as follows: * Gets an IRQ for a platform device and prints an error message if finding the * IRQ fails. Device drivers should check the return value for errors so as to * not pass a negative integer value to the request_irq() APIs. * * Example: * int irq = platform_get_irq(pdev, 0); * if (irq < 0) * return irq; * * Return: IRQ number on success, negative error number on failure. And in my hardware experiment, even if I set the irq failed deliberately in the DTS, the returned value is negative instead of zero. Thanks for your patience and replay. Tang Bin ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] USB: host: ehci: Add error handling inehci_mxc_drv_probe() 2020-05-08 13:55 ` [PATCH] USB: host: ehci: Add error handling inehci_mxc_drv_probe() Tang Bin @ 2020-05-08 14:31 ` Greg KH 2020-05-08 15:03 ` [PATCH] USB: host: ehci: Add error handlinginehci_mxc_drv_probe() Tang Bin 0 siblings, 1 reply; 11+ messages in thread From: Greg KH @ 2020-05-08 14:31 UTC (permalink / raw) To: Tang Bin; +Cc: stern, linux-usb, linux-kernel, Zhang Shengju On Fri, May 08, 2020 at 09:55:53PM +0800, Tang Bin wrote: > Hi, Greg: > > On 2020/5/8 19:48, Greg KH wrote: > > On Fri, May 08, 2020 at 07:44:53PM +0800, Tang Bin wrote: > > > The function ehci_mxc_drv_probe() does not perform sufficient error > > > checking after executing platform_get_irq(), thus fix it. > > > > > > Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") > > > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> > > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > > > --- > > > drivers/usb/host/ehci-mxc.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c > > > index a1eb5ee77..a0b42ba59 100644 > > > --- a/drivers/usb/host/ehci-mxc.c > > > +++ b/drivers/usb/host/ehci-mxc.c > > > @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) > > > } > > > irq = platform_get_irq(pdev, 0); > > > + if (irq < 0) > > > + return irq; > > <= ? > > In the file 'drivers/base/platform.c'， the function platform_get_irq() is > explained and used as follows: > > * Gets an IRQ for a platform device and prints an error message if > finding the > * IRQ fails. Device drivers should check the return value for errors so > as to > * not pass a negative integer value to the request_irq() APIs. > * > * Example: > * int irq = platform_get_irq(pdev, 0); > * if (irq < 0) > * return irq; > * > * Return: IRQ number on success, negative error number on failure. > > And in my hardware experiment, even if I set the irq failed deliberately in > the DTS, the returned value is negative instead of zero. Please read the thread at https://lore.kernel.org/r/20200501224042.141366-1-helgaas%40kernel.org for more details about this. thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] USB: host: ehci: Add error handlinginehci_mxc_drv_probe() 2020-05-08 14:31 ` Greg KH @ 2020-05-08 15:03 ` Tang Bin 2020-05-08 20:27 ` Sergei Shtylyov 0 siblings, 1 reply; 11+ messages in thread From: Tang Bin @ 2020-05-08 15:03 UTC (permalink / raw) To: Greg KH; +Cc: stern, linux-usb, linux-kernel, Zhang Shengju On 2020/5/8 22:31, Greg KH wrote: > On Fri, May 08, 2020 at 09:55:53PM +0800, Tang Bin wrote: >> Hi, Greg: >> >> On 2020/5/8 19:48, Greg KH wrote: >>> On Fri, May 08, 2020 at 07:44:53PM +0800, Tang Bin wrote: >>>> The function ehci_mxc_drv_probe() does not perform sufficient error >>>> checking after executing platform_get_irq(), thus fix it. >>>> >>>> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") >>>> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> >>>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >>>> --- >>>> drivers/usb/host/ehci-mxc.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c >>>> index a1eb5ee77..a0b42ba59 100644 >>>> --- a/drivers/usb/host/ehci-mxc.c >>>> +++ b/drivers/usb/host/ehci-mxc.c >>>> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) >>>> } >>>> irq = platform_get_irq(pdev, 0); >>>> + if (irq < 0) >>>> + return irq; >>> <= ? >> In the file 'drivers/base/platform.c'， the function platform_get_irq() is >> explained and used as follows: >> >> * Gets an IRQ for a platform device and prints an error message if >> finding the >> * IRQ fails. Device drivers should check the return value for errors so >> as to >> * not pass a negative integer value to the request_irq() APIs. >> * >> * Example: >> * int irq = platform_get_irq(pdev, 0); >> * if (irq < 0) >> * return irq; >> * >> * Return: IRQ number on success, negative error number on failure. >> >> And in my hardware experiment, even if I set the irq failed deliberately in >> the DTS, the returned value is negative instead of zero. > Please read the thread at > https://lore.kernel.org/r/20200501224042.141366-1-helgaas%40kernel.org > for more details about this. > Great, It looks beautiful, finally someone took a knife to the file 'platform.c'. I have been studied this place for a long time, and don't know what platform can return 0, which made me curious. So the example should be: * int irq = platform_get_irq(pdev, 0); * if (irq <= 0) * return irq; Thanks, Tang Bin ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] USB: host: ehci: Add error handlinginehci_mxc_drv_probe() 2020-05-08 15:03 ` [PATCH] USB: host: ehci: Add error handlinginehci_mxc_drv_probe() Tang Bin @ 2020-05-08 20:27 ` Sergei Shtylyov 2020-05-09 1:13 ` Tang Bin 0 siblings, 1 reply; 11+ messages in thread From: Sergei Shtylyov @ 2020-05-08 20:27 UTC (permalink / raw) To: Tang Bin, Greg KH; +Cc: stern, linux-usb, linux-kernel, Zhang Shengju On 05/08/2020 06:03 PM, Tang Bin wrote: >>>> On Fri, May 08, 2020 at 07:44:53PM +0800, Tang Bin wrote: >>>>> The function ehci_mxc_drv_probe() does not perform sufficient error >>>>> checking after executing platform_get_irq(), thus fix it. >>>>> >>>>> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") >>>>> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> >>>>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >>>>> --- >>>>> drivers/usb/host/ehci-mxc.c | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c >>>>> index a1eb5ee77..a0b42ba59 100644 >>>>> --- a/drivers/usb/host/ehci-mxc.c >>>>> +++ b/drivers/usb/host/ehci-mxc.c >>>>> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) >>>>> } >>>>> irq = platform_get_irq(pdev, 0); >>>>> + if (irq < 0) >>>>> + return irq; >>>> <= ? >>> In the file 'drivers/base/platform.c'， the function platform_get_irq() is >>> explained and used as follows: >>> >>> * Gets an IRQ for a platform device and prints an error message if >>> finding the >>> * IRQ fails. Device drivers should check the return value for errors so >>> as to >>> * not pass a negative integer value to the request_irq() APIs. >>> * >>> * Example: >>> * int irq = platform_get_irq(pdev, 0); >>> * if (irq < 0) >>> * return irq; >>> * >>> * Return: IRQ number on success, negative error number on failure. >>> >>> And in my hardware experiment, even if I set the irq failed deliberately in >>> the DTS, the returned value is negative instead of zero. >> Please read the thread at >> https://lore.kernel.org/r/20200501224042.141366-1-helgaas%40kernel.org >> for more details about this. >> > Great, It looks beautiful, finally someone took a knife to the file 'platform.c'. I thought I did that already couple years ago, when returned 0 from platform_get_irq() could mean both IRQ # and error... :-) > > I have been studied this place for a long time, and don't know what platform can return 0, which made me curious. > > So the example should be: > > * int irq = platform_get_irq(pdev, 0); > * if (irq <= 0) > * return irq; And you then return 0 (success) as if your probe() succeeded. Congratulations! :-P > > Thanks, > > Tang Bin MBR, Sergei ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] USB: host: ehci: Add error handlinginehci_mxc_drv_probe() 2020-05-08 20:27 ` Sergei Shtylyov @ 2020-05-09 1:13 ` Tang Bin 0 siblings, 0 replies; 11+ messages in thread From: Tang Bin @ 2020-05-09 1:13 UTC (permalink / raw) To: Sergei Shtylyov; +Cc: Greg KH, stern, linux-usb, linux-kernel Hi Sergei: On 2020/5/9 4:27, Sergei Shtylyov wrote: > On 05/08/2020 06:03 PM, Tang Bin wrote: > >>>>> On Fri, May 08, 2020 at 07:44:53PM +0800, Tang Bin wrote: >>>>>> The function ehci_mxc_drv_probe() does not perform sufficient error >>>>>> checking after executing platform_get_irq(), thus fix it. >>>>>> >>>>>> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") >>>>>> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> >>>>>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >>>>>> --- >>>>>> drivers/usb/host/ehci-mxc.c | 2 ++ >>>>>> 1 file changed, 2 insertions(+) >>>>>> >>>>>> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c >>>>>> index a1eb5ee77..a0b42ba59 100644 >>>>>> --- a/drivers/usb/host/ehci-mxc.c >>>>>> +++ b/drivers/usb/host/ehci-mxc.c >>>>>> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) >>>>>> } >>>>>> irq = platform_get_irq(pdev, 0); >>>>>> + if (irq < 0) >>>>>> + return irq; >>>>> <= ? >>>> In the file 'drivers/base/platform.c'， the function platform_get_irq() is >>>> explained and used as follows: >>>> >>>> * Gets an IRQ for a platform device and prints an error message if >>>> finding the >>>> * IRQ fails. Device drivers should check the return value for errors so >>>> as to >>>> * not pass a negative integer value to the request_irq() APIs. >>>> * >>>> * Example: >>>> * int irq = platform_get_irq(pdev, 0); >>>> * if (irq < 0) >>>> * return irq; >>>> * >>>> * Return: IRQ number on success, negative error number on failure. >>>> >>>> And in my hardware experiment, even if I set the irq failed deliberately in >>>> the DTS, the returned value is negative instead of zero. >>> Please read the thread at >>> https://lore.kernel.org/r/20200501224042.141366-1-helgaas%40kernel.org >>> for more details about this. >>> >> Great, It looks beautiful, finally someone took a knife to the file 'platform.c'. > I thought I did that already couple years ago, when returned 0 from platform_get_irq() could mean both IRQ # and error... :-) Can you tell me what platform can returned 0? I want to do this test in the hardware. >> I have been studied this place for a long time, and don't know what platform can return 0, which made me curious. >> >> So the example should be: >> >> * int irq = platform_get_irq(pdev, 0); >> * if (irq <= 0) >> * return irq; > And you then return 0 (success) as if your probe() succeeded. Congratulations! :-P Thanks, Tang Bin ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() 2020-05-08 11:48 ` Greg KH 2020-05-08 13:55 ` [PATCH] USB: host: ehci: Add error handling inehci_mxc_drv_probe() Tang Bin @ 2020-05-08 20:30 ` Sergei Shtylyov 1 sibling, 0 replies; 11+ messages in thread From: Sergei Shtylyov @ 2020-05-08 20:30 UTC (permalink / raw) To: Greg KH, Tang Bin; +Cc: stern, linux-usb, linux-kernel, Zhang Shengju On 05/08/2020 02:48 PM, Greg KH wrote: >> The function ehci_mxc_drv_probe() does not perform sufficient error >> checking after executing platform_get_irq(), thus fix it. >> >> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") >> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> >> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >> --- >> drivers/usb/host/ehci-mxc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c >> index a1eb5ee77..a0b42ba59 100644 >> --- a/drivers/usb/host/ehci-mxc.c >> +++ b/drivers/usb/host/ehci-mxc.c >> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) >> } >> >> irq = platform_get_irq(pdev, 0); >> + if (irq < 0) >> + return irq; > > <= ? I thought I've fixed the ambivalent zero bug some years ago... Please don't do this... MBR, Sergei ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() 2020-05-08 11:44 [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Tang Bin 2020-05-08 11:48 ` Greg KH @ 2020-05-08 13:51 ` Alan Stern 2020-05-13 12:55 ` Tang Bin 1 sibling, 1 reply; 11+ messages in thread From: Alan Stern @ 2020-05-08 13:51 UTC (permalink / raw) To: Tang Bin; +Cc: gregkh, linux-usb, linux-kernel, Zhang Shengju On Fri, 8 May 2020, Tang Bin wrote: > The function ehci_mxc_drv_probe() does not perform sufficient error > checking after executing platform_get_irq(), thus fix it. Aside from the "irq <= 0" issue, the Subject: line should say "ehci-mxc", not "ehci". Alan Stern > Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/usb/host/ehci-mxc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c > index a1eb5ee77..a0b42ba59 100644 > --- a/drivers/usb/host/ehci-mxc.c > +++ b/drivers/usb/host/ehci-mxc.c > @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > + if (irq < 0) > + return irq; > > hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev)); > if (!hcd) > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() 2020-05-08 13:51 ` Alan Stern @ 2020-05-13 12:55 ` Tang Bin 2020-05-13 13:01 ` Greg KH 0 siblings, 1 reply; 11+ messages in thread From: Tang Bin @ 2020-05-13 12:55 UTC (permalink / raw) To: gregkh; +Cc: Alan Stern, linux-usb, linux-kernel, Zhang Shengju Hi gregkh: On 2020/5/8 21:51, Alan Stern wrote: > On Fri, 8 May 2020, Tang Bin wrote: > >> The function ehci_mxc_drv_probe() does not perform sufficient error >> checking after executing platform_get_irq(), thus fix it. > Aside from the "irq <= 0" issue, the Subject: line should say > "ehci-mxc", not "ehci". > I know this patch need v2, whether just fix the subject? Thanks, Tang Bin > >> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") >> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> >> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >> --- >> drivers/usb/host/ehci-mxc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c >> index a1eb5ee77..a0b42ba59 100644 >> --- a/drivers/usb/host/ehci-mxc.c >> +++ b/drivers/usb/host/ehci-mxc.c >> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) >> } >> >> irq = platform_get_irq(pdev, 0); >> + if (irq < 0) >> + return irq; >> >> hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev)); >> if (!hcd) >> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() 2020-05-13 12:55 ` Tang Bin @ 2020-05-13 13:01 ` Greg KH 0 siblings, 0 replies; 11+ messages in thread From: Greg KH @ 2020-05-13 13:01 UTC (permalink / raw) To: Tang Bin; +Cc: Alan Stern, linux-usb, linux-kernel, Zhang Shengju On Wed, May 13, 2020 at 08:55:59PM +0800, Tang Bin wrote: > Hi gregkh: > > On 2020/5/8 21:51, Alan Stern wrote: > > On Fri, 8 May 2020, Tang Bin wrote: > > > > > The function ehci_mxc_drv_probe() does not perform sufficient error > > > checking after executing platform_get_irq(), thus fix it. > > Aside from the "irq <= 0" issue, the Subject: line should say > > "ehci-mxc", not "ehci". > > > I know this patch need v2, whether just fix the subject? 0 is an invalid irq. ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-05-13 13:01 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-08 11:44 [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Tang Bin 2020-05-08 11:48 ` Greg KH 2020-05-08 13:55 ` [PATCH] USB: host: ehci: Add error handling inehci_mxc_drv_probe() Tang Bin 2020-05-08 14:31 ` Greg KH 2020-05-08 15:03 ` [PATCH] USB: host: ehci: Add error handlinginehci_mxc_drv_probe() Tang Bin 2020-05-08 20:27 ` Sergei Shtylyov 2020-05-09 1:13 ` Tang Bin 2020-05-08 20:30 ` [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Sergei Shtylyov 2020-05-08 13:51 ` Alan Stern 2020-05-13 12:55 ` Tang Bin 2020-05-13 13:01 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.