Re: [PATCH v8 11/30] powerpc: Use a datatype for instructions

From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v8 11/30] powerpc: Use a datatype for instructions
Date: Fri, 08 May 2020 17:23:45 +0800	[thread overview]
Message-ID: <202005081727.A1d2i034%lkp@intel.com> (raw)
In-Reply-To: <20200506034050.24806-12-jniethe5@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3308 bytes --]

Hi Jordan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.7-rc4 next-20200507]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jordan-Niethe/Initial-Prefixed-Instruction-support/20200506-171154
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-r034-20200508 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/powerpc/lib/feature-fixups.c: In function 'patch_btb_flush_section':
>> arch/powerpc/lib/feature-fixups.c:359:21: error: passing argument 1 of 'patch_instruction' from incompatible pointer type [-Werror=incompatible-pointer-types]
     359 |   patch_instruction(start, ppc_inst(PPC_INST_NOP));
         |                     ^~~~~
         |                     |
         |                     unsigned int *
   In file included from arch/powerpc/lib/feature-fixups.c:18:
   arch/powerpc/include/asm/code-patching.h:31:40: note: expected 'struct ppc_inst *' but argument is of type 'unsigned int *'
      31 | int patch_instruction(struct ppc_inst *addr, struct ppc_inst instr);
         |                       ~~~~~~~~~~~~~~~~~^~~~
   cc1: some warnings being treated as errors

vim +/patch_instruction +359 arch/powerpc/lib/feature-fixups.c

76a5eaa38b15dd Diana Craciun 2018-12-12  350  
76a5eaa38b15dd Diana Craciun 2018-12-12  351  static void patch_btb_flush_section(long *curr)
76a5eaa38b15dd Diana Craciun 2018-12-12  352  {
76a5eaa38b15dd Diana Craciun 2018-12-12  353  	unsigned int *start, *end;
76a5eaa38b15dd Diana Craciun 2018-12-12  354  
76a5eaa38b15dd Diana Craciun 2018-12-12  355  	start = (void *)curr + *curr;
76a5eaa38b15dd Diana Craciun 2018-12-12  356  	end = (void *)curr + *(curr + 1);
76a5eaa38b15dd Diana Craciun 2018-12-12  357  	for (; start < end; start++) {
76a5eaa38b15dd Diana Craciun 2018-12-12  358  		pr_devel("patching dest %lx\n", (unsigned long)start);
db67542527cd8c Jordan Niethe 2020-05-06 @359  		patch_instruction(start, ppc_inst(PPC_INST_NOP));
76a5eaa38b15dd Diana Craciun 2018-12-12  360  	}
76a5eaa38b15dd Diana Craciun 2018-12-12  361  }
76a5eaa38b15dd Diana Craciun 2018-12-12  362  

:::::: The code@line 359 was first introduced by commit
:::::: db67542527cd8cd5c7002b8ccb222c5ca1946f61 powerpc: Use a macro for creating instructions from u32s

:::::: TO: Jordan Niethe <jniethe5@gmail.com>
:::::: CC: 0day robot <lkp@intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33174 bytes --]