All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>,
	Ioana Radulescu <ruxandra.radulescu@nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] dpaa2-eth: prevent array underflow in update_cls_rule()
Date: Fri, 8 May 2020 18:46:27 -0700	[thread overview]
Message-ID: <20200508184627.70e76aa3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200508143720.GA410645@mwanda>

On Fri, 8 May 2020 17:37:20 +0300 Dan Carpenter wrote:
> The "location" is controlled by the user via the ethtool_set_rxnfc()
> function.  This update_cls_rule() function checks for array overflows
> but it doesn't check if the value is negative.  I have changed the type
> to unsigned to prevent array underflows.
> 
> Fixes: afb90dbb5f78 ("dpaa2-eth: Add ethtool support for flow classification")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thank you!

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>,
	Ioana Radulescu <ruxandra.radulescu@nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] dpaa2-eth: prevent array underflow in update_cls_rule()
Date: Sat, 09 May 2020 01:46:27 +0000	[thread overview]
Message-ID: <20200508184627.70e76aa3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200508143720.GA410645@mwanda>

On Fri, 8 May 2020 17:37:20 +0300 Dan Carpenter wrote:
> The "location" is controlled by the user via the ethtool_set_rxnfc()
> function.  This update_cls_rule() function checks for array overflows
> but it doesn't check if the value is negative.  I have changed the type
> to unsigned to prevent array underflows.
> 
> Fixes: afb90dbb5f78 ("dpaa2-eth: Add ethtool support for flow classification")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thank you!

  reply	other threads:[~2020-05-09  1:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 14:37 [PATCH net] dpaa2-eth: prevent array underflow in update_cls_rule() Dan Carpenter
2020-05-08 14:37 ` Dan Carpenter
2020-05-09  1:46 ` Jakub Kicinski [this message]
2020-05-09  1:46   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200508184627.70e76aa3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=ioana.ciornei@nxp.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ruxandra.radulescu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.