From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA64CC38A2A for ; Sat, 9 May 2020 01:46:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3A04218AC for ; Sat, 9 May 2020 01:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588988790; bh=Aia1eRn1IZk0ij0AFrGXq6rXZoOOlH8Fd531yVcT1rs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=RXl5rdJvnxrGgdgUmKrS/RuOG5V7jgA1vPH6rvYldOnZTo/44xjx4NGR7lHzB5sA1 dwWc2Q/agH7v1yf3iSGRnYkHS4j0p6wCvIV9Cu0H9rye+hA4xjHnUgcGDevy04P4T5 qyB1ML3dUWgAKiJlgeKYRgZkGANISrYTUJ+gem+g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728415AbgEIBq3 (ORCPT ); Fri, 8 May 2020 21:46:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:42938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727828AbgEIBq3 (ORCPT ); Fri, 8 May 2020 21:46:29 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B26622184D; Sat, 9 May 2020 01:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588988789; bh=Aia1eRn1IZk0ij0AFrGXq6rXZoOOlH8Fd531yVcT1rs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fqfe8oa6UGXBiVOJTjA/Q9FhJe5lxKJskZNXQWOBRussAt1zWZOsGNHNzG9I7oj2s cjugEVaWFCMt5BwM/j/uvN+4X0Xn+qu3hadpraHU/4k8lwK1IK+l/DVtknMtuid6SC fLc4zxlfz0ZbqnH8NRZTHFQxucuvwRQ4P+JOWOy8= Date: Fri, 8 May 2020 18:46:27 -0700 From: Jakub Kicinski To: Dan Carpenter Cc: Ioana Ciornei , Ioana Radulescu , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] dpaa2-eth: prevent array underflow in update_cls_rule() Message-ID: <20200508184627.70e76aa3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200508143720.GA410645@mwanda> References: <20200508143720.GA410645@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 8 May 2020 17:37:20 +0300 Dan Carpenter wrote: > The "location" is controlled by the user via the ethtool_set_rxnfc() > function. This update_cls_rule() function checks for array overflows > but it doesn't check if the value is negative. I have changed the type > to unsigned to prevent array underflows. > > Fixes: afb90dbb5f78 ("dpaa2-eth: Add ethtool support for flow classification") > Signed-off-by: Dan Carpenter Applied, thank you! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Date: Sat, 09 May 2020 01:46:27 +0000 Subject: Re: [PATCH net] dpaa2-eth: prevent array underflow in update_cls_rule() Message-Id: <20200508184627.70e76aa3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> List-Id: References: <20200508143720.GA410645@mwanda> In-Reply-To: <20200508143720.GA410645@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Ioana Ciornei , Ioana Radulescu , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On Fri, 8 May 2020 17:37:20 +0300 Dan Carpenter wrote: > The "location" is controlled by the user via the ethtool_set_rxnfc() > function. This update_cls_rule() function checks for array overflows > but it doesn't check if the value is negative. I have changed the type > to unsigned to prevent array underflows. > > Fixes: afb90dbb5f78 ("dpaa2-eth: Add ethtool support for flow classification") > Signed-off-by: Dan Carpenter Applied, thank you!