All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "luobin (L)" <luobin9@huawei.com>
Cc: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>, <luoxianjun@huawei.com>,
	<yin.yinshi@huawei.com>, <cloud.wangxiaoyun@huawei.com>
Subject: Re: [PATCH net-next v1] hinic: add three net_device_ops of vf
Date: Fri, 8 May 2020 20:10:04 -0700	[thread overview]
Message-ID: <20200508201004.0e2dc608@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <5253fd74-220d-d841-2bba-e9af98dbb1ba@huawei.com>

On Sat, 9 May 2020 10:56:55 +0800 luobin (L) wrote:
> >> -	if (!HINIC_IS_VF(nic_dev->hwdev->hwif))
> >> -		/* Wait up to 3 sec between port enable to link state */
> >> -		msleep(3000);  
> > Why is this no longer needed?
> > ---When phsical port links up, hw will notify this event to hinic driver.Driver code can  
> 
> handle this event now, so need to wait for link up in hinic_open().

Makes sense.

      parent reply	other threads:[~2020-05-09  3:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 18:21 [PATCH net-next v1] hinic: add three net_device_ops of vf Luo bin
2020-05-08 21:36 ` Jakub Kicinski
2020-05-09  2:13   ` luobin (L)
2020-05-08 21:38 ` Jakub Kicinski
2020-05-08 21:49 ` Jakub Kicinski
     [not found]   ` <5253fd74-220d-d841-2bba-e9af98dbb1ba@huawei.com>
2020-05-09  3:10     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200508201004.0e2dc608@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luobin9@huawei.com \
    --cc=luoxianjun@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=yin.yinshi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.