All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Matteo Croce <mcroce@redhat.com>
Cc: David Miller <davem@davemloft.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net v2 0/2] Fix 88x3310 leaving power save mode
Date: Fri, 8 May 2020 22:38:16 +0100	[thread overview]
Message-ID: <20200508213816.GY1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAGnkfhw45WBjaYFcrO=vK0pbYvhzan970vtxVj8urexhh=WU_A@mail.gmail.com>

On Fri, May 08, 2020 at 11:32:39PM +0200, Matteo Croce wrote:
> On Wed, Apr 15, 2020 at 1:48 AM David Miller <davem@davemloft.net> wrote:
> >
> > From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
> > Date: Tue, 14 Apr 2020 20:47:53 +0100
> >
> > > This series fixes a problem with the 88x3310 PHY on Macchiatobin
> > > coming out of powersave mode noticed by Matteo Croce.  It seems
> > > that certain PHY firmwares do not properly exit powersave mode,
> > > resulting in a fibre link not coming up.
> > >
> > > The solution appears to be to soft-reset the PHY after clearing
> > > the powersave bit.
> > >
> > > We add support for reporting the PHY firmware version to the kernel
> > > log, and use it to trigger this new behaviour if we have v0.3.x.x
> > > or more recent firmware on the PHY.  This, however, is a guess as
> > > the firmware revision documentation does not mention this issue,
> > > and we know that v0.2.1.0 works without this fix but v0.3.3.0 and
> > > later does not.
> >
> > Series applied, thanks.
> >
> 
> Hi,
> 
> should we queue this to -stable?
> The 10 gbit ports don't work without this fix.

It has a "Fixes:" tag, so it should be backported automatically.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up

  reply	other threads:[~2020-05-08 21:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 19:47 [PATCH net v2 0/2] Fix 88x3310 leaving power save mode Russell King - ARM Linux admin
2020-04-14 19:49 ` [PATCH net v2 1/2] net: marvell10g: report firmware version Russell King
2020-04-14 19:52   ` Andrew Lunn
2020-04-14 21:06   ` Florian Fainelli
2020-04-14 19:49 ` [PATCH net v2 2/2] net: marvell10g: soft-reset the PHY when coming out of low power Russell King
2020-04-14 21:06   ` Florian Fainelli
2020-04-14 23:48 ` [PATCH net v2 0/2] Fix 88x3310 leaving power save mode David Miller
2020-05-08 21:32   ` Matteo Croce
2020-05-08 21:38     ` Russell King - ARM Linux admin [this message]
2020-05-09  6:36       ` Greg Kroah-Hartman
2020-05-09  7:32         ` Russell King - ARM Linux admin
2020-05-09  7:42           ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200508213816.GY1551@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=mcroce@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.