From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: nsaenzjulienne@suse.de, wahrenst@gmx.net,
m.szyprowski@samsung.com, Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Tal Gilboa <talgi@mellanox.com>,
Michael Chan <michael.chan@broadcom.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Andy Gospodarek <gospo@broadcom.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net] net: broadcom: Imply BROADCOM_PHY for BCMGENET
Date: Fri, 8 May 2020 15:32:10 -0700 [thread overview]
Message-ID: <20200508223216.6611-1-f.fainelli@gmail.com> (raw)
The GENET controller on the Raspberry Pi 4 (2711) is typically
interfaced with an external Broadcom PHY via a RGMII electrical
interface. To make sure that delays are properly configured at the PHY
side, ensure that we get a chance to have the dedicated Broadcom PHY
driver (CONFIG_BROADCOM_PHY) enabled for this to happen.
Fixes: 402482a6a78e ("net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
David,
I would like Marek to indicate whether he is okay or not with this
change. Thanks!
drivers/net/ethernet/broadcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index 53055ce5dfd6..8a70b9152f7c 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -69,6 +69,7 @@ config BCMGENET
select BCM7XXX_PHY
select MDIO_BCM_UNIMAC
select DIMLIB
+ imply BROADCOM_PHY if ARCH_BCM2835
help
This driver supports the built-in Ethernet MACs found in the
Broadcom BCM7xxx Set Top Box family chipset.
--
2.17.1
next reply other threads:[~2020-05-08 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200508223228eucas1p252dd643b4bedf08126cf6af4788f9b01@eucas1p2.samsung.com>
2020-05-08 22:32 ` Florian Fainelli [this message]
2020-05-09 7:38 ` [PATCH net] net: broadcom: Imply BROADCOM_PHY for BCMGENET Geert Uytterhoeven
2020-05-09 17:12 ` Florian Fainelli
2020-05-10 10:02 ` Geert Uytterhoeven
2020-05-11 7:21 ` Marek Szyprowski
2020-05-11 18:19 ` Florian Fainelli
2020-05-12 6:00 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508223216.6611-1-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=gospo@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=rdunlap@infradead.org \
--cc=talgi@mellanox.com \
--cc=tglx@linutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.