From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 8 May 2020 18:59:22 -0400 Subject: [PATCH 2/4] sata: ahsata: Fix wrong operand for checking SERR DIAG_X In-Reply-To: <20200503142703.14903-2-peng.fan@nxp.com> References: <20200503142703.14903-1-peng.fan@nxp.com> <20200503142703.14903-2-peng.fan@nxp.com> Message-ID: <20200508225922.GW12564@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, May 03, 2020 at 10:27:01PM +0800, Peng Fan wrote: > From: Ye Li > > Fix coverity issue CID 3261683: Wrong operator used > (CONSTANT_EXPRESSION_RESULT) operator_confusion: > ({...; __v;}) | 67108864 is always 1/true regardless of the values > of its operand. This occurs as the logical operand of ! > > When DIAG_X is set, the PHY COMINIT signal is detected, so > should use '&' to check whether it is set. > > Signed-off-by: Ye Li > Signed-off-by: Peng Fan > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: