All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] power: bq25890: unlock on error paths in bq25890_resume()
Date: Sat, 09 May 2020 00:15:29 +0000	[thread overview]
Message-ID: <20200509001529.vikzemeiifyfp4fs@earth.universe> (raw)
In-Reply-To: <20200506122019.GB18376@qmqm.qmqm.pl>

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

Hi,

On Wed, May 06, 2020 at 02:20:20PM +0200, Michał Mirosław wrote:
> On Wed, May 06, 2020 at 01:11:16PM +0300, Dan Carpenter wrote:
> > We introduced some new locking here, but need to update the error
> > paths so they unlock before returning.
> 
> Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Thanks, queued.

-- Sebastian

> > Fixes: 72d9cd9cdc18 ("power: bq25890: protect view of the chip's state")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> >  drivers/power/supply/bq25890_charger.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
> > index 9339e216651ff..20b9824ef5acd 100644
> > --- a/drivers/power/supply/bq25890_charger.c
> > +++ b/drivers/power/supply/bq25890_charger.c
> > @@ -978,21 +978,22 @@ static int bq25890_resume(struct device *dev)
> >  
> >  	ret = bq25890_get_chip_state(bq, &bq->state);
> >  	if (ret < 0)
> > -		return ret;
> > +		goto unlock;
> >  
> >  	/* Re-enable ADC only if charger is plugged in. */
> >  	if (bq->state.online) {
> >  		ret = bq25890_field_write(bq, F_CONV_START, 1);
> >  		if (ret < 0)
> > -			return ret;
> > +			goto unlock;
> >  	}
> >  
> >  	/* signal userspace, maybe state changed while suspended */
> >  	power_supply_changed(bq->charger);
> >  
> > +unlock:
> >  	mutex_unlock(&bq->lock);
> >  
> > -	return 0;
> > +	return ret;
> >  }
> >  #endif
> >  
> > -- 
> > 2.26.2
> > 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] power: bq25890: unlock on error paths in bq25890_resume()
Date: Sat, 9 May 2020 02:15:29 +0200	[thread overview]
Message-ID: <20200509001529.vikzemeiifyfp4fs@earth.universe> (raw)
In-Reply-To: <20200506122019.GB18376@qmqm.qmqm.pl>

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

Hi,

On Wed, May 06, 2020 at 02:20:20PM +0200, Michał Mirosław wrote:
> On Wed, May 06, 2020 at 01:11:16PM +0300, Dan Carpenter wrote:
> > We introduced some new locking here, but need to update the error
> > paths so they unlock before returning.
> 
> Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Thanks, queued.

-- Sebastian

> > Fixes: 72d9cd9cdc18 ("power: bq25890: protect view of the chip's state")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> >  drivers/power/supply/bq25890_charger.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
> > index 9339e216651ff..20b9824ef5acd 100644
> > --- a/drivers/power/supply/bq25890_charger.c
> > +++ b/drivers/power/supply/bq25890_charger.c
> > @@ -978,21 +978,22 @@ static int bq25890_resume(struct device *dev)
> >  
> >  	ret = bq25890_get_chip_state(bq, &bq->state);
> >  	if (ret < 0)
> > -		return ret;
> > +		goto unlock;
> >  
> >  	/* Re-enable ADC only if charger is plugged in. */
> >  	if (bq->state.online) {
> >  		ret = bq25890_field_write(bq, F_CONV_START, 1);
> >  		if (ret < 0)
> > -			return ret;
> > +			goto unlock;
> >  	}
> >  
> >  	/* signal userspace, maybe state changed while suspended */
> >  	power_supply_changed(bq->charger);
> >  
> > +unlock:
> >  	mutex_unlock(&bq->lock);
> >  
> > -	return 0;
> > +	return ret;
> >  }
> >  #endif
> >  
> > -- 
> > 2.26.2
> > 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-05-09  0:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 10:11 [PATCH] power: bq25890: unlock on error paths in bq25890_resume() Dan Carpenter
2020-05-06 10:11 ` Dan Carpenter
2020-05-06 12:20 ` Michał Mirosław
2020-05-06 12:20   ` Michał Mirosław
2020-05-09  0:15   ` Sebastian Reichel [this message]
2020-05-09  0:15     ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200509001529.vikzemeiifyfp4fs@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.