All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: jeyu@kernel.org
Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org,
	mingo@redhat.com, aquini@redhat.com, cai@lca.pw,
	dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org,
	tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com,
	tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com,
	keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org,
	mchehab+samsung@kernel.org, kvalo@codeaurora.org,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>,
	Vishal Kulkarni <vishal@chelsio.com>
Subject: [PATCH 07/15] cxgb4: use new module_firmware_crashed()
Date: Sat,  9 May 2020 04:35:44 +0000	[thread overview]
Message-ID: <20200509043552.8745-8-mcgrof@kernel.org> (raw)
In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org>

This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.

Using a taint flag allows us to annotate when this happens clearly.

Cc: Vishal Kulkarni <vishal@chelsio.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index a70018f067aa..c67fc86c0e42 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -3646,6 +3646,7 @@ void t4_fatal_err(struct adapter *adap)
 	 * could be exposed to the adapter.  RDMA MWs for example...
 	 */
 	t4_shutdown_adapter(adap);
+	module_firmware_crashed();
 	for_each_port(adap, port) {
 		struct net_device *dev = adap->port[port];
 
-- 
2.25.1


  parent reply	other threads:[~2020-05-09  4:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  4:35 [PATCH 00/15] net: taint when the device driver firmware crashes Luis Chamberlain
2020-05-09  4:35 ` [PATCH 01/15] taint: add module firmware crash taint support Luis Chamberlain
2020-05-09 15:18   ` Rafael Aquini
2020-05-09 16:46     ` Luis Chamberlain
2020-05-10  2:19       ` Randy Dunlap
2020-05-09  4:35 ` [PATCH 02/15] ethernet/839: use new module_firmware_crashed() Luis Chamberlain
2020-05-09  4:35 ` [PATCH 03/15] bnx2x: " Luis Chamberlain
2020-05-09  4:35 ` [PATCH 04/15] bnxt: " Luis Chamberlain
2020-05-09  4:35 ` [PATCH 05/15] bna: " Luis Chamberlain
2020-05-09  4:35 ` [PATCH 06/15] liquidio: " Luis Chamberlain
2020-05-09  4:35 ` Luis Chamberlain [this message]
2020-05-09  4:35 ` [PATCH 08/15] ehea: " Luis Chamberlain
2020-05-09  4:35 ` [PATCH 09/15] qed: " Luis Chamberlain
2020-05-09  6:32   ` [EXT] " Igor Russkikh
2020-05-09 16:42     ` Luis Chamberlain
2020-05-12 16:23       ` Igor Russkikh
2020-05-12 17:34         ` Luis Chamberlain
2020-05-14 14:53           ` Igor Russkikh
2020-05-15 20:32             ` Luis Chamberlain
2020-05-15 20:37               ` Igor Russkikh
2020-05-09  4:35 ` [PATCH 10/15] soc: qcom: ipa: " Luis Chamberlain
2020-05-09  4:35 ` [PATCH 11/15] wimax/i2400m: " Luis Chamberlain
2020-05-09  4:35 ` [PATCH 12/15] ath10k: " Luis Chamberlain
2020-05-09  4:35   ` Luis Chamberlain
2020-05-09  4:35 ` [PATCH 13/15] ath6kl: " Luis Chamberlain
2020-05-09  4:35   ` Luis Chamberlain
2020-05-09  4:35 ` [PATCH 14/15] brcm80211: " Luis Chamberlain
2020-05-09  4:35 ` [PATCH 15/15] mwl8k: " Luis Chamberlain
2020-05-09 18:35 ` [PATCH 00/15] net: taint when the device driver firmware crashes Jakub Kicinski
2020-05-11 14:11   ` Luis Chamberlain
2020-05-10  1:01 ` Shannon Nelson
2020-05-10  1:58   ` Andrew Lunn
2020-05-10  2:15     ` Shannon Nelson
2020-05-11 14:13       ` Luis Chamberlain
2020-05-11 19:21   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200509043552.8745-8-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=aquini@redhat.com \
    --cc=arnd@arndb.de \
    --cc=bhe@redhat.com \
    --cc=cai@lca.pw \
    --cc=daniel.vetter@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=dyoung@redhat.com \
    --cc=gpiccoli@canonical.com \
    --cc=jeyu@kernel.org \
    --cc=keescook@chromium.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=schlad@suse.de \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.de \
    --cc=vishal@chelsio.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.