From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7077C54E49 for ; Sat, 9 May 2020 14:16:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFC4721655 for ; Sat, 9 May 2020 14:16:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727989AbgEIOQq (ORCPT ); Sat, 9 May 2020 10:16:46 -0400 Received: from asav22.altibox.net ([109.247.116.9]:34102 "EHLO asav22.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727840AbgEIOQp (ORCPT ); Sat, 9 May 2020 10:16:45 -0400 Received: from localhost.localdomain (unknown [81.166.168.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: noralf.tronnes@ebnett.no) by asav22.altibox.net (Postfix) with ESMTPSA id 90EB22016D; Sat, 9 May 2020 16:16:42 +0200 (CEST) From: =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= To: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, lee.jones@linaro.org Cc: sam@ravnborg.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= Subject: [PATCH v2 03/10] drm/client: Add drm_client_framebuffer_flush() Date: Sat, 9 May 2020 16:16:12 +0200 Message-Id: <20200509141619.32970-4-noralf@tronnes.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200509141619.32970-1-noralf@tronnes.org> References: <20200509141619.32970-1-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=R7It5+ZX c=1 sm=1 tr=0 a=OYZzhG0JTxDrWp/F2OJbnw==:117 a=OYZzhG0JTxDrWp/F2OJbnw==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=7gkXJVJtAAAA:8 a=SJz97ENfAAAA:8 a=0jVh_8K4HvQRDTyCFMcA:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=vFet0B0WnEQeilDPIY6i:22 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Some drivers need explicit flushing of buffer changes, add a function that does that. v2: - Put all clip rect stuff inside if statement (Sam) Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c | 33 +++++++++++++++++++++++++++++++++ include/drm/drm_client.h | 1 + 2 files changed, 34 insertions(+) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index 12787915db01..827ee6422dd2 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -483,6 +483,39 @@ void drm_client_framebuffer_delete(struct drm_client_buffer *buffer) } EXPORT_SYMBOL(drm_client_framebuffer_delete); +/** + * drm_client_framebuffer_flush - Manually flush client framebuffer + * @buffer: DRM client buffer (can be NULL) + * @rect: Damage rectangle (if NULL flushes all) + * + * This calls &drm_framebuffer_funcs->dirty (if present) to flush buffer changes + * for drivers that need it. + * + * Returns: + * Zero on success or negative error code on failure. + */ +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect) +{ + if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty) + return 0; + + if (rect) { + struct drm_clip_rect clip = { + .x1 = rect->x1, + .y1 = rect->y1, + .x2 = rect->x2, + .y2 = rect->y2, + }; + + return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file, + 0, 0, &clip, 1); + } + + return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file, + 0, 0, NULL, 0); +} +EXPORT_SYMBOL(drm_client_framebuffer_flush); + #ifdef CONFIG_DEBUG_FS static int drm_client_debugfs_internal_clients(struct seq_file *m, void *data) { diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h index 96ebc7523aa0..9737dd7b147f 100644 --- a/include/drm/drm_client.h +++ b/include/drm/drm_client.h @@ -156,6 +156,7 @@ struct drm_client_buffer { struct drm_client_buffer * drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format); void drm_client_framebuffer_delete(struct drm_client_buffer *buffer); +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect); void *drm_client_buffer_vmap(struct drm_client_buffer *buffer); void drm_client_buffer_vunmap(struct drm_client_buffer *buffer); -- 2.23.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF06C47247 for ; Sat, 9 May 2020 14:16:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98C2821473 for ; Sat, 9 May 2020 14:16:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98C2821473 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tronnes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF72B6E086; Sat, 9 May 2020 14:16:45 +0000 (UTC) Received: from asav22.altibox.net (asav22.altibox.net [109.247.116.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C59B6E356 for ; Sat, 9 May 2020 14:16:44 +0000 (UTC) Received: from localhost.localdomain (unknown [81.166.168.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: noralf.tronnes@ebnett.no) by asav22.altibox.net (Postfix) with ESMTPSA id 90EB22016D; Sat, 9 May 2020 16:16:42 +0200 (CEST) From: =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= To: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, lee.jones@linaro.org Subject: [PATCH v2 03/10] drm/client: Add drm_client_framebuffer_flush() Date: Sat, 9 May 2020 16:16:12 +0200 Message-Id: <20200509141619.32970-4-noralf@tronnes.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200509141619.32970-1-noralf@tronnes.org> References: <20200509141619.32970-1-noralf@tronnes.org> MIME-Version: 1.0 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=R7It5+ZX c=1 sm=1 tr=0 a=OYZzhG0JTxDrWp/F2OJbnw==:117 a=OYZzhG0JTxDrWp/F2OJbnw==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=7gkXJVJtAAAA:8 a=SJz97ENfAAAA:8 a=0jVh_8K4HvQRDTyCFMcA:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=vFet0B0WnEQeilDPIY6i:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jingoohan1@gmail.com, daniel.thompson@linaro.org, sam@ravnborg.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" U29tZSBkcml2ZXJzIG5lZWQgZXhwbGljaXQgZmx1c2hpbmcgb2YgYnVmZmVyIGNoYW5nZXMsIGFk ZCBhIGZ1bmN0aW9uCnRoYXQgZG9lcyB0aGF0LgoKdjI6Ci0gUHV0IGFsbCBjbGlwIHJlY3Qgc3R1 ZmYgaW5zaWRlIGlmIHN0YXRlbWVudCAoU2FtKQoKUmV2aWV3ZWQtYnk6IFNhbSBSYXZuYm9yZyA8 c2FtQHJhdm5ib3JnLm9yZz4KU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxub3JhbGZA dHJvbm5lcy5vcmc+Ci0tLQogZHJpdmVycy9ncHUvZHJtL2RybV9jbGllbnQuYyB8IDMzICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKwogaW5jbHVkZS9kcm0vZHJtX2NsaWVudC5oICAg ICB8ICAxICsKIDIgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fY2xpZW50LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NsaWVu dC5jCmluZGV4IDEyNzg3OTE1ZGIwMS4uODI3ZWU2NDIyZGQyIDEwMDY0NAotLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2NsaWVudC5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY2xpZW50LmMK QEAgLTQ4Myw2ICs0ODMsMzkgQEAgdm9pZCBkcm1fY2xpZW50X2ZyYW1lYnVmZmVyX2RlbGV0ZShz dHJ1Y3QgZHJtX2NsaWVudF9idWZmZXIgKmJ1ZmZlcikKIH0KIEVYUE9SVF9TWU1CT0woZHJtX2Ns aWVudF9mcmFtZWJ1ZmZlcl9kZWxldGUpOwogCisvKioKKyAqIGRybV9jbGllbnRfZnJhbWVidWZm ZXJfZmx1c2ggLSBNYW51YWxseSBmbHVzaCBjbGllbnQgZnJhbWVidWZmZXIKKyAqIEBidWZmZXI6 IERSTSBjbGllbnQgYnVmZmVyIChjYW4gYmUgTlVMTCkKKyAqIEByZWN0OiBEYW1hZ2UgcmVjdGFu Z2xlIChpZiBOVUxMIGZsdXNoZXMgYWxsKQorICoKKyAqIFRoaXMgY2FsbHMgJmRybV9mcmFtZWJ1 ZmZlcl9mdW5jcy0+ZGlydHkgKGlmIHByZXNlbnQpIHRvIGZsdXNoIGJ1ZmZlciBjaGFuZ2VzCisg KiBmb3IgZHJpdmVycyB0aGF0IG5lZWQgaXQuCisgKgorICogUmV0dXJuczoKKyAqIFplcm8gb24g c3VjY2VzcyBvciBuZWdhdGl2ZSBlcnJvciBjb2RlIG9uIGZhaWx1cmUuCisgKi8KK2ludCBkcm1f Y2xpZW50X2ZyYW1lYnVmZmVyX2ZsdXNoKHN0cnVjdCBkcm1fY2xpZW50X2J1ZmZlciAqYnVmZmVy LCBzdHJ1Y3QgZHJtX3JlY3QgKnJlY3QpCit7CisJaWYgKCFidWZmZXIgfHwgIWJ1ZmZlci0+ZmIg fHwgIWJ1ZmZlci0+ZmItPmZ1bmNzLT5kaXJ0eSkKKwkJcmV0dXJuIDA7CisKKwlpZiAocmVjdCkg eworCQlzdHJ1Y3QgZHJtX2NsaXBfcmVjdCBjbGlwID0geworCQkJLngxID0gcmVjdC0+eDEsCisJ CQkueTEgPSByZWN0LT55MSwKKwkJCS54MiA9IHJlY3QtPngyLAorCQkJLnkyID0gcmVjdC0+eTIs CisJCX07CisKKwkJcmV0dXJuIGJ1ZmZlci0+ZmItPmZ1bmNzLT5kaXJ0eShidWZmZXItPmZiLCBi dWZmZXItPmNsaWVudC0+ZmlsZSwKKwkJCQkJCTAsIDAsICZjbGlwLCAxKTsKKwl9CisKKwlyZXR1 cm4gYnVmZmVyLT5mYi0+ZnVuY3MtPmRpcnR5KGJ1ZmZlci0+ZmIsIGJ1ZmZlci0+Y2xpZW50LT5m aWxlLAorCQkJCQkwLCAwLCBOVUxMLCAwKTsKK30KK0VYUE9SVF9TWU1CT0woZHJtX2NsaWVudF9m cmFtZWJ1ZmZlcl9mbHVzaCk7CisKICNpZmRlZiBDT05GSUdfREVCVUdfRlMKIHN0YXRpYyBpbnQg ZHJtX2NsaWVudF9kZWJ1Z2ZzX2ludGVybmFsX2NsaWVudHMoc3RydWN0IHNlcV9maWxlICptLCB2 b2lkICpkYXRhKQogewpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2NsaWVudC5oIGIvaW5j bHVkZS9kcm0vZHJtX2NsaWVudC5oCmluZGV4IDk2ZWJjNzUyM2FhMC4uOTczN2RkN2IxNDdmIDEw MDY0NAotLS0gYS9pbmNsdWRlL2RybS9kcm1fY2xpZW50LmgKKysrIGIvaW5jbHVkZS9kcm0vZHJt X2NsaWVudC5oCkBAIC0xNTYsNiArMTU2LDcgQEAgc3RydWN0IGRybV9jbGllbnRfYnVmZmVyIHsK IHN0cnVjdCBkcm1fY2xpZW50X2J1ZmZlciAqCiBkcm1fY2xpZW50X2ZyYW1lYnVmZmVyX2NyZWF0 ZShzdHJ1Y3QgZHJtX2NsaWVudF9kZXYgKmNsaWVudCwgdTMyIHdpZHRoLCB1MzIgaGVpZ2h0LCB1 MzIgZm9ybWF0KTsKIHZvaWQgZHJtX2NsaWVudF9mcmFtZWJ1ZmZlcl9kZWxldGUoc3RydWN0IGRy bV9jbGllbnRfYnVmZmVyICpidWZmZXIpOworaW50IGRybV9jbGllbnRfZnJhbWVidWZmZXJfZmx1 c2goc3RydWN0IGRybV9jbGllbnRfYnVmZmVyICpidWZmZXIsIHN0cnVjdCBkcm1fcmVjdCAqcmVj dCk7CiB2b2lkICpkcm1fY2xpZW50X2J1ZmZlcl92bWFwKHN0cnVjdCBkcm1fY2xpZW50X2J1ZmZl ciAqYnVmZmVyKTsKIHZvaWQgZHJtX2NsaWVudF9idWZmZXJfdnVubWFwKHN0cnVjdCBkcm1fY2xp ZW50X2J1ZmZlciAqYnVmZmVyKTsKIAotLSAKMi4yMy4wCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK