From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64DA9C28CBC for ; Sat, 9 May 2020 16:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B8AD21582 for ; Sat, 9 May 2020 16:57:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="meXD+qHT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728182AbgEIQ47 (ORCPT ); Sat, 9 May 2020 12:56:59 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51096 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727863AbgEIQ47 (ORCPT ); Sat, 9 May 2020 12:56:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=c1EdFOtJK8exrDN02KMPnX4sfvNbsWPWPXGrPUo74Es=; b=meXD+qHTHJzx5MeF/i522YUqr1 RxzIaNWNAOqqOFWPw7uMfEdYA9x7yL0nRpy6UN+txn4i1ToZOckdUER8fLY4FUFnesDo+G3u2yEJk DZDEO6nGG8kdvT4rHWtNMl7AMCDE1xcLL6WfrY4Xwfhg2Hn/M3Fn8rAwQ9gDGLnop1Nc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jXSmW-001WVm-GE; Sat, 09 May 2020 18:56:56 +0200 Date: Sat, 9 May 2020 18:56:56 +0200 From: Andrew Lunn To: Michael Grzeschik Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, davem@davemloft.net, kernel@pengutronix.de Subject: Re: [PATCH v3 4/5] ksz: Add Microchip KSZ8863 SMI/SPI based driver support Message-ID: <20200509165656.GB362499@lunn.ch> References: <20200508154343.6074-1-m.grzeschik@pengutronix.de> <20200508154343.6074-5-m.grzeschik@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508154343.6074-5-m.grzeschik@pengutronix.de> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 08, 2020 at 05:43:42PM +0200, Michael Grzeschik wrote: > Add KSZ88X3 driver support. We add support for the KXZ88X3 three port > switches using the Microchip SMI Interface. They are currently only > supported using the MDIO-Bitbang Interface. Which is making use of the > mdio_ll_read/write functions. The patch uses the common functions > from the ksz8795 driver. This patch is pretty hard to review. It is huge, and making multiple changes all at once. Please break it up into a number of smaller changes. Andrew