From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A05FC28CBC for ; Sat, 9 May 2020 17:12:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15ED02184D for ; Sat, 9 May 2020 17:12:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728101AbgEIRMu (ORCPT ); Sat, 9 May 2020 13:12:50 -0400 Received: from verein.lst.de ([213.95.11.211]:57527 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbgEIRMu (ORCPT ); Sat, 9 May 2020 13:12:50 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id D403E68C7B; Sat, 9 May 2020 19:12:47 +0200 (CEST) Date: Sat, 9 May 2020 19:12:47 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 5/8] db: validate name and namelen in attr_set_f and attr_remove_f Message-ID: <20200509171247.GA31924@lst.de> References: <20200509170125.952508-1-hch@lst.de> <20200509170125.952508-6-hch@lst.de> <20200509170909.GS6714@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200509170909.GS6714@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sat, May 09, 2020 at 10:09:09AM -0700, Darrick J. Wong wrote: > On Sat, May 09, 2020 at 07:01:22PM +0200, Christoph Hellwig wrote: > > libxfs has stopped validating these parameters internally, so do it > > in the xfs_db commands. > > > > Signed-off-by: Christoph Hellwig > > IIRC the VFS checks these parameters so that libxfs doesn't have to, > right? Yes. But we don't have the VFS in xfsprogs :)