From: Stephen Kitt <steve@sk2.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Joe Perches <joe@perches.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures
Date: Sat, 9 May 2020 22:49:28 +0200 [thread overview]
Message-ID: <20200509224928.26d44ac4@heffalump.sk2.org> (raw)
In-Reply-To: <20200509210548.116c7385@heffalump.sk2.org>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
On Sat, 9 May 2020 21:05:48 +0200, Stephen Kitt <steve@sk2.org> wrote:
> On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski <kuba@kernel.org> wrote:
> > What if we went back to your original proposal of an empty struct but
> > added in an extern in front? That way we should get linker error on
> > pointer references.
>
> That silently fails to fail if any other link object provides a definition
> for the symbol, even if the type doesn’t match...
And it breaks the build if INET_ADDR_COOKIE is used twice in the same unit,
e.g. in inet_hashtables.c.
Regards,
Stephen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-09 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 12:04 [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures Stephen Kitt
2020-05-09 3:50 ` Jakub Kicinski
2020-05-09 8:13 ` Stephen Kitt
2020-05-09 17:59 ` Jakub Kicinski
2020-05-09 19:05 ` Stephen Kitt
2020-05-09 20:49 ` Stephen Kitt [this message]
2020-05-09 22:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509224928.26d44ac4@heffalump.sk2.org \
--to=steve@sk2.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.