All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Hongbo Yao <yaohongbo@huawei.com>
Cc: chenzhou10@huawei.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH -next] power: reset: ltc2952: remove set but used variable
Date: Sun, 10 May 2020 01:42:01 +0200	[thread overview]
Message-ID: <20200509234201.md2veh4cxkdwoj2h@earth.universe> (raw)
In-Reply-To: <20200509103611.29551-1-yaohongbo@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]

Hi,

On Sat, May 09, 2020 at 06:36:11PM +0800, Hongbo Yao wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable
> ‘overruns’ set but not used [-Wunused-but-set-variable]
>   unsigned long overruns;
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/reset/ltc2952-poweroff.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/ltc2952-poweroff.c
> index e4a0cc45b3d1..318927938b05 100644
> --- a/drivers/power/reset/ltc2952-poweroff.c
> +++ b/drivers/power/reset/ltc2952-poweroff.c
> @@ -94,7 +94,6 @@ static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
>  {
>  	ktime_t now;
>  	int state;
> -	unsigned long overruns;
>  	struct ltc2952_poweroff *data = to_ltc2952(timer, timer_wde);
>  
>  	if (data->kernel_panic)
> @@ -104,7 +103,7 @@ static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
>  	gpiod_set_value(data->gpio_watchdog, !state);
>  
>  	now = hrtimer_cb_get_time(timer);
> -	overruns = hrtimer_forward(timer, now, data->wde_interval);
> +	hrtimer_forward(timer, now, data->wde_interval);
>  
>  	return HRTIMER_RESTART;
>  }
> -- 
> 2.20.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-05-09 23:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 10:36 [PATCH -next] power: reset: ltc2952: remove set but used variable Hongbo Yao
2020-05-09 23:42 ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200509234201.md2veh4cxkdwoj2h@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=chenzhou10@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=yaohongbo@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.