All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>, Joerg Roedel <joro@8bytes.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konradybcio@gmail.com>,
	linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu/qcom: add optional clock for TLB invalidate
Date: Sun, 10 May 2020 22:30:21 +0800	[thread overview]
Message-ID: <20200510143020.GA16939@dragon> (raw)
In-Reply-To: <e8150781-6000-dedc-ca10-6cee232c4364@linaro.org>

Hi Stanimir,

On Sat, May 09, 2020 at 04:21:20PM +0300, Stanimir Varbanov wrote:
...
> > @@ -839,6 +849,12 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
> >  		return PTR_ERR(qcom_iommu->bus_clk);
> >  	}
> >  
> > +	qcom_iommu->tlb_clk = devm_clk_get(dev, "tlb");
> 
> IMO, devm_clk_get_optional() would be better.

Yes, indeed.  The function will make it clear that the clock is
an optional one.  I will make the change in v2.

Thanks for the comment!

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@linaro.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
	Konrad Dybcio <konradybcio@gmail.com>,
	iommu@lists.linux-foundation.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>
Subject: Re: [PATCH] iommu/qcom: add optional clock for TLB invalidate
Date: Sun, 10 May 2020 22:30:21 +0800	[thread overview]
Message-ID: <20200510143020.GA16939@dragon> (raw)
In-Reply-To: <e8150781-6000-dedc-ca10-6cee232c4364@linaro.org>

Hi Stanimir,

On Sat, May 09, 2020 at 04:21:20PM +0300, Stanimir Varbanov wrote:
...
> > @@ -839,6 +849,12 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
> >  		return PTR_ERR(qcom_iommu->bus_clk);
> >  	}
> >  
> > +	qcom_iommu->tlb_clk = devm_clk_get(dev, "tlb");
> 
> IMO, devm_clk_get_optional() would be better.

Yes, indeed.  The function will make it clear that the clock is
an optional one.  I will make the change in v2.

Thanks for the comment!

Shawn
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2020-05-10 14:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 13:08 [PATCH] iommu/qcom: add optional clock for TLB invalidate Shawn Guo
2020-05-09 13:08 ` Shawn Guo
2020-05-09 13:21 ` Stanimir Varbanov
2020-05-09 13:21   ` Stanimir Varbanov
2020-05-10 14:30   ` Shawn Guo [this message]
2020-05-10 14:30     ` Shawn Guo
2020-05-12  5:52 ` Bjorn Andersson
2020-05-12  5:52   ` Bjorn Andersson
2020-05-12 18:35   ` Rob Clark
2020-05-12 18:35     ` Rob Clark
2020-05-14 14:39   ` Shawn Guo
2020-05-14 14:39     ` Shawn Guo
2020-05-14 15:15     ` Bjorn Andersson
2020-05-14 15:15       ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200510143020.GA16939@dragon \
    --to=shawn.guo@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=konradybcio@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=stanimir.varbanov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.