All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Chris Healy <cphealy@gmail.com>,
	michael@walle.cc
Subject: Re: [PATCH net-next v3 07/10] net: ethtool: Add helpers for reporting test results
Date: Sun, 10 May 2020 17:16:56 +0200	[thread overview]
Message-ID: <20200510151656.GJ30711@lion.mk-sys.cz> (raw)
In-Reply-To: <20200509162851.362346-8-andrew@lunn.ch>

On Sat, May 09, 2020 at 06:28:48PM +0200, Andrew Lunn wrote:
> The PHY drivers can use these helpers for reporting the results. The
> results get translated into netlink attributes which are added to the
> pre-allocated skbuf.
> 
> v3:
> Poison phydev->skb
> Return -EMSGSIZE when ethnl_bcastmsg_put() fails
> Return valid error code when nla_nest_start() fails
> Use u8 for results
> Actually put u32 length into message
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Reviewed-by: Michal Kubecek <mkubecek@suse.cz>

  reply	other threads:[~2020-05-10 15:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 16:28 [PATCH net-next v3 00/10] Ethernet Cable test support Andrew Lunn
2020-05-09 16:28 ` [PATCH net-next v3 01/10] net: phy: Add cable test support to state machine Andrew Lunn
2020-05-09 16:28 ` [PATCH net-next v3 02/10] net: phy: Add support for polling cable test Andrew Lunn
2020-05-09 16:28 ` [PATCH net-next v3 03/10] net: ethtool: netlink: Add support for triggering a " Andrew Lunn
2020-05-09 16:28 ` [PATCH net-next v3 04/10] net: ethtool: Add attributes for cable test reports Andrew Lunn
2020-05-10 14:53   ` Michal Kubecek
2020-05-09 16:28 ` [PATCH net-next v3 05/10] net: ethtool: Make helpers public Andrew Lunn
2020-05-10 14:54   ` Michal Kubecek
2020-05-09 16:28 ` [PATCH net-next v3 06/10] net: ethtool: Add infrastructure for reporting cable test results Andrew Lunn
2020-05-10 15:12   ` Michal Kubecek
2020-05-10 16:07     ` Andrew Lunn
2020-05-10 18:00       ` Jakub Kicinski
2020-05-10 18:22         ` Andrew Lunn
2020-05-10 18:39           ` Jakub Kicinski
2020-05-09 16:28 ` [PATCH net-next v3 07/10] net: ethtool: Add helpers for reporting " Andrew Lunn
2020-05-10 15:16   ` Michal Kubecek [this message]
2020-05-09 16:28 ` [PATCH net-next v3 08/10] net: phy: marvell: Add cable test support Andrew Lunn
2020-05-09 16:28 ` [PATCH net-next v3 09/10] net: phy: Put interface into oper testing during cable test Andrew Lunn
2020-05-09 16:28 ` [PATCH net-next v3 10/10] net: phy: Send notifier when starting the " Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200510151656.GJ30711@lion.mk-sys.cz \
    --to=mkubecek@suse.cz \
    --cc=andrew@lunn.ch \
    --cc=cphealy@gmail.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=michael@walle.cc \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.