From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA24C54E8A for ; Sun, 10 May 2020 15:39:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4ED1020736 for ; Sun, 10 May 2020 15:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589125187; bh=8h9ahc3Yu0709/yHwkE2qnpvfiOpmtIhCGjy6Ha1M9o=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=0qsF29m9bTKq4yM28o3PCROC6j45cZ7q5P2HYA2N0U6m94jkQ4JbvKcBxil+pgGTp WqQsQI3XRWtp+v+3nxGf2Jqo3DVnyWipCXgjxxiphsjT4Sxirf7OJRg5/vYEbejS6v ZUJYVK5aSkHkZcrnujKtYimxa7rlyiT09W28LOKQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729028AbgEJPjq (ORCPT ); Sun, 10 May 2020 11:39:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:42638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbgEJPjq (ORCPT ); Sun, 10 May 2020 11:39:46 -0400 Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6AC1620735; Sun, 10 May 2020 15:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589125185; bh=8h9ahc3Yu0709/yHwkE2qnpvfiOpmtIhCGjy6Ha1M9o=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=Z/QDZ92zpK6sKhzEYZlwOp/G+FioCsnhyCIalaRJRgdje5ZgE25HoOJFdUxNUld2D KP3VckYHwmif+67A24ts5hdCAIRUig7BPsHjZvhiOEvLomLF+bMFB+csYTNEnaWwrr wDCqc6B8ouMc8E0TqDOlYr7iuiDczLLrY1f4uMlA= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 1677535227BD; Sun, 10 May 2020 08:39:45 -0700 (PDT) Date: Sun, 10 May 2020 08:39:45 -0700 From: "Paul E. McKenney" To: Lai Jiangshan Cc: rcu@vger.kernel.org, LKML , kernel-team , Ingo Molnar , dipankar@in.ibm.com, Andrew Morton , Mathieu Desnoyers , Josh Triplett , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , David Howells , Eric Dumazet , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Oleg Nesterov , Joel Fernandes Subject: Re: [PATCH v4 tip/core/rcu 05/38] rcu-tasks: Move Tasks RCU to its own file Message-ID: <20200510153945.GQ2869@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200415181856.GA11037@paulmck-ThinkPad-P72> <20200415181941.11653-5-paulmck@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 10, 2020 at 03:42:52PM +0800, Lai Jiangshan wrote: > On Thu, Apr 16, 2020 at 2:19 AM wrote: > > > > From: "Paul E. McKenney" > > > > This code-movement-only commit is in preparation for adding an additional > > flavor of Tasks RCU, which relies on workqueues to detect grace periods. > > > > Signed-off-by: Paul E. McKenney > > --- > > kernel/rcu/tasks.h | 370 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > kernel/rcu/update.c | 366 +-------------------------------------------------- > > Hello Paul > > Makes it kernel/rcu/tasks.c? > > One of my old patch split it into a c-file, and it did work. > Is there anything new or planed that prevents it to be a c-file? It quite likely could be a c-file, but let's see things play out with your suggestion of replacing Tasks RCU with a check in the scheduler before making such a change. Thanx, Paul > thanks > Lai > > > > > +#include "tasks.h" > > + > > #ifndef CONFIG_TINY_RCU > > > > /* > > -- > > 2.9.5 > >