All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH v2 23/35] acpi: Add support for writing a Power Resource
Date: Sun, 10 May 2020 14:33:57 -0600	[thread overview]
Message-ID: <20200510203409.203520-21-sjg@chromium.org> (raw)
In-Reply-To: <20200510203409.203520-1-sjg@chromium.org>

These are used in ACPI to disable power to various pats of the system when
in sleep. Add a way to create a power resource, with the caller finishing
off the details.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2: None
Changes in v1: None

 include/acpi/acpigen.h | 22 ++++++++++++++++++++++
 lib/acpi/acpigen.c     | 22 ++++++++++++++++++++++
 test/dm/acpigen.c      | 41 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 85 insertions(+)

diff --git a/include/acpi/acpigen.h b/include/acpi/acpigen.h
index c595bb9efa..7d9a02805b 100644
--- a/include/acpi/acpigen.h
+++ b/include/acpi/acpigen.h
@@ -45,6 +45,7 @@ enum {
 	AND_OP			= 0x7b,
 	OR_OP			= 0x7d,
 	NOT_OP			= 0x80,
+	POWER_RES_OP		= 0x84,
 	RETURN_OP		= 0xa4,
 };
 
@@ -310,4 +311,25 @@ void acpigen_write_and(struct acpi_ctx *ctx, u8 arg1, u8 arg2, u8 res);
  */
 void acpigen_write_not(struct acpi_ctx *ctx, u8 arg, u8 res);
 
+/**
+ * acpigen_write_power_res() - Write a power resource
+ *
+ * Name (_PRx, Package(One) { name })
+ * ...
+ * PowerResource (name, level, order)
+ *
+ * The caller should fill in the rest of the power resource and then call
+ * acpigen_pop_len() to close it off
+ *
+ * @ctx: ACPI context pointer
+ * @name: Name of power resource (e.g. "PRIC")
+ * @level: Deepest sleep level that this resource must be kept on (0=S0, 3=S3)
+ * @order: Order that this must be enabled/disabled (e.g. 0)
+ * @dev_stats: List of states to define, e.g. {"_PR0", "_PR3"}
+ * @dev_states_count: Number of dev states
+ */
+void acpigen_write_power_res(struct acpi_ctx *ctx, const char *name, uint level,
+			     uint order, const char *const dev_states[],
+			     size_t dev_states_count);
+
 #endif
diff --git a/lib/acpi/acpigen.c b/lib/acpi/acpigen.c
index 57b295aa4e..824a2c97cd 100644
--- a/lib/acpi/acpigen.c
+++ b/lib/acpi/acpigen.c
@@ -328,6 +328,28 @@ int acpigen_write_uuid(struct acpi_ctx *ctx, const char *uuid)
 	return 0;
 }
 
+void acpigen_write_power_res(struct acpi_ctx *ctx, const char *name, uint level,
+			     uint order, const char *const dev_states[],
+			     size_t dev_states_count)
+{
+	size_t i;
+
+	for (i = 0; i < dev_states_count; i++) {
+		acpigen_write_name(ctx, dev_states[i]);
+		acpigen_write_package(ctx, 1);
+		acpigen_emit_simple_namestring(ctx, name);
+		acpigen_pop_len(ctx);		/* Package */
+	}
+
+	acpigen_emit_ext_op(ctx, POWER_RES_OP);
+
+	acpigen_write_len_f(ctx);
+
+	acpigen_emit_simple_namestring(ctx, name);
+	acpigen_emit_byte(ctx, level);
+	acpigen_emit_word(ctx, order);
+}
+
 /* Sleep (ms) */
 void acpigen_write_sleep(struct acpi_ctx *ctx, u64 sleep_ms)
 {
diff --git a/test/dm/acpigen.c b/test/dm/acpigen.c
index e059d6f80d..c92f6cdb0b 100644
--- a/test/dm/acpigen.c
+++ b/test/dm/acpigen.c
@@ -696,3 +696,44 @@ static int dm_test_acpi_misc(struct unit_test_state *uts)
 	return 0;
 }
 DM_TEST(dm_test_acpi_misc, 0);
+
+/* Test writing an ACPI power resource */
+static int dm_test_acpi_power_res(struct unit_test_state *uts)
+{
+	const char *const states[] = { "_PR0", "_PR3" };
+	const char *name = "PRIC";
+	const int level = 3;
+	const int order = 2;
+	struct acpi_ctx *ctx;
+	u8 *ptr;
+
+	ut_assertok(alloc_context(&ctx));
+
+	ptr = acpigen_get_current(ctx);
+
+	/* PowerResource (PRIC, 0, 0) */
+	acpigen_write_power_res(ctx, name, level, order, states,
+				ARRAY_SIZE(states));
+	ut_asserteq(0x28, acpigen_get_current(ctx) - ptr);
+	ut_asserteq(NAME_OP, ptr[0]);
+	ut_asserteq_strn(states[0], (char *)ptr + 1);
+	ut_asserteq(8, get_length(ptr + 6));
+	ut_asserteq_strn(name, (char *)ptr + 0xa);
+
+	ut_asserteq_strn(states[1], (char *)ptr + 0xf);
+	ut_asserteq(8, get_length(ptr + 0x14));
+	ut_asserteq_strn(name, (char *)ptr + 0x18);
+
+	ut_asserteq(POWER_RES_OP, ptr[0x1d]);
+	ut_asserteq_strn(name, (char *)ptr + 0x21);
+	ut_asserteq(level, ptr[0x25]);
+	ut_asserteq(order, get_unaligned((u16 *)(ptr + 0x26)));
+
+	/* The length is not set - caller must use acpigen_pop_len() */
+	ut_asserteq(1, ctx->ltop);
+
+	free_context(&ctx);
+
+	return 0;
+}
+DM_TEST(dm_test_acpi_power_res, 0);
-- 
2.26.2.645.ge9eca65c58-goog

  parent reply	other threads:[~2020-05-10 20:33 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 20:33 [PATCH v2 00/35] dm: Add programmatic generation of ACPI tables (part B) Simon Glass
2020-05-10 20:33 ` [PATCH v2 01/35] dm: core: Add an ACPI name for the root node Simon Glass
2020-05-17 14:40   ` Bin Meng
2020-05-10 20:33 ` [PATCH v2 02/35] acpi: Add a function to get a device path and scope Simon Glass
2020-05-17 14:54   ` Bin Meng
2020-05-10 20:33 ` [PATCH v2 03/35] acpi: Add a way to check device status Simon Glass
2020-05-10 20:33 ` [PATCH v2 04/35] irq: Add a method to convert an interrupt to ACPI Simon Glass
2020-05-10 20:33 ` [PATCH v2 05/35] acpi: Support generation of ACPI code Simon Glass
2020-05-10 20:33 ` [PATCH v2 06/35] acpi: Support generation of interrupt descriptor Simon Glass
2020-05-10 20:33 ` [PATCH v2 07/35] gpio: Add a method to convert a GPIO to ACPI Simon Glass
2020-05-10 20:33 ` [PATCH v2 08/35] acpi: Support string output Simon Glass
2020-05-10 20:33 ` [PATCH v2 09/35] acpi: Support generation of GPIO descriptor Simon Glass
2020-05-10 20:33 ` [PATCH v2 10/35] acpi: Support generation of a GPIO/irq for a device Simon Glass
2020-05-10 20:33 ` [PATCH v2 11/35] acpi: Support generation of I2C descriptor Simon Glass
2020-05-10 20:33 ` [PATCH v2 12/35] acpi: Support generation of SPI descriptor Simon Glass
2020-05-10 20:33 ` [PATCH v2 13/35] acpigen: Support writing a length Simon Glass
2020-05-10 20:33 ` [PATCH v2 14/35] acpigen: Support writing a package Simon Glass
2020-05-10 20:33 ` [PATCH v2 15/35] acpi: Support writing an integer Simon Glass
2020-05-10 20:33 ` [PATCH v2 16/35] acpi: Support writing a string Simon Glass
2020-05-10 20:33 ` [PATCH v2 17/35] acpi: Support writing a name Simon Glass
2020-05-10 20:33 ` [PATCH v2 18/35] acpi: Support writing a UUID Simon Glass
2020-05-10 20:33 ` [PATCH v2 19/35] acpi: Support writing Device Properties objects via _DSD Simon Glass
2020-05-10 20:33 ` [PATCH v2 20/35] acpi: Support writing a GPIO Simon Glass
2020-05-10 20:33 ` [PATCH v2 21/35] acpi: Support copying properties from device tree to ACPI Simon Glass
2020-05-10 20:33 ` [PATCH v2 22/35] acpi: Add support for various misc ACPI opcodes Simon Glass
2020-05-10 20:33 ` Simon Glass [this message]
2020-05-10 20:33 ` [PATCH v2 24/35] acpi: Add support for writing a GPIO power sequence Simon Glass
2020-05-10 20:33 ` [PATCH v2 25/35] acpi: Add support for a generic " Simon Glass
2020-05-10 20:34 ` [PATCH v2 26/35] acpi: Add support for SSDT generation Simon Glass
2020-05-10 20:34 ` [PATCH v2 27/35] x86: acpi: Move MADT down a bit Simon Glass
2020-05-10 20:34 ` [PATCH v2 28/35] acpi: Record the items added to SSDT Simon Glass
2020-05-10 20:34 ` [PATCH v2 29/35] acpi: Support ordering SSDT data by device Simon Glass
2020-05-10 20:34 ` [PATCH v2 30/35] x86: Allow devices to write an SSDT Simon Glass
2020-05-10 20:34 ` [PATCH v2 31/35] acpi: Add support for DSDT generation Simon Glass
2020-05-10 20:34 ` [PATCH v2 32/35] x86: Allow devices to write to DSDT Simon Glass
2020-05-10 20:34 ` [PATCH v2 33/35] pci: Avoid a crash in device_is_on_pci_bus() Simon Glass
2020-05-10 20:34 ` [PATCH v2 34/35] dm: acpi: Enhance acpi_get_name() Simon Glass
2020-05-10 20:34 ` [PATCH v2 35/35] acpi: Add an acpi split command Simon Glass
2020-05-12  2:13 ` [PATCH v2 00/35] dm: Add programmatic generation of ACPI tables (part B) Bin Meng
2020-05-12 11:55 ` Antwort: " Wolfgang Wallner
2020-05-12 12:32   ` Andy Shevchenko
2020-05-12 23:22     ` Simon Glass
2020-05-13  9:55       ` Andy Shevchenko
2020-05-14 16:02         ` Simon Glass
2020-05-14 16:38           ` Andy Shevchenko
2020-05-13 12:18 ` Antwort: [PATCH v2 03/35] acpi: Add a way to check device status Wolfgang Wallner
2020-05-13 13:01 ` Antwort: [PATCH v2 04/35] irq: Add a method to convert an interrupt to ACPI Wolfgang Wallner
2020-05-14 16:02   ` Simon Glass
2020-05-18  7:47   ` Antwort: " Wolfgang Wallner
2020-05-14  8:32 ` Antwort: [PATCH v2 05/35] acpi: Support generation of ACPI code Wolfgang Wallner
2020-06-09 21:14   ` Simon Glass
2020-06-10  7:33   ` Wolfgang Wallner
2020-06-10  7:39   ` Wolfgang Wallner
2020-05-19  8:14 ` Antwort: [PATCH v2 08/35] acpi: Support string output Wolfgang Wallner
2020-05-19  8:56 ` [PATCH v2 09/35] acpi: Support generation of GPIO descriptor Wolfgang Wallner
2020-05-19  9:32 ` Antwort: [PATCH v2 10/35] acpi: Support generation of a GPIO/irq for a device Wolfgang Wallner
2020-05-19 11:58 ` Antwort: [PATCH v2 11/35] acpi: Support generation of I2C descriptor Wolfgang Wallner
2020-06-09 21:14   ` Simon Glass
2020-05-19 13:14 ` Antwort: [PATCH v2 13/35] acpigen: Support writing a length Wolfgang Wallner
2020-05-27 13:04 ` [PATCH v2 14/35] acpigen: Support writing a package Wolfgang Wallner
2020-05-28  9:45 ` [PATCH v2 15/35] acpi: Support writing an integer Wolfgang Wallner
2020-05-28  9:45 ` Antwort: [PATCH v2 16/35] acpi: Support writing a string Wolfgang Wallner
2020-05-28  9:46 ` [PATCH v2 17/35] acpi: Support writing a name Wolfgang Wallner
2020-05-28  9:57 ` [PATCH v2 18/35] acpi: Support writing a UUID Wolfgang Wallner
2020-05-28 13:36 ` [PATCH v2 19/35] acpi: Support writing Device Properties objects via _DSD Wolfgang Wallner
2020-06-03 11:49 ` Antwort: [PATCH v2 20/35] acpi: Support writing a GPIO Wolfgang Wallner
2020-06-03 12:00 ` [PATCH v2 21/35] acpi: Support copying properties from device tree to ACPI Wolfgang Wallner
2020-06-03 13:04 ` [PATCH v2 22/35] acpi: Add support for various misc ACPI opcodes Wolfgang Wallner
2020-06-04  7:39 ` Antwort: [PATCH v2 23/35] acpi: Add support for writing a Power Resource Wolfgang Wallner
2020-06-04  8:50 ` [PATCH v2 24/35] acpi: Add support for writing a GPIO power sequence Wolfgang Wallner
2020-06-04  9:12 ` [PATCH v2 25/35] acpi: Add support for a generic " Wolfgang Wallner
2020-06-04  9:20 ` [PATCH v2 27/35] x86: acpi: Move MADT down a bit Wolfgang Wallner
2020-06-04 11:52 ` [PATCH v2 29/35] acpi: Support ordering SSDT data by device Wolfgang Wallner
2020-06-04 11:54 ` [PATCH v2 28/35] acpi: Record the items added to SSDT Wolfgang Wallner
2020-06-04 12:20 ` [PATCH v2 30/35] x86: Allow devices to write an SSDT Wolfgang Wallner
2020-06-04 12:22 ` [PATCH v2 33/35] pci: Avoid a crash in device_is_on_pci_bus() Wolfgang Wallner
2020-06-04 12:26 ` [PATCH v2 31/35] acpi: Add support for DSDT generation Wolfgang Wallner
2020-06-04 12:55 ` [PATCH v2 32/35] x86: Allow devices to write to DSDT Wolfgang Wallner
2020-06-04 13:04 ` [PATCH v2 35/35] acpi: Add an acpi split command Wolfgang Wallner
2020-06-04 13:17 ` [PATCH v2 34/35] dm: acpi: Enhance acpi_get_name() Wolfgang Wallner
2020-06-04 13:27 ` [PATCH v2 00/35] dm: Add programmatic generation of ACPI tables (part B) Wolfgang Wallner
2020-06-04 15:59   ` Simon Glass
2020-06-10  8:06 ` [PATCH v2 06/35] acpi: Support generation of interrupt descriptor Wolfgang Wallner
2020-06-10  8:40 ` [PATCH v2 12/35] acpi: Support generation of SPI descriptor Wolfgang Wallner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200510203409.203520-21-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.