From: David Miller <davem@davemloft.net>
To: kda@linux-powerpc.org
Cc: netdev@vger.kernel.org, brouer@redhat.com, jgross@suse.com,
wei.liu@kernel.org, paul@xen.org, ilias.apalodimas@linaro.org
Subject: Re: [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront
Date: Mon, 11 May 2020 13:27:42 -0700 (PDT) [thread overview]
Message-ID: <20200511.132742.1876685074237414958.davem@davemloft.net> (raw)
In-Reply-To: <1589192541-11686-2-git-send-email-kda@linux-powerpc.org>
From: Denis Kirjanov <kda@linux-powerpc.org>
Date: Mon, 11 May 2020 13:22:20 +0300
> @@ -560,6 +572,64 @@ static u16 xennet_select_queue(struct net_device *dev, struct sk_buff *skb,
> return queue_idx;
> }
>
> +static int xennet_xdp_xmit_one(struct net_device *dev, struct xdp_frame *xdpf)
> +{
> + struct netfront_info *np = netdev_priv(dev);
> + struct netfront_stats *tx_stats = this_cpu_ptr(np->tx_stats);
> + struct netfront_queue *queue = NULL;
> + unsigned int num_queues = dev->real_num_tx_queues;
> + unsigned long flags;
> + int notify;
> + struct xen_netif_tx_request *tx;
Reverse christmas tree ordering for these local variables please.
> @@ -792,6 +909,9 @@ static int xennet_get_responses(struct netfront_queue *queue,
> int slots = 1;
> int err = 0;
> unsigned long ret;
> + struct bpf_prog *xdp_prog;
> + struct xdp_buff xdp;
> + u32 verdict;
Likewise.
> @@ -997,7 +1132,9 @@ static int xennet_poll(struct napi_struct *napi, int budget)
> struct sk_buff_head rxq;
> struct sk_buff_head errq;
> struct sk_buff_head tmpq;
> + struct bpf_prog *xdp_prog;
> int err;
> + bool need_xdp_flush = false;
Likewise.
> +static int xennet_xdp_set(struct net_device *dev, struct bpf_prog *prog,
> + struct netlink_ext_ack *extack)
> +{
> + struct netfront_info *np = netdev_priv(dev);
> + struct bpf_prog *old_prog;
> + unsigned int i, err;
> + unsigned long max_mtu = XEN_PAGE_SIZE - XDP_PACKET_HEADROOM;
Likewise.
> +static u32 xennet_xdp_query(struct net_device *dev)
> +{
> + struct netfront_info *np = netdev_priv(dev);
> + unsigned int num_queues = dev->real_num_tx_queues;
> + unsigned int i;
> + struct netfront_queue *queue;
> + const struct bpf_prog *xdp_prog;
Likewise.
next prev parent reply other threads:[~2020-05-11 20:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 10:22 [PATCH net-next v9 0/2] xen networking: add XDP support to xen-netfront Denis Kirjanov
2020-05-11 10:22 ` [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront Denis Kirjanov
2020-05-11 12:05 ` Jürgen Groß
2020-05-11 17:27 ` Denis Kirjanov
2020-05-12 4:22 ` Jürgen Groß
2020-05-12 12:27 ` Denis Kirjanov
2020-05-12 12:41 ` Jürgen Groß
2020-05-12 13:21 ` Denis Kirjanov
2020-05-12 13:38 ` Jürgen Groß
2020-05-11 20:27 ` David Miller [this message]
2020-05-11 10:22 ` [PATCH net-next v9 2/2] xen networking: add XDP offset adjustment to xen-netback Denis Kirjanov
2020-05-11 11:33 ` Paul Durrant
2020-05-11 12:11 ` Denis Kirjanov
2020-05-11 12:14 ` Paul Durrant
2020-05-11 17:21 ` Denis Kirjanov
2020-05-12 7:26 ` Paul Durrant
2020-05-12 12:20 ` Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511.132742.1876685074237414958.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jgross@suse.com \
--cc=kda@linux-powerpc.org \
--cc=netdev@vger.kernel.org \
--cc=paul@xen.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.