From: David Miller <davem@davemloft.net>
To: kuba@kernel.org
Cc: joe@perches.com, netdev@vger.kernel.org, andrew@lunn.ch,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] checkpatch: warn about uses of ENOTSUPP
Date: Mon, 11 May 2020 17:00:49 -0700 (PDT) [thread overview]
Message-ID: <20200511.170049.154263930278676490.davem@davemloft.net> (raw)
In-Reply-To: <20200511170807.2252749-1-kuba@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Mon, 11 May 2020 10:08:07 -0700
> ENOTSUPP often feels like the right error code to use, but it's
> in fact not a standard Unix error. E.g.:
>
> $ python
>>>> import errno
>>>> errno.errorcode[errno.ENOTSUPP]
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> AttributeError: module 'errno' has no attribute 'ENOTSUPP'
>
> There were numerous commits converting the uses back to EOPNOTSUPP
> but in some cases we are stuck with the high error code for backward
> compatibility reasons.
>
> Let's try prevent more ENOTSUPPs from getting into the kernel.
>
> Recent example:
> https://lore.kernel.org/netdev/20200510182252.GA411829@lunn.ch/
>
> v3 (Joe):
> - fix the "not file" condition.
>
> v2 (Joe):
> - add a link to recent discussion,
> - don't match when scanning files, not patches to avoid sudden
> influx of conversion patches.
> https://lore.kernel.org/netdev/20200511165319.2251678-1-kuba@kernel.org/
>
> v1:
> https://lore.kernel.org/netdev/20200510185148.2230767-1-kuba@kernel.org/
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Acked-by: Joe Perches <joe@perches.com>
Applied, thanks Jakub.
prev parent reply other threads:[~2020-05-12 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 17:08 [PATCH net-next v3] checkpatch: warn about uses of ENOTSUPP Jakub Kicinski
2020-05-11 17:16 ` Joe Perches
2020-05-11 20:43 ` David Miller
2020-05-12 0:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511.170049.154263930278676490.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.