All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] package/paho-mqtt-c: fix build on musl
@ 2020-05-11  7:28 Peter Korsgaard
  2020-05-11 19:23 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2020-05-11  7:28 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=e446f5ac02313894014fdcd4e281961a4ab383c9
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Set PAHO_HIGH_PERFORMANCE to disable free redefiniton as suggested by
upstream in https://github.com/eclipse/paho.mqtt.c/issues/846.

This will avoid the following build failure on musl:

/tmp/instance-1/output-1/host/x86_64-buildroot-linux-musl/sysroot/usr/include/sched.h:80:17: error: expected declaration specifiers or '...' before string constant
 void free(void *);
                 ^
/tmp/instance-1/output-1/host/x86_64-buildroot-linux-musl/sysroot/usr/include/sched.h:80:17: error: expected declaration specifiers or '...' before numeric constant
 void free(void *);
                 ^
[ 35%] Building C object src/CMakeFiles/common_obj.dir/Base64.c.o
[ 36%] Building C object src/CMakeFiles/common_obj.dir/SHA1.c.o
make[3]: *** [src/CMakeFiles/common_obj.dir/build.make:284: src/CMakeFiles/common_obj.dir/MQTTReasonCodes.c.o] Error 1

Fixes:
 - http://autobuild.buildroot.org/results//fbe57a1602fed331ddff3ff3560dce02573816ff

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/paho-mqtt-c/paho-mqtt-c.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/paho-mqtt-c/paho-mqtt-c.mk b/package/paho-mqtt-c/paho-mqtt-c.mk
index 6a6b5f3d64..c7ecf412cd 100644
--- a/package/paho-mqtt-c/paho-mqtt-c.mk
+++ b/package/paho-mqtt-c/paho-mqtt-c.mk
@@ -12,7 +12,8 @@ PAHO_MQTT_C_INSTALL_STAGING = YES
 
 PAHO_MQTT_C_CONF_OPTS = \
 	-DPAHO_ENABLE_TESTING=FALSE \
-	-DPAHO_ENABLE_CPACK=FALSE
+	-DPAHO_ENABLE_CPACK=FALSE \
+	-DPAHO_HIGH_PERFORMANCE=TRUE
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 PAHO_MQTT_C_DEPENDENCIES += openssl

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [git commit] package/paho-mqtt-c: fix build on musl
  2020-05-11  7:28 [Buildroot] [git commit] package/paho-mqtt-c: fix build on musl Peter Korsgaard
@ 2020-05-11 19:23 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2020-05-11 19:23 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=e446f5ac02313894014fdcd4e281961a4ab383c9
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > Set PAHO_HIGH_PERFORMANCE to disable free redefiniton as suggested by
 > upstream in https://github.com/eclipse/paho.mqtt.c/issues/846.

 > This will avoid the following build failure on musl:

 > /tmp/instance-1/output-1/host/x86_64-buildroot-linux-musl/sysroot/usr/include/sched.h:80:17: error: expected declaration specifiers or '...' before string constant
 >  void free(void *);
 >                  ^
 > /tmp/instance-1/output-1/host/x86_64-buildroot-linux-musl/sysroot/usr/include/sched.h:80:17: error: expected declaration specifiers or '...' before numeric constant
 >  void free(void *);
 >                  ^
 > [ 35%] Building C object src/CMakeFiles/common_obj.dir/Base64.c.o
 > [ 36%] Building C object src/CMakeFiles/common_obj.dir/SHA1.c.o
 > make[3]: *** [src/CMakeFiles/common_obj.dir/build.make:284: src/CMakeFiles/common_obj.dir/MQTTReasonCodes.c.o] Error 1

 > Fixes:
 >  - http://autobuild.buildroot.org/results//fbe57a1602fed331ddff3ff3560dce02573816ff

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2020.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-11 19:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11  7:28 [Buildroot] [git commit] package/paho-mqtt-c: fix build on musl Peter Korsgaard
2020-05-11 19:23 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.