* [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
@ 2020-05-11 8:33 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-05-11 8:33 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Kukjin Kim, Krzysztof Kozlowski,
linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Alim Akhtar
The Exynos7-specific code bits in ADC driver do not play with PHY:
the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
instance. Therefore the initialization code does not have to check if
it is true.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Only build tested.
---
drivers/iio/adc/exynos_adc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 22131a677445..219c8eb32d16 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct exynos_adc *info)
{
u32 con1, con2;
- if (info->data->needs_adc_phy)
- regmap_write(info->pmu_map, info->data->phy_offset, 1);
-
con1 = ADC_V2_CON1_SOFT_RESET;
writel(con1, ADC_V2_CON1(info->regs));
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
@ 2020-05-11 8:33 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-05-11 8:33 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Kukjin Kim, Krzysztof Kozlowski,
linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Alim Akhtar
The Exynos7-specific code bits in ADC driver do not play with PHY:
the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
instance. Therefore the initialization code does not have to check if
it is true.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Only build tested.
---
drivers/iio/adc/exynos_adc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 22131a677445..219c8eb32d16 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct exynos_adc *info)
{
u32 con1, con2;
- if (info->data->needs_adc_phy)
- regmap_write(info->pmu_map, info->data->phy_offset, 1);
-
con1 = ADC_V2_CON1_SOFT_RESET;
writel(con1, ADC_V2_CON1(info->regs));
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
2020-05-11 8:33 ` Krzysztof Kozlowski
@ 2020-05-11 17:19 ` Alim Akhtar
-1 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2020-05-11 17:19 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Jonathan Cameron',
'Hartmut Knaack', 'Lars-Peter Clausen',
'Peter Meerwald-Stadler', 'Kukjin Kim',
linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel
Hello Krzysztof,
Thanks for the patch.
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 11 May 2020 14:04
> To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack
> <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-
> Stadler <pmeerw@pmeerw.net>; Kukjin Kim <kgene@kernel.org>; Krzysztof
> Kozlowski <krzk@kernel.org>; linux-iio@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
>
> The Exynos7-specific code bits in ADC driver do not play with PHY:
> the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
> instance. Therefore the initialization code does not have to check if it
is true.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Tested on exynos7-espresso board so,
Tested-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>
> Only build tested.
> ---
> drivers/iio/adc/exynos_adc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index
> 22131a677445..219c8eb32d16 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
> exynos_adc *info) {
> u32 con1, con2;
>
> - if (info->data->needs_adc_phy)
> - regmap_write(info->pmu_map, info->data->phy_offset, 1);
> -
> con1 = ADC_V2_CON1_SOFT_RESET;
> writel(con1, ADC_V2_CON1(info->regs));
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
@ 2020-05-11 17:19 ` Alim Akhtar
0 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2020-05-11 17:19 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Jonathan Cameron',
'Hartmut Knaack', 'Lars-Peter Clausen',
'Peter Meerwald-Stadler', 'Kukjin Kim',
linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel
Hello Krzysztof,
Thanks for the patch.
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 11 May 2020 14:04
> To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack
> <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-
> Stadler <pmeerw@pmeerw.net>; Kukjin Kim <kgene@kernel.org>; Krzysztof
> Kozlowski <krzk@kernel.org>; linux-iio@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
>
> The Exynos7-specific code bits in ADC driver do not play with PHY:
> the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
> instance. Therefore the initialization code does not have to check if it
is true.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Tested on exynos7-espresso board so,
Tested-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>
> Only build tested.
> ---
> drivers/iio/adc/exynos_adc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index
> 22131a677445..219c8eb32d16 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
> exynos_adc *info) {
> u32 con1, con2;
>
> - if (info->data->needs_adc_phy)
> - regmap_write(info->pmu_map, info->data->phy_offset, 1);
> -
> con1 = ADC_V2_CON1_SOFT_RESET;
> writel(con1, ADC_V2_CON1(info->regs));
>
> --
> 2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
2020-05-11 17:19 ` Alim Akhtar
@ 2020-05-16 16:37 ` Jonathan Cameron
-1 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-05-16 16:37 UTC (permalink / raw)
To: Alim Akhtar
Cc: 'Krzysztof Kozlowski', 'Hartmut Knaack',
'Lars-Peter Clausen', 'Peter Meerwald-Stadler',
'Kukjin Kim',
linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel
On Mon, 11 May 2020 22:49:28 +0530
"Alim Akhtar" <alim.akhtar@samsung.com> wrote:
> Hello Krzysztof,
> Thanks for the patch.
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 11 May 2020 14:04
> > To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack
> > <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-
> > Stadler <pmeerw@pmeerw.net>; Kukjin Kim <kgene@kernel.org>; Krzysztof
> > Kozlowski <krzk@kernel.org>; linux-iio@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Cc: Alim Akhtar <alim.akhtar@samsung.com>
> > Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
> >
> > The Exynos7-specific code bits in ADC driver do not play with PHY:
> > the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
> > instance. Therefore the initialization code does not have to check if it
> is true.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> Tested on exynos7-espresso board so,
> Tested-by: Alim Akhtar <alim.akhtar@samsung.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
>
> > ---
> >
> > Only build tested.
> > ---
> > drivers/iio/adc/exynos_adc.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index
> > 22131a677445..219c8eb32d16 100644
> > --- a/drivers/iio/adc/exynos_adc.c
> > +++ b/drivers/iio/adc/exynos_adc.c
> > @@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
> > exynos_adc *info) {
> > u32 con1, con2;
> >
> > - if (info->data->needs_adc_phy)
> > - regmap_write(info->pmu_map, info->data->phy_offset, 1);
> > -
> > con1 = ADC_V2_CON1_SOFT_RESET;
> > writel(con1, ADC_V2_CON1(info->regs));
> >
> > --
> > 2.17.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
@ 2020-05-16 16:37 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-05-16 16:37 UTC (permalink / raw)
To: Alim Akhtar
Cc: 'Lars-Peter Clausen',
linux-iio, linux-kernel, 'Krzysztof Kozlowski',
linux-samsung-soc, 'Kukjin Kim',
'Peter Meerwald-Stadler', 'Hartmut Knaack',
linux-arm-kernel
On Mon, 11 May 2020 22:49:28 +0530
"Alim Akhtar" <alim.akhtar@samsung.com> wrote:
> Hello Krzysztof,
> Thanks for the patch.
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 11 May 2020 14:04
> > To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack
> > <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-
> > Stadler <pmeerw@pmeerw.net>; Kukjin Kim <kgene@kernel.org>; Krzysztof
> > Kozlowski <krzk@kernel.org>; linux-iio@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Cc: Alim Akhtar <alim.akhtar@samsung.com>
> > Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
> >
> > The Exynos7-specific code bits in ADC driver do not play with PHY:
> > the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
> > instance. Therefore the initialization code does not have to check if it
> is true.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> Tested on exynos7-espresso board so,
> Tested-by: Alim Akhtar <alim.akhtar@samsung.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
>
> > ---
> >
> > Only build tested.
> > ---
> > drivers/iio/adc/exynos_adc.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index
> > 22131a677445..219c8eb32d16 100644
> > --- a/drivers/iio/adc/exynos_adc.c
> > +++ b/drivers/iio/adc/exynos_adc.c
> > @@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
> > exynos_adc *info) {
> > u32 con1, con2;
> >
> > - if (info->data->needs_adc_phy)
> > - regmap_write(info->pmu_map, info->data->phy_offset, 1);
> > -
> > con1 = ADC_V2_CON1_SOFT_RESET;
> > writel(con1, ADC_V2_CON1(info->regs));
> >
> > --
> > 2.17.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-16 16:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200511083406epcas5p18e835634e60f362dc408d73886aa5563@epcas5p1.samsung.com>
2020-05-11 8:33 ` [PATCH] iio: adc: exynos: Simplify Exynos7-specific init Krzysztof Kozlowski
2020-05-11 8:33 ` Krzysztof Kozlowski
2020-05-11 17:19 ` Alim Akhtar
2020-05-11 17:19 ` Alim Akhtar
2020-05-16 16:37 ` Jonathan Cameron
2020-05-16 16:37 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.