From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] platform/x86: Export LPC attributes for the system SPI chip Date: Mon, 11 May 2020 13:45:04 +0300 Message-ID: <20200511104504.GK487496@lahna.fi.intel.com> References: <18e48255d68a1408b3e3152780f0e789df540059.camel@gmail.com> <61c7782cd2e64bb9ab2aaf6a016bbb6c@AUSX13MPC101.AMER.DELL.COM> <70757953c25645baac2dddd7c6924d05@AUSX13MPC101.AMER.DELL.COM> <20200508082028.GP487496@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-security-module@vger.kernel.org To: Richard Hughes Cc: Mario Limonciello , Platform Driver , linux-security-module List-Id: platform-driver-x86.vger.kernel.org On Fri, May 08, 2020 at 05:15:07PM +0100, Richard Hughes wrote: > On Fri, 8 May 2020 at 09:20, Mika Westerberg > wrote: > > Thanks for the information. I actually prefer that this would be in a > > separate driver because I do not want distros to enable intel-spi just > > for this. It is really only meant for special setups where firmware > > upgrade/access flow has been thoroughly tested. > > Do you think the driver should be part of mtd (e.g. something like > drivers/mtd/spi-nor/controllers/intel-spi-pci-lpc.c) or be something > like I proposed in drivers/platform/x86? Ideas very welcome, thanks. I think you may want to look at drivers/mfd/lpc_ich.c and see if some of this can be placed there. It is the "LPC" driver that binds to the LPC/eSPI PCI device so it already has at least some of these PCI IDs.