From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A27C47255 for ; Mon, 11 May 2020 11:01:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A34620801 for ; Mon, 11 May 2020 11:01:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zzh+rRGD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729619AbgEKLB6 (ORCPT ); Mon, 11 May 2020 07:01:58 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:55970 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728136AbgEKLB5 (ORCPT ); Mon, 11 May 2020 07:01:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589194916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/wxVoTSctGeT+2x6Wq8s20j7ese2p9h/0eegbNP4kOM=; b=Zzh+rRGDjqoPEUtl17VxGlZQ88UVdUqaXOEAHURT4xJ9y96fax/f08h45oCF7acW1s5RlP qX5nCSt4227jqi/3MPce4ogpcK3xGCBFL8nyX7FMJrbAovM0cWga7y1nDr3m2/c9smhOfd hQQ2caQNs+3tZUj3HpUlW1jb6ZPx8AU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-Db2IzRKJPYKnYViZoazu_A-1; Mon, 11 May 2020 07:01:53 -0400 X-MC-Unique: Db2IzRKJPYKnYViZoazu_A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BBDB61899520; Mon, 11 May 2020 11:01:50 +0000 (UTC) Received: from krava (unknown [10.40.194.31]) by smtp.corp.redhat.com (Postfix) with SMTP id 3F2486C77D; Mon, 11 May 2020 11:01:47 +0000 (UTC) Date: Mon, 11 May 2020 13:01:46 +0200 From: Jiri Olsa To: John Garry Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, will@kernel.org, ak@linux.intel.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, qiangqing.zhang@nxp.com, irogers@google.com, robin.murphy@arm.com, zhangshaokun@hisilicon.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC v3 02/12] perf jevents: Add support for system events tables Message-ID: <20200511110146.GD2986380@krava> References: <1588852671-61996-1-git-send-email-john.garry@huawei.com> <1588852671-61996-3-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588852671-61996-3-git-send-email-john.garry@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2020 at 07:57:41PM +0800, John Garry wrote: SNIP > > +static int process_system_event_tables(FILE *outfp) > +{ > + struct sys_event_table *sys_event_table; > + > + fprintf(outfp, "struct pmu_sys_events pmu_sys_event_tables[] = {"); > + > + list_for_each_entry(sys_event_table, &sys_event_tables, list) { > + fprintf(outfp, "\n\t{\n\t\t.table = %s,\n\t},", > + sys_event_table->name); > + } > + fprintf(outfp, "\n\t{\n\t\t.table = 0\n\t},"); this will add extra tabs: { .table = 0 }, while the rest of the file starts items without any indent jirka From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF86C47255 for ; Mon, 11 May 2020 11:02:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B274720736 for ; Mon, 11 May 2020 11:02:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hvClmwYj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="c0gkqkbh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B274720736 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A1TjqoSgaMWLYo8EKchhLa7NOXagGZ859nnf1pHCItM=; b=hvClmwYjcUs0td f/39fb6UUcUG1MxPdX7gycqK68cWghm851mVUB4rwndaiynyQw/SZRbpWi0O2eMjv5PaU/cy6aSzu HMpQ+B0h1ZnHQInIro6UprIksm4AUVbJ7rUgPcirte9OwbjVlwkCZKgKL1pU6gxsCf9SGGeSauUKv MLvg4lJEMqb9PKPVUJzQFzoMUVVUa2QAZKAJ6RgQnSfB3M6493w1EmZeezO6CaFtAXcbc1ijJvTRJ McMvRHEXsY20jiSUAZ9MBUUf4hSMKW+RCaGdC0C3rlXvhVcuWGQI6v4MDd6GI5dqgUjgXOKWeDsUf OiX/QIRYKc5wRvZDV6rQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY6CZ-0006z8-KP; Mon, 11 May 2020 11:02:27 +0000 Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY6C6-0006dX-Qi for linux-arm-kernel@lists.infradead.org; Mon, 11 May 2020 11:02:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589194917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/wxVoTSctGeT+2x6Wq8s20j7ese2p9h/0eegbNP4kOM=; b=c0gkqkbhiVwy4n9rjjWoblLLlii1OK7GIHdoN9mBCpZNWpWadYF8sCSdAUU6001n815Zli pnlkxugtji2gAKxTBFgXxcOZ09S5aFZD1fw7/v9CIC2/wZjrTA9HQquLw9JebL4uduOODN Fcr0jT3nbQl+7ZbFMxNKe//S3wtUsZM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-Db2IzRKJPYKnYViZoazu_A-1; Mon, 11 May 2020 07:01:53 -0400 X-MC-Unique: Db2IzRKJPYKnYViZoazu_A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BBDB61899520; Mon, 11 May 2020 11:01:50 +0000 (UTC) Received: from krava (unknown [10.40.194.31]) by smtp.corp.redhat.com (Postfix) with SMTP id 3F2486C77D; Mon, 11 May 2020 11:01:47 +0000 (UTC) Date: Mon, 11 May 2020 13:01:46 +0200 From: Jiri Olsa To: John Garry Subject: Re: [PATCH RFC v3 02/12] perf jevents: Add support for system events tables Message-ID: <20200511110146.GD2986380@krava> References: <1588852671-61996-1-git-send-email-john.garry@huawei.com> <1588852671-61996-3-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1588852671-61996-3-git-send-email-john.garry@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_040158_966910_66EF7493 X-CRM114-Status: UNSURE ( 8.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, irogers@google.com, ak@linux.intel.com, qiangqing.zhang@nxp.com, peterz@infradead.org, robin.murphy@arm.com, linuxarm@huawei.com, acme@kernel.org, linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com, alexander.shishkin@linux.intel.com, mingo@redhat.com, namhyung@kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 07, 2020 at 07:57:41PM +0800, John Garry wrote: SNIP > > +static int process_system_event_tables(FILE *outfp) > +{ > + struct sys_event_table *sys_event_table; > + > + fprintf(outfp, "struct pmu_sys_events pmu_sys_event_tables[] = {"); > + > + list_for_each_entry(sys_event_table, &sys_event_tables, list) { > + fprintf(outfp, "\n\t{\n\t\t.table = %s,\n\t},", > + sys_event_table->name); > + } > + fprintf(outfp, "\n\t{\n\t\t.table = 0\n\t},"); this will add extra tabs: { .table = 0 }, while the rest of the file starts items without any indent jirka _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel