From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D46C54E8D for ; Mon, 11 May 2020 13:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2943E20736 for ; Mon, 11 May 2020 13:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mEYRAboh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729485AbgEKNn0 (ORCPT ); Mon, 11 May 2020 09:43:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729514AbgEKNn0 (ORCPT ); Mon, 11 May 2020 09:43:26 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 376E3C061A0E for ; Mon, 11 May 2020 06:43:25 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id w7so11030170wre.13 for ; Mon, 11 May 2020 06:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0fpk5Xqv9Yro05H314xa5B77PsSpk1e22VGbukZepR0=; b=mEYRAbohHj9FT80QIN/XzGP0RK1RJdYQ+SPBVrhjGvEG1fo/b/wSbQUryrPWgltT0o IkcFU/TN3+CssRVyv7w9pbFo1Ao857ZUnI61mXnTixG4CNdUkxo1TqBtb+18gV/r0s9T PPmzLqaj4sRqLx9LKDx1ZKjj7S/l7K66pZ7BoueguIMGC7RkhcUpGCTxIqf80k1bRJMt K4r7mmsbyu5ERiD9qkW6VioEmXn0IV06q0wEgK46c748II6H/HGiqFskqR/x66mf2GeN X68E2XP0oEEZzqsVFopP+39+jSNN9eg9gI+iHo96H/QWJXde4g2p+s6l6KmyLM09APAS DDWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0fpk5Xqv9Yro05H314xa5B77PsSpk1e22VGbukZepR0=; b=Yguq1H1RZuFHr/1MaIw+u3gIvwyjV7kSc/C4l65ZseGa2bUb81bAGasDGTX5s7/Wm8 rvZzGU+G/poBIFituJcP+vPrtZF7ob+Rx03bnD/pbYEGbJznNbrQQ/zPDmua8TsOZnOs dBu7Qeo4e05k1sJpOA/4no9Vlx1FNkppC4MeAbn0moQF5bNP3IjFAOkv7LS8ojJ/MJx5 V7bLYON3zRIvVuGTxsiafpAG9yfGT73M5OedTezOwO0fHPtflGROsgSzN/QJ1EKiwcDs I/knWjyUn5aiqSYzWoH8HWSl2TZYHZs20XlP8JOTF4zGN03ybK1MbM2Lag6v4rtfRnh9 R2hw== X-Gm-Message-State: AGi0Pubjv01kUY5LTa4miVacKizHjXpmHnYLHDrgG01NCjflAT7A8ZsR 6GnA27sZow6SfE+NlYGNO2oIzg== X-Google-Smtp-Source: APiQypItJDTCfkEocXHWq2r5Ng7HfPcqePb/ZXsdjVC/ZzMJj4eOCaQ+uMUlRLgbkt8pygDOHi6PUw== X-Received: by 2002:adf:eac6:: with SMTP id o6mr18960567wrn.297.1589204603437; Mon, 11 May 2020 06:43:23 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id q184sm27142122wma.25.2020.05.11.06.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 06:43:22 -0700 (PDT) Date: Mon, 11 May 2020 14:43:19 +0100 From: Quentin Perret To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Dietmar.Eggemann@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net, orjan.eide@arm.com, rdunlap@infradead.org, mka@chromium.org Subject: Re: [PATCH v7 04/15] PM / EM: add support for other devices than CPUs in Energy Model Message-ID: <20200511134319.GA29112@google.com> References: <20200511111912.3001-1-lukasz.luba@arm.com> <20200511111912.3001-5-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200511111912.3001-5-lukasz.luba@arm.com> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hey Lukasz, On Monday 11 May 2020 at 12:19:01 (+0100), Lukasz Luba wrote: > @@ -27,12 +29,15 @@ struct em_perf_state { > * em_perf_domain - Performance domain > * @table: List of performance states, in ascending order > * @nr_perf_states: Number of performance states > - * @cpus: Cpumask covering the CPUs of the domain > + * @cpus: Cpumask covering the CPUs of the domain. It's here > + * for performance reasons to avoid potential cache > + * misses during energy calculations in the scheduler And because that saves a pointer, and simplifies allocating/freeing that memory region :) > diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c > index 5b8a1566526a..9cc7f2973600 100644 > --- a/kernel/power/energy_model.c > +++ b/kernel/power/energy_model.c > @@ -2,8 +2,9 @@ > /* > * Energy Model of CPUs Should this comment change too? > -static void em_debug_create_pd(struct em_perf_domain *pd, int cpu) > +static void em_debug_create_pd(struct device *dev) > { > struct dentry *d; > - char name[8]; > int i; > > - snprintf(name, sizeof(name), "pd%d", cpu); > - > /* Create the directory of the performance domain */ > - d = debugfs_create_dir(name, rootdir); > + d = debugfs_create_dir(dev_name(dev), rootdir); So what will be the name for the perf domain of CPUs now? cpuX? > @@ -142,8 +149,8 @@ em_create_pd(struct device *dev, int nr_states, struct em_data_callback *cb, > */ > opp_eff = freq / power; > if (opp_eff >= prev_opp_eff) > - pr_warn("pd%d: hertz/watts ratio non-monotonically decreasing: em_perf_state %d >= em_perf_state%d\n", > - cpu, i, i - 1); > + dev_dbg(dev, "EM: hertz/watts ratio non-monotonically decreasing: em_perf_state %d >= em_perf_state%d\n", > + i, i - 1); It feels like changing from warn to debug doesn't really belong to this patch no? > @@ -216,47 +274,50 @@ int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states, > */ > mutex_lock(&em_pd_mutex); > > - for_each_cpu(cpu, span) { > - /* Make sure we don't register again an existing domain. */ > - if (READ_ONCE(per_cpu(em_data, cpu))) { > - ret = -EEXIST; > - goto unlock; > - } > + if (dev->em_pd) { > + ret = -EEXIST; > + goto unlock; > + } > > - /* > - * All CPUs of a domain must have the same micro-architecture > - * since they all share the same table. > - */ > - cap = arch_scale_cpu_capacity(cpu); > - if (prev_cap && prev_cap != cap) { > - pr_err("CPUs of %*pbl must have the same capacity\n", > - cpumask_pr_args(span)); > + if (_is_cpu_device(dev)) { Something like if (!_is_cpu_device(dev)) goto device; would limit the diff a bit, but that may just be personal taste. But appart from these nits, the patch LGTM. Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1805FC47255 for ; Mon, 11 May 2020 13:43:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEAF9206D3 for ; Mon, 11 May 2020 13:43:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ioNN4m8S"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="mEYRAboh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEAF9206D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FOBc9+As30q0dKS4sdoV5IBmh7LOVtkjYrDUZ97f4i4=; b=ioNN4m8SCmp6vK Inog7fU8kis1C3jcROruE9ghlPpf0e7t9qH60B6LH4RliC+MToZfUXHuBTbYfbQXOsdj5OUYg5KGQ cycOz0mQQvWPRjV7uYbIUSgGKPKsuyCRNUKEIC6Hny6/c/naqkG0u2Oe/jVWzPl7YPaE0n327Xnyk 79ePs/pGh0CCI/RWRVZPTAOHDxcmoFZvTYjYNU/DK8iYdKDhGdBFx6cZRYG2xXEzE+96xThWGrg6I 5EnyH0pwW1bsB88iC+RifW3ThXMk4g6AJkVoDahPel65E+z9RnAEXy2+nm6Hb79umANZcJ1VR+Zmq WN1rdza82TulFQDpphhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY8iP-0001HW-Cu; Mon, 11 May 2020 13:43:29 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY8iM-0001GQ-LQ for linux-mediatek@lists.infradead.org; Mon, 11 May 2020 13:43:28 +0000 Received: by mail-wr1-x442.google.com with SMTP id x17so11048583wrt.5 for ; Mon, 11 May 2020 06:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0fpk5Xqv9Yro05H314xa5B77PsSpk1e22VGbukZepR0=; b=mEYRAbohHj9FT80QIN/XzGP0RK1RJdYQ+SPBVrhjGvEG1fo/b/wSbQUryrPWgltT0o IkcFU/TN3+CssRVyv7w9pbFo1Ao857ZUnI61mXnTixG4CNdUkxo1TqBtb+18gV/r0s9T PPmzLqaj4sRqLx9LKDx1ZKjj7S/l7K66pZ7BoueguIMGC7RkhcUpGCTxIqf80k1bRJMt K4r7mmsbyu5ERiD9qkW6VioEmXn0IV06q0wEgK46c748II6H/HGiqFskqR/x66mf2GeN X68E2XP0oEEZzqsVFopP+39+jSNN9eg9gI+iHo96H/QWJXde4g2p+s6l6KmyLM09APAS DDWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0fpk5Xqv9Yro05H314xa5B77PsSpk1e22VGbukZepR0=; b=E865mdwn8wtgA1qRjMrlqkS/Iai6ae14vMKY6w/OTr2HPxmTnU9G42W4opQl5N0FpR qY6WNTw5Z1IqsOb1AvSGcZG0Cw45deeb0Vxzz5YXiXP7DvcHB9SAvz+GdV3koVT85t4E 1AkmlKJblqg53Yj7n/5d0NGNYwo0XtWbF+9Fll/QL/sZj06FUF8uJ1RPyzmmVLRVFEJC APh1YyHa1rzCGdZQWfcmB+tKNzOrcEml7tBSzeVJQGX8drjMz832JIPd79JTOKn9DBwX LTaHhhLddPcL6ti27K4ZkuwEHvbb+tTo0WnZjKZ5RL3Rlyy6nQT60C7Ya066TeemRUQ+ 08Cw== X-Gm-Message-State: AGi0PuYKfM6Cto7gSEW8fwvq58B85LXzEol1WFIcQTaYAjFxRfMoj9YV Gi/9bq16qEuB3uQJlzstxMED9A== X-Google-Smtp-Source: APiQypItJDTCfkEocXHWq2r5Ng7HfPcqePb/ZXsdjVC/ZzMJj4eOCaQ+uMUlRLgbkt8pygDOHi6PUw== X-Received: by 2002:adf:eac6:: with SMTP id o6mr18960567wrn.297.1589204603437; Mon, 11 May 2020 06:43:23 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id q184sm27142122wma.25.2020.05.11.06.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 06:43:22 -0700 (PDT) Date: Mon, 11 May 2020 14:43:19 +0100 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v7 04/15] PM / EM: add support for other devices than CPUs in Energy Model Message-ID: <20200511134319.GA29112@google.com> References: <20200511111912.3001-1-lukasz.luba@arm.com> <20200511111912.3001-5-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511111912.3001-5-lukasz.luba@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_064326_727279_70BEBA64 X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, mka@chromium.org, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hey Lukasz, On Monday 11 May 2020 at 12:19:01 (+0100), Lukasz Luba wrote: > @@ -27,12 +29,15 @@ struct em_perf_state { > * em_perf_domain - Performance domain > * @table: List of performance states, in ascending order > * @nr_perf_states: Number of performance states > - * @cpus: Cpumask covering the CPUs of the domain > + * @cpus: Cpumask covering the CPUs of the domain. It's here > + * for performance reasons to avoid potential cache > + * misses during energy calculations in the scheduler And because that saves a pointer, and simplifies allocating/freeing that memory region :) > diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c > index 5b8a1566526a..9cc7f2973600 100644 > --- a/kernel/power/energy_model.c > +++ b/kernel/power/energy_model.c > @@ -2,8 +2,9 @@ > /* > * Energy Model of CPUs Should this comment change too? > -static void em_debug_create_pd(struct em_perf_domain *pd, int cpu) > +static void em_debug_create_pd(struct device *dev) > { > struct dentry *d; > - char name[8]; > int i; > > - snprintf(name, sizeof(name), "pd%d", cpu); > - > /* Create the directory of the performance domain */ > - d = debugfs_create_dir(name, rootdir); > + d = debugfs_create_dir(dev_name(dev), rootdir); So what will be the name for the perf domain of CPUs now? cpuX? > @@ -142,8 +149,8 @@ em_create_pd(struct device *dev, int nr_states, struct em_data_callback *cb, > */ > opp_eff = freq / power; > if (opp_eff >= prev_opp_eff) > - pr_warn("pd%d: hertz/watts ratio non-monotonically decreasing: em_perf_state %d >= em_perf_state%d\n", > - cpu, i, i - 1); > + dev_dbg(dev, "EM: hertz/watts ratio non-monotonically decreasing: em_perf_state %d >= em_perf_state%d\n", > + i, i - 1); It feels like changing from warn to debug doesn't really belong to this patch no? > @@ -216,47 +274,50 @@ int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states, > */ > mutex_lock(&em_pd_mutex); > > - for_each_cpu(cpu, span) { > - /* Make sure we don't register again an existing domain. */ > - if (READ_ONCE(per_cpu(em_data, cpu))) { > - ret = -EEXIST; > - goto unlock; > - } > + if (dev->em_pd) { > + ret = -EEXIST; > + goto unlock; > + } > > - /* > - * All CPUs of a domain must have the same micro-architecture > - * since they all share the same table. > - */ > - cap = arch_scale_cpu_capacity(cpu); > - if (prev_cap && prev_cap != cap) { > - pr_err("CPUs of %*pbl must have the same capacity\n", > - cpumask_pr_args(span)); > + if (_is_cpu_device(dev)) { Something like if (!_is_cpu_device(dev)) goto device; would limit the diff a bit, but that may just be personal taste. But appart from these nits, the patch LGTM. Thanks, Quentin _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F34C4C54E8D for ; Mon, 11 May 2020 13:43:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7B7E206B7 for ; Mon, 11 May 2020 13:43:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U2BtlIpD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="mEYRAboh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7B7E206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fv6p+rvPx78CHoQNPY983+TV+7cxxUSWjXLCVuTjRKw=; b=U2BtlIpDXTe9DJ mp3diEqwvB5gsimPhDlX8KdZfkaNfd0YgeG5FAS55r0BYoAU0XOJRZyF+dc6862JcHw0YobXd4y7r pwgfLgJhrRZVhe6Fz1192lmMWqQBxsuKGO286sp61KVcXt6SyExZOSLi8hF0jODLDSxNEz8Mc76wM 3myaxgafDa7B5DVe69GWjoUcUDMb2Y9VWpuNa1h5BHxJhZCCah33xWE0jPWdrTajOfs9Vhhn+CRb/ KWM5Ieienic/YQjO0hSdJqrxdqQAEW0Lhm30UrHePm3lZgDfZLc7Hq4OAdAT3ATgNvb2ws7nMC+mY LdIWW4ciehFQVYsqPffQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY8iQ-0001Hy-6H; Mon, 11 May 2020 13:43:30 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY8iM-0001GR-Lk for linux-arm-kernel@lists.infradead.org; Mon, 11 May 2020 13:43:28 +0000 Received: by mail-wr1-x444.google.com with SMTP id w7so11030171wre.13 for ; Mon, 11 May 2020 06:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0fpk5Xqv9Yro05H314xa5B77PsSpk1e22VGbukZepR0=; b=mEYRAbohHj9FT80QIN/XzGP0RK1RJdYQ+SPBVrhjGvEG1fo/b/wSbQUryrPWgltT0o IkcFU/TN3+CssRVyv7w9pbFo1Ao857ZUnI61mXnTixG4CNdUkxo1TqBtb+18gV/r0s9T PPmzLqaj4sRqLx9LKDx1ZKjj7S/l7K66pZ7BoueguIMGC7RkhcUpGCTxIqf80k1bRJMt K4r7mmsbyu5ERiD9qkW6VioEmXn0IV06q0wEgK46c748II6H/HGiqFskqR/x66mf2GeN X68E2XP0oEEZzqsVFopP+39+jSNN9eg9gI+iHo96H/QWJXde4g2p+s6l6KmyLM09APAS DDWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0fpk5Xqv9Yro05H314xa5B77PsSpk1e22VGbukZepR0=; b=cjvMgHBRhQBc20nI5IW1PluZgedoULGTXeb3+mr/06ZgCBVa8+az/PC7GLrL1jnPVh S/VfH2cf8f9Nvr+gKVSxYMOweiwZdm8/HAM6n2iJWBSuDi9lyw2afZgWRkOTSYzCuJMM BU/B/ganYIDe/k0VnDB8Sahpprioe7K+eIodZymr/9osKnZ9AawYH8N9CtQahHAOteYg bKSkG9OgpvoekvDtMoiWPdTjGtalkC6n1oCfYQQvPA5kK4fTPt5N/0MZXqxsEyrtdhlp qnqIZVRSJANQ5SmsQdqD6qQbthuEC3n9EbNJ41QZPUjqyK7EnlBZvpgsK4lerzhWGXpd qWyQ== X-Gm-Message-State: AGi0PubeHwxKOH73COb5jDcIkkogQiNLQp9ApSQXCR6igH4HDG1RwlIP ZqM8wxK8weau4G2p01VnJFAKrQ== X-Google-Smtp-Source: APiQypItJDTCfkEocXHWq2r5Ng7HfPcqePb/ZXsdjVC/ZzMJj4eOCaQ+uMUlRLgbkt8pygDOHi6PUw== X-Received: by 2002:adf:eac6:: with SMTP id o6mr18960567wrn.297.1589204603437; Mon, 11 May 2020 06:43:23 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id q184sm27142122wma.25.2020.05.11.06.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 06:43:22 -0700 (PDT) Date: Mon, 11 May 2020 14:43:19 +0100 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v7 04/15] PM / EM: add support for other devices than CPUs in Energy Model Message-ID: <20200511134319.GA29112@google.com> References: <20200511111912.3001-1-lukasz.luba@arm.com> <20200511111912.3001-5-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511111912.3001-5-lukasz.luba@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_064326_727072_C738CF87 X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, mka@chromium.org, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Lukasz, On Monday 11 May 2020 at 12:19:01 (+0100), Lukasz Luba wrote: > @@ -27,12 +29,15 @@ struct em_perf_state { > * em_perf_domain - Performance domain > * @table: List of performance states, in ascending order > * @nr_perf_states: Number of performance states > - * @cpus: Cpumask covering the CPUs of the domain > + * @cpus: Cpumask covering the CPUs of the domain. It's here > + * for performance reasons to avoid potential cache > + * misses during energy calculations in the scheduler And because that saves a pointer, and simplifies allocating/freeing that memory region :) > diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c > index 5b8a1566526a..9cc7f2973600 100644 > --- a/kernel/power/energy_model.c > +++ b/kernel/power/energy_model.c > @@ -2,8 +2,9 @@ > /* > * Energy Model of CPUs Should this comment change too? > -static void em_debug_create_pd(struct em_perf_domain *pd, int cpu) > +static void em_debug_create_pd(struct device *dev) > { > struct dentry *d; > - char name[8]; > int i; > > - snprintf(name, sizeof(name), "pd%d", cpu); > - > /* Create the directory of the performance domain */ > - d = debugfs_create_dir(name, rootdir); > + d = debugfs_create_dir(dev_name(dev), rootdir); So what will be the name for the perf domain of CPUs now? cpuX? > @@ -142,8 +149,8 @@ em_create_pd(struct device *dev, int nr_states, struct em_data_callback *cb, > */ > opp_eff = freq / power; > if (opp_eff >= prev_opp_eff) > - pr_warn("pd%d: hertz/watts ratio non-monotonically decreasing: em_perf_state %d >= em_perf_state%d\n", > - cpu, i, i - 1); > + dev_dbg(dev, "EM: hertz/watts ratio non-monotonically decreasing: em_perf_state %d >= em_perf_state%d\n", > + i, i - 1); It feels like changing from warn to debug doesn't really belong to this patch no? > @@ -216,47 +274,50 @@ int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states, > */ > mutex_lock(&em_pd_mutex); > > - for_each_cpu(cpu, span) { > - /* Make sure we don't register again an existing domain. */ > - if (READ_ONCE(per_cpu(em_data, cpu))) { > - ret = -EEXIST; > - goto unlock; > - } > + if (dev->em_pd) { > + ret = -EEXIST; > + goto unlock; > + } > > - /* > - * All CPUs of a domain must have the same micro-architecture > - * since they all share the same table. > - */ > - cap = arch_scale_cpu_capacity(cpu); > - if (prev_cap && prev_cap != cap) { > - pr_err("CPUs of %*pbl must have the same capacity\n", > - cpumask_pr_args(span)); > + if (_is_cpu_device(dev)) { Something like if (!_is_cpu_device(dev)) goto device; would limit the diff a bit, but that may just be personal taste. But appart from these nits, the patch LGTM. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C259C54E8B for ; Tue, 12 May 2020 07:10:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00DBD2075E for ; Tue, 12 May 2020 07:10:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="mEYRAboh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00DBD2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9DB36E85B; Tue, 12 May 2020 07:09:34 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 21B2F89F31 for ; Mon, 11 May 2020 13:43:25 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id l11so5126158wru.0 for ; Mon, 11 May 2020 06:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0fpk5Xqv9Yro05H314xa5B77PsSpk1e22VGbukZepR0=; b=mEYRAbohHj9FT80QIN/XzGP0RK1RJdYQ+SPBVrhjGvEG1fo/b/wSbQUryrPWgltT0o IkcFU/TN3+CssRVyv7w9pbFo1Ao857ZUnI61mXnTixG4CNdUkxo1TqBtb+18gV/r0s9T PPmzLqaj4sRqLx9LKDx1ZKjj7S/l7K66pZ7BoueguIMGC7RkhcUpGCTxIqf80k1bRJMt K4r7mmsbyu5ERiD9qkW6VioEmXn0IV06q0wEgK46c748II6H/HGiqFskqR/x66mf2GeN X68E2XP0oEEZzqsVFopP+39+jSNN9eg9gI+iHo96H/QWJXde4g2p+s6l6KmyLM09APAS DDWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0fpk5Xqv9Yro05H314xa5B77PsSpk1e22VGbukZepR0=; b=UJCT8L+Na7xfLxmPAApruwxv5so0vrwKXWNkEde11ZQYm5srm06bs5PjSrPwmQd5so hLb/QKaSJhGHcBYQjdKEBAFU/QVhxMmwSbMxowzDzFFG78EiwPLB1KnhrnbdOZEMF2Qp MFQgTYpNJOsr5bxohzO8rnlFi1ePvf1tdVT8nOYck9OIT2LLDifVdEqfLG0qhO7a9JMP esjwgt+F6heCDYRppdJnrxQVXP0qAbb66QIevi6VnnLXO0mtmsDrA9cKMNV1jS6c0zwA pzPBktNssx9IzICARlD9ZBMmfVvnP+zGM3CP9dbTqG+W11C8Rph651ayzKifQlvHc0DZ YekQ== X-Gm-Message-State: AGi0PuZmpxKx5Ua67UP/zngwH148aAWWqIOUzt0emv1JdC6OQAc8Flqe 4D4UW7FYuiKb1x/vOLUJjWoprQ== X-Google-Smtp-Source: APiQypItJDTCfkEocXHWq2r5Ng7HfPcqePb/ZXsdjVC/ZzMJj4eOCaQ+uMUlRLgbkt8pygDOHi6PUw== X-Received: by 2002:adf:eac6:: with SMTP id o6mr18960567wrn.297.1589204603437; Mon, 11 May 2020 06:43:23 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id q184sm27142122wma.25.2020.05.11.06.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 06:43:22 -0700 (PDT) Date: Mon, 11 May 2020 14:43:19 +0100 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v7 04/15] PM / EM: add support for other devices than CPUs in Energy Model Message-ID: <20200511134319.GA29112@google.com> References: <20200511111912.3001-1-lukasz.luba@arm.com> <20200511111912.3001-5-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511111912.3001-5-lukasz.luba@arm.com> X-Mailman-Approved-At: Tue, 12 May 2020 07:09:30 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, mka@chromium.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hey Lukasz, On Monday 11 May 2020 at 12:19:01 (+0100), Lukasz Luba wrote: > @@ -27,12 +29,15 @@ struct em_perf_state { > * em_perf_domain - Performance domain > * @table: List of performance states, in ascending order > * @nr_perf_states: Number of performance states > - * @cpus: Cpumask covering the CPUs of the domain > + * @cpus: Cpumask covering the CPUs of the domain. It's here > + * for performance reasons to avoid potential cache > + * misses during energy calculations in the scheduler And because that saves a pointer, and simplifies allocating/freeing that memory region :) > diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c > index 5b8a1566526a..9cc7f2973600 100644 > --- a/kernel/power/energy_model.c > +++ b/kernel/power/energy_model.c > @@ -2,8 +2,9 @@ > /* > * Energy Model of CPUs Should this comment change too? > -static void em_debug_create_pd(struct em_perf_domain *pd, int cpu) > +static void em_debug_create_pd(struct device *dev) > { > struct dentry *d; > - char name[8]; > int i; > > - snprintf(name, sizeof(name), "pd%d", cpu); > - > /* Create the directory of the performance domain */ > - d = debugfs_create_dir(name, rootdir); > + d = debugfs_create_dir(dev_name(dev), rootdir); So what will be the name for the perf domain of CPUs now? cpuX? > @@ -142,8 +149,8 @@ em_create_pd(struct device *dev, int nr_states, struct em_data_callback *cb, > */ > opp_eff = freq / power; > if (opp_eff >= prev_opp_eff) > - pr_warn("pd%d: hertz/watts ratio non-monotonically decreasing: em_perf_state %d >= em_perf_state%d\n", > - cpu, i, i - 1); > + dev_dbg(dev, "EM: hertz/watts ratio non-monotonically decreasing: em_perf_state %d >= em_perf_state%d\n", > + i, i - 1); It feels like changing from warn to debug doesn't really belong to this patch no? > @@ -216,47 +274,50 @@ int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states, > */ > mutex_lock(&em_pd_mutex); > > - for_each_cpu(cpu, span) { > - /* Make sure we don't register again an existing domain. */ > - if (READ_ONCE(per_cpu(em_data, cpu))) { > - ret = -EEXIST; > - goto unlock; > - } > + if (dev->em_pd) { > + ret = -EEXIST; > + goto unlock; > + } > > - /* > - * All CPUs of a domain must have the same micro-architecture > - * since they all share the same table. > - */ > - cap = arch_scale_cpu_capacity(cpu); > - if (prev_cap && prev_cap != cap) { > - pr_err("CPUs of %*pbl must have the same capacity\n", > - cpumask_pr_args(span)); > + if (_is_cpu_device(dev)) { Something like if (!_is_cpu_device(dev)) goto device; would limit the diff a bit, but that may just be personal taste. But appart from these nits, the patch LGTM. Thanks, Quentin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel