From: Wei Liu <wei.liu@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Wei Liu <wei.liu@kernel.org>,
linux-pci@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
Bjorn Helgaas <bhelgaas@google.com>,
Allison Randal <allison@lohutok.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Enrico Weigelt <info@metux.net>
Subject: Re: [PATCH] PCI: export and use pci_msi_get_hwirq in pci-hyperv.c
Date: Mon, 11 May 2020 15:32:15 +0000 [thread overview]
Message-ID: <20200511153215.spcqylnde6p36n6j@liuwe-devbox-debian-v2.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net> (raw)
In-Reply-To: <20200507205831.GA30988@bogus>
On Thu, May 07, 2020 at 03:58:31PM -0500, Rob Herring wrote:
> On Wed, Apr 22, 2020 at 07:58:15PM +0000, Wei Liu wrote:
> > There is a functionally identical function in pci-hyperv.c. Drop it and
> > use pci_msi_get_hwirq instead.
> >
> > This requires exporting pci_msi_get_hwirq and declaring it in msi.h.
> >
> > No functional change intended.
> >
> > Signed-off-by: Wei Liu <wei.liu@kernel.org>
> > ---
> > arch/x86/include/asm/msi.h | 4 ++++
> > arch/x86/kernel/apic/msi.c | 5 +++--
> > drivers/pci/controller/pci-hyperv.c | 8 +-------
> > 3 files changed, 8 insertions(+), 9 deletions(-)
>
> Would be better if done in a way to remove an x86 dependency.
This is a good point, Rob. I will see what I can do.
Wei.
>
> I guess this would do it:
>
> #define pci_msi_get_hwirq NULL
>
> when GENERIC_MSI_DOMAIN_OPS is enabled.
prev parent reply other threads:[~2020-05-11 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 19:58 [PATCH] PCI: export and use pci_msi_get_hwirq in pci-hyperv.c Wei Liu
2020-05-07 20:58 ` Rob Herring
2020-05-11 15:32 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511153215.spcqylnde6p36n6j@liuwe-devbox-debian-v2.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net \
--to=wei.liu@kernel.org \
--cc=allison@lohutok.net \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=info@metux.net \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mingo@redhat.com \
--cc=robh@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.