All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: computersforpeace@gmail.com, kdasu.kdev@gmail.com,
	richard@nod.at, vigneshr@ti.com, sumit.semwal@linaro.org,
	linux-mtd@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH 1/3] nand: brcmnand: rename v4 registers
Date: Mon, 11 May 2020 19:03:21 +0200	[thread overview]
Message-ID: <20200511190321.1091bbf2@xps13> (raw)
In-Reply-To: <20200510151406.2527856-1-noltari@gmail.com>

Hi Álvaro,

Álvaro Fernández Rojas <noltari@gmail.com> wrote on Sun, 10 May 2020
17:14:04 +0200:

> These registers are also used on v3.3.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index e4e3ceeac38f..6a08dd07b058 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -338,8 +338,8 @@ enum brcmnand_reg {
>  	BRCMNAND_FC_BASE,
>  };
>  
> -/* BRCMNAND v4.0 */
> -static const u16 brcmnand_regs_v40[] = {
> +/* BRCMNAND v3.3-v4.0 */
> +static const u16 brcmnand_regs_v33[] = {
>  	[BRCMNAND_CMD_START]		=  0x04,
>  	[BRCMNAND_CMD_EXT_ADDRESS]	=  0x08,
>  	[BRCMNAND_CMD_ADDRESS]		=  0x0c,
> @@ -591,8 +591,8 @@ static int brcmnand_revision_init(struct brcmnand_controller *ctrl)
>  		ctrl->reg_offsets = brcmnand_regs_v60;
>  	else if (ctrl->nand_version >= 0x0500)
>  		ctrl->reg_offsets = brcmnand_regs_v50;
> -	else if (ctrl->nand_version >= 0x0400)
> -		ctrl->reg_offsets = brcmnand_regs_v40;
> +	else if (ctrl->nand_version >= 0x0303)
> +		ctrl->reg_offsets = brcmnand_regs_v33;
>  
>  	/* Chip-select stride */
>  	if (ctrl->nand_version >= 0x0701)

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: vigneshr@ti.com, kdasu.kdev@gmail.com, richard@nod.at,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, linux-mtd@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	computersforpeace@gmail.com, sumit.semwal@linaro.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] nand: brcmnand: rename v4 registers
Date: Mon, 11 May 2020 19:03:21 +0200	[thread overview]
Message-ID: <20200511190321.1091bbf2@xps13> (raw)
In-Reply-To: <20200510151406.2527856-1-noltari@gmail.com>

Hi Álvaro,

Álvaro Fernández Rojas <noltari@gmail.com> wrote on Sun, 10 May 2020
17:14:04 +0200:

> These registers are also used on v3.3.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index e4e3ceeac38f..6a08dd07b058 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -338,8 +338,8 @@ enum brcmnand_reg {
>  	BRCMNAND_FC_BASE,
>  };
>  
> -/* BRCMNAND v4.0 */
> -static const u16 brcmnand_regs_v40[] = {
> +/* BRCMNAND v3.3-v4.0 */
> +static const u16 brcmnand_regs_v33[] = {
>  	[BRCMNAND_CMD_START]		=  0x04,
>  	[BRCMNAND_CMD_EXT_ADDRESS]	=  0x08,
>  	[BRCMNAND_CMD_ADDRESS]		=  0x0c,
> @@ -591,8 +591,8 @@ static int brcmnand_revision_init(struct brcmnand_controller *ctrl)
>  		ctrl->reg_offsets = brcmnand_regs_v60;
>  	else if (ctrl->nand_version >= 0x0500)
>  		ctrl->reg_offsets = brcmnand_regs_v50;
> -	else if (ctrl->nand_version >= 0x0400)
> -		ctrl->reg_offsets = brcmnand_regs_v40;
> +	else if (ctrl->nand_version >= 0x0303)
> +		ctrl->reg_offsets = brcmnand_regs_v33;
>  
>  	/* Chip-select stride */
>  	if (ctrl->nand_version >= 0x0701)

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2020-05-11 17:03 UTC|newest]

Thread overview: 117+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 15:14 [PATCH 1/3] nand: brcmnand: rename v4 registers Álvaro Fernández Rojas
2020-05-10 15:14 ` Álvaro Fernández Rojas
2020-05-10 15:14 ` Álvaro Fernández Rojas
2020-05-10 15:14 ` [PATCH 2/3] nand: brcmnand: fix CS0 layout Álvaro Fernández Rojas
2020-05-10 15:14   ` Álvaro Fernández Rojas
2020-05-10 15:14   ` Álvaro Fernández Rojas
2020-05-11 17:01   ` Miquel Raynal
2020-05-11 17:01     ` Miquel Raynal
2020-05-10 15:14 ` [PATCH 3/3] nand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas
2020-05-10 15:14   ` Álvaro Fernández Rojas
2020-05-10 15:14   ` Álvaro Fernández Rojas
2020-05-10 15:39   ` Florian Fainelli
2020-05-10 15:39     ` Florian Fainelli
2020-05-10 15:39     ` Florian Fainelli
2020-05-11 17:44   ` Miquel Raynal
2020-05-11 17:44     ` Miquel Raynal
2020-05-11 17:03 ` Miquel Raynal [this message]
2020-05-11 17:03   ` [PATCH 1/3] nand: brcmnand: rename v4 registers Miquel Raynal
2020-05-11 17:40 ` Miquel Raynal
2020-05-11 17:40   ` Miquel Raynal
2020-05-12  7:33 ` [PATCH v2 0/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas
2020-05-12  7:33   ` Álvaro Fernández Rojas
2020-05-12  7:33   ` Álvaro Fernández Rojas
2020-05-12  7:33   ` [PATCH v2 1/5] mtd: rawnand: brcmnand: rename v4 registers Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-12  7:33   ` [PATCH v2 2/5] mtd: rawnand: brcmnand: fix CS0 layout Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-12  7:33   ` [PATCH v2 3/5] mtd: rawnand: brcmnand: rename page sizes Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-12  7:33   ` [PATCH v2 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-12  7:33   ` [PATCH v2 5/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-12  7:33     ` Álvaro Fernández Rojas
2020-05-22  7:25   ` [PATCH v3 0/5] " Álvaro Fernández Rojas
2020-05-22  7:25     ` Álvaro Fernández Rojas
2020-05-22  7:25     ` Álvaro Fernández Rojas
2020-05-22  7:25     ` [PATCH v3 1/5] mtd: rawnand: brcmnand: rename v4 registers Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22  7:25     ` [PATCH v3 2/5] mtd: rawnand: brcmnand: fix CS0 layout Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22  7:25     ` [PATCH v3 3/5] mtd: rawnand: brcmnand: rename page sizes Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22  7:25     ` [PATCH v3 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22  7:25     ` [PATCH v3 5/5] nand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22  7:25       ` Álvaro Fernández Rojas
2020-05-22 11:22       ` Miquel Raynal
2020-05-22 11:22         ` Miquel Raynal
2020-05-22 11:22         ` Miquel Raynal
2020-05-22 12:09         ` Álvaro Fernández Rojas
2020-05-22 12:09           ` Álvaro Fernández Rojas
2020-05-22 12:09           ` Álvaro Fernández Rojas
2020-05-22 12:15     ` [PATCH v4 0/5] mtd: rawnand: " Álvaro Fernández Rojas
2020-05-22 12:15       ` Álvaro Fernández Rojas
2020-05-22 12:15       ` Álvaro Fernández Rojas
2020-05-22 12:15       ` [PATCH v4 1/5] mtd: rawnand: brcmnand: rename v4 registers Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 15:33         ` Florian Fainelli
2020-05-22 15:33           ` Florian Fainelli
2020-05-22 15:33           ` Florian Fainelli
2020-05-24 19:26         ` Miquel Raynal
2020-05-24 19:26           ` Miquel Raynal
2020-05-24 19:26           ` Miquel Raynal
2020-05-22 12:15       ` [PATCH v4 2/5] mtd: rawnand: brcmnand: fix CS0 layout Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 15:35         ` Florian Fainelli
2020-05-22 15:35           ` Florian Fainelli
2020-05-22 15:35           ` Florian Fainelli
2020-05-24 19:26         ` Miquel Raynal
2020-05-24 19:26           ` Miquel Raynal
2020-05-24 19:26           ` Miquel Raynal
2020-05-22 12:15       ` [PATCH v4 3/5] mtd: rawnand: brcmnand: rename page sizes Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 15:35         ` Florian Fainelli
2020-05-22 15:35           ` Florian Fainelli
2020-05-22 15:35           ` Florian Fainelli
2020-05-24 19:26         ` Miquel Raynal
2020-05-24 19:26           ` Miquel Raynal
2020-05-24 19:26           ` Miquel Raynal
2020-05-22 12:15       ` [PATCH v4 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 15:36         ` Florian Fainelli
2020-05-22 15:36           ` Florian Fainelli
2020-05-22 15:36           ` Florian Fainelli
2020-05-24 19:25         ` Miquel Raynal
2020-05-24 19:25           ` Miquel Raynal
2020-05-24 19:25           ` Miquel Raynal
2020-05-24 19:27           ` Miquel Raynal
2020-05-24 19:27             ` Miquel Raynal
2020-05-24 19:27             ` Miquel Raynal
2020-05-24 21:13             ` Álvaro Fernández Rojas
2020-05-24 22:06               ` Miquel Raynal
2020-05-24 22:06                 ` Miquel Raynal
2020-05-24 22:06                 ` Miquel Raynal
2020-05-22 12:15       ` [PATCH v4 5/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 12:15         ` Álvaro Fernández Rojas
2020-05-22 15:37         ` Florian Fainelli
2020-05-22 15:37           ` Florian Fainelli
2020-05-22 15:37           ` Florian Fainelli
2020-05-24 22:06         ` Miquel Raynal
2020-05-24 22:06           ` Miquel Raynal
2020-05-24 22:06           ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511190321.1091bbf2@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=computersforpeace@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kdasu.kdev@gmail.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=noltari@gmail.com \
    --cc=richard@nod.at \
    --cc=sumit.semwal@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.