From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 11 May 2020 17:15:44 -0400 Subject: [PATCH v3 21/22] Use __ASSEMBLY__ as the assembly macros In-Reply-To: References: <20200510174013.145466-1-sjg@chromium.org> <20200510174013.145466-6-sjg@chromium.org> Message-ID: <20200511211544.GU12564@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 11, 2020 at 02:28:54PM -0600, Simon Glass wrote: > Hi Masahiro, > > On Sun, 10 May 2020 at 22:57, Masahiro Yamada wrote: > > > > On Mon, May 11, 2020 at 2:43 AM Simon Glass wrote: > > > > > > Some places use __ASSEMBLER__ instead which does not work since the > > > Makefile does not define it. Fix them. > > > > > > Signed-off-by: Simon Glass > > > > > > I think we decided to not do this in v2, didn't we? > > > > http://patchwork.ozlabs.org/project/uboot/patch/20200409201506.133129-6-sjg at chromium.org/ > > I must have misunderstood that thread. I think we should be consistent > in U-Boot as to which one we use. It makes it much harder to check > things when there are multiple options. So, we should generally use __ASSMEBLY__ which is what U-Boot and Linux kernel have used for forever. I do see a handful of __ASSEMBLER__ in Linux now. That said: > > > include/atf_common.h | 2 +- atf_common.h comes from another project, so this is just going to introduce sync-noise and unlikely to matter for the binman use-case? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: